[PATCH v1 0/3] Port and support rk3036 SoC platform

[PATCH v1 0/3] Port and support rk3036 SoC platform

[Xing Zheng]

Hi,
We need to support rk3036 soc platform via upstream, there are
3 parts for the initial release of minimum system: dts, pinctrl,
and clock tree for rk3036, startup and run to init processs.

Thanks.


Changes in v1:
Signed-off-by: Xing Zheng <zhengxing@rock-chips.com>

Xing Zheng (3):
  ARM: dts: rockchip: add core rk3036 dts
  pinctrl: rockchip: add support for the rk3036
  clk: rockchip: add clock controller for rk3036

 arch/arm/boot/dts/Makefile             |    1 +
 arch/arm/boot/dts/rk3036-sdk.dts       |  362 +++++++++++++++++++++
 drivers/clk/rockchip/Makefile          |    1 +
 drivers/clk/rockchip/clk-pll.c         |  247 ++++++++++++++-
 drivers/clk/rockchip/clk-rk3036.c      |  539 ++++++++++++++++++++++++++++++++
 drivers/clk/rockchip/clk.h             |   30 ++
 drivers/pinctrl/pinctrl-rockchip.c     |   17 +
 include/dt-bindings/clock/rk3036-cru.h |  247 +++++++++++++++
 8 files changed, 1443 insertions(+), 1 deletion(-)
 create mode 100644 arch/arm/boot/dts/rk3036-sdk.dts
 create mode 100644 drivers/clk/rockchip/clk-rk3036.c
 create mode 100644 include/dt-bindings/clock/rk3036-cru.h

-- 
1.7.9.5

[PATCH v1 2/3] pinctrl: rockchip: add support for the rk3036

[Xing Zheng]

Many parts of pinctrl rk3036 are similar to rk2928's.

Signed-off-by: Xing Zheng <zhengxing@rock-chips.com>
---

Changes in v1: None

 drivers/pinctrl/pinctrl-rockchip.c |   17 +++++++++++++++++
 1 file changed, 17 insertions(+)

diff --git a/drivers/pinctrl/pinctrl-rockchip.c b/drivers/pinctrl/pinctrl-rockchip.c
index cc2843a..d06631d 100644
--- a/drivers/pinctrl/pinctrl-rockchip.c
+++ b/drivers/pinctrl/pinctrl-rockchip.c
@@ -2042,6 +2042,21 @@ static struct rockchip_pin_ctrl rk2928_pin_ctrl = {
 		.pull_calc_reg		= rk2928_calc_pull_reg_and_bit,
 };
 
+static struct rockchip_pin_bank rk3036_pin_banks[] = {
+	PIN_BANK(0, 32, "gpio0"),
+	PIN_BANK(1, 32, "gpio1"),
+	PIN_BANK(2, 32, "gpio2"),
+};
+
+static struct rockchip_pin_ctrl rk3036_pin_ctrl = {
+		.pin_banks		= rk3036_pin_banks,
+		.nr_banks		= ARRAY_SIZE(rk3036_pin_banks),
+		.label			= "RK3036-GPIO",
+		.type			= RK2928,
+		.grf_mux_offset		= 0xa8,
+		.pull_calc_reg		= rk2928_calc_pull_reg_and_bit,
+};
+
 static struct rockchip_pin_bank rk3066a_pin_banks[] = {
 	PIN_BANK(0, 32, "gpio0"),
 	PIN_BANK(1, 32, "gpio1"),
@@ -2160,6 +2175,8 @@ static struct rockchip_pin_ctrl rk3368_pin_ctrl = {
 static const struct of_device_id rockchip_pinctrl_dt_match[] = {
 	{ .compatible = "rockchip,rk2928-pinctrl",
 		.data = (void *)&rk2928_pin_ctrl },
+	{ .compatible = "rockchip,rk3036-pinctrl",
+		.data = (void *)&rk3036_pin_ctrl },
 	{ .compatible = "rockchip,rk3066a-pinctrl",
 		.data = (void *)&rk3066a_pin_ctrl },
 	{ .compatible = "rockchip,rk3066b-pinctrl",
-- 
1.7.9.5

Re: [PATCH v1 2/3] pinctrl: rockchip: add support for the rk3036

[Heiko Stuebner]

Hi,

Am Freitag, 28. August 2015, 13:46:47 schrieb Xing Zheng:
> Many parts of pinctrl rk3036 are similar to rk2928's.
> 
> Signed-off-by: Xing Zheng <zhengxing@rock-chips.com>
> ---
> 
> Changes in v1: None
> 
>  drivers/pinctrl/pinctrl-rockchip.c |   17 +++++++++++++++++
>  1 file changed, 17 insertions(+)

please also add the new "rockchip,rk3036-pinctrl" compatible to 
Documentation/devicetree/pinctrl/rockchip,pinctrl.txt


I've checked the values against the rk3036 TRM and everything seems to fit, so 
with the missing compatible added to the binding you can add my

Reviewed-by: Heiko Stuebner <heiko@sntech.de>


Heiko

Re: [PATCH v1 0/3] Port and support rk3036 SoC platform

[Heiko Stuebner]

Hi,

Am Freitag, 28. August 2015, 13:46:45 schrieb Xing Zheng:
> We need to support rk3036 soc platform via upstream, there are
> 3 parts for the initial release of minimum system: dts, pinctrl,
> and clock tree for rk3036, startup and run to init processs.

this is really cool that you're working on supporting the rk3036.
I had some comments to the individual patches, but overall it looks quite nice 
already.


So, thanks for working on this
Heiko

Re: [PATCH v1 0/3] Port and support rk3036 SoC platform

[Xing Zheng]

HI Heiko,
Thank you for your reply. I will improve them as quickly as possible.

Thanks. :)

On 2015年08月28日 17:59, Heiko Stuebner wrote:
> Hi,
>
> Am Freitag, 28. August 2015, 13:46:45 schrieb Xing Zheng:
>> We need to support rk3036 soc platform via upstream, there are
>> 3 parts for the initial release of minimum system: dts, pinctrl,
>> and clock tree for rk3036, startup and run to init processs.
> this is really cool that you're working on supporting the rk3036.
> I had some comments to the individual patches, but overall it looks quite nice
> already.
>
>
> So, thanks for working on this
> Heiko
>
>
>
>

Re: [PATCH v1 2/3] pinctrl: rockchip: add support for the rk3036

[Linus Walleij]

On Thu, Aug 27, 2015 at 10:46 PM, Xing Zheng <zhengxing@rock-chips.com> wrote:

> Many parts of pinctrl rk3036 are similar to rk2928's.
>
> Signed-off-by: Xing Zheng <zhengxing@rock-chips.com>

Patch applied with Heiko's ACK, and THANKS to Rockchip and
Xing for working in the open community with this nowadays, way to go!

Yours,
Linus Walleij