From: Markus Elfring <Markus.Elfring@web.de>
To: Andrei Stefanescu <andrei.stefanescu@oss.nxp.com>,
Ghennadi Procopciuc <ghennadi.procopciuc@nxp.com>,
Larisa Grigore <larisa.grigore@nxp.com>,
Phu Luu An <phu.luuan@nxp.com>,
linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Bartosz Golaszewski <brgl@bgdev.pl>,
Chester Lin <chester62515@gmail.com>,
Conor Dooley <conor+dt@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Matthias Brugger <mbrugger@suse.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Rob Herring <robh@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>, s32@nxp.com
Subject: Re: [PATCH v2 3/4] gpio: siul2-s32g2: add NXP S32G2/S32G3 SoCs support
Date: Sat, 14 Sep 2024 18:40:07 +0200 [thread overview]
Message-ID: <65f9ea8f-dd4d-4b57-9c53-cf9a9b475b06@web.de> (raw)
In-Reply-To: <20240913082937.444367-4-andrei.stefanescu@oss.nxp.com>
…
> +++ b/drivers/gpio/gpio-siul2-s32g2.c
> @@ -0,0 +1,581 @@
…
> +static void siul2_gpio_set_direction(struct siul2_gpio_dev *dev,
> + unsigned int gpio, int dir)
> +{
> + unsigned long flags;
> +
> + raw_spin_lock_irqsave(&dev->lock, flags);
…
> + raw_spin_unlock_irqrestore(&dev->lock, flags);
> +}
…
Under which circumstances would you become interested to apply a statement
like “guard(raw_spinlock_irqsave)(&dev->lock);”?
https://elixir.bootlin.com/linux/v6.11-rc7/source/include/linux/spinlock.h#L551
Regards,
Markus
next prev parent reply other threads:[~2024-09-14 16:40 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-13 8:29 [PATCH v2 0/4] gpio: siul2-s32g2: add initial GPIO driver Andrei Stefanescu
2024-09-13 8:29 ` [PATCH v2 1/4] drivers: provide devm_platform_get_and_ioremap_resource_byname() Andrei Stefanescu
2024-09-18 7:52 ` Matthias Brugger
2024-09-13 8:29 ` [PATCH v2 2/4] dt-bindings: gpio: add support for NXP S32G2/S32G3 SoCs Andrei Stefanescu
2024-09-13 9:35 ` Rob Herring (Arm)
2024-09-13 9:55 ` Andrei Stefanescu
2024-09-13 14:13 ` Rob Herring
2024-09-16 6:01 ` Andrei Stefanescu
2024-09-13 8:29 ` [PATCH v2 3/4] gpio: siul2-s32g2: add NXP S32G2/S32G3 SoCs support Andrei Stefanescu
2024-09-14 16:40 ` Markus Elfring [this message]
2024-09-16 8:14 ` Andrei Stefanescu
2024-09-13 8:29 ` [PATCH v2 4/4] MAINTAINERS: add MAINTAINER for S32G2 SIUL2 GPIO driver Andrei Stefanescu
2024-09-13 11:05 ` Greg Kroah-Hartman
2024-09-13 12:33 ` Andrei Stefanescu
2024-09-17 17:44 ` Krzysztof Kozlowski
2024-09-18 7:57 ` Andrei Stefanescu
2024-09-18 8:13 ` Krzysztof Kozlowski
2024-09-18 9:01 ` Andrei Stefanescu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=65f9ea8f-dd4d-4b57-9c53-cf9a9b475b06@web.de \
--to=markus.elfring@web.de \
--cc=andrei.stefanescu@oss.nxp.com \
--cc=brgl@bgdev.pl \
--cc=chester62515@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=ghennadi.procopciuc@nxp.com \
--cc=gregkh@linuxfoundation.org \
--cc=krzk+dt@kernel.org \
--cc=larisa.grigore@nxp.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mbrugger@suse.com \
--cc=phu.luuan@nxp.com \
--cc=rafael@kernel.org \
--cc=robh@kernel.org \
--cc=s32@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).