From: Michael Walle <michael@walle.cc>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Esteban Blanc <eblanc@baylibre.com>,
lgirdwood@gmail.com, broonie@kernel.org, a.zummo@towertech.it,
alexandre.belloni@bootlin.com, linux-kernel@vger.kernel.org,
linux-gpio@vger.kernel.org, linux-rtc@vger.kernel.org,
jpanis@baylibre.com, jneanne@baylibre.com,
aseketeli@baylibre.com, sterzik@ti.com, u-kumar1@ti.com
Subject: Re: [PATCH v3 2/3] pinctrl: tps6594: add for TPS6594 PMIC
Date: Fri, 05 May 2023 13:31:21 +0200 [thread overview]
Message-ID: <66a8224ffbeede1e8296a2aef60fc73d@walle.cc> (raw)
In-Reply-To: <CACRpkdZ8oudy3XfKggZm5srJfOxmRXoFUoiuA3P4i0RTCdc5fQ@mail.gmail.com>
Hi,
>> I noticed that I could override reg_mask_xlate, so I should be able to
>> "just" match on the base address given as argument to perform a
>> different computation depending on whether we are using reg_mask_xlate
>> in
>> a "direction change" or not, but somehow this feels a bit wrong.
>>
>> Is this the correct solution?
>> Am I missing something?
No you don't miss anything. This is the actual use case for the base
parameter. If you need your own .xlate you can match on the base address
to do the translation based on wether it is used for .direction, .set
or .get.
I.e.
switch (base) {
case REG_IO_CTRL:
do_something_with_reg_and_mask;
case REG_DAT:
do_something_different_with_reg_and_mask;
default:
error;
}
-michael
next prev parent reply other threads:[~2023-05-05 11:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-14 10:12 [PATCH v3 0/3] TI TPS6594 PMIC support (RTC, pinctrl, regulators) Esteban Blanc
2023-04-14 10:12 ` [PATCH v3 1/3] rtc: tps6594: add driver for TPS6594 PMIC RTC Esteban Blanc
2023-04-14 10:12 ` [PATCH v3 2/3] pinctrl: tps6594: add for TPS6594 PMIC Esteban Blanc
2023-04-21 8:34 ` Linus Walleij
2023-05-03 11:37 ` Esteban Blanc
2023-05-05 11:23 ` Linus Walleij
2023-05-05 11:31 ` Michael Walle [this message]
2023-05-05 12:10 ` Esteban Blanc
2023-04-14 10:12 ` [PATCH v3 3/3] regulator: tps6594-regulator: Add driver for TI TPS6594 regulators Esteban Blanc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=66a8224ffbeede1e8296a2aef60fc73d@walle.cc \
--to=michael@walle.cc \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=aseketeli@baylibre.com \
--cc=broonie@kernel.org \
--cc=eblanc@baylibre.com \
--cc=jneanne@baylibre.com \
--cc=jpanis@baylibre.com \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=sterzik@ti.com \
--cc=u-kumar1@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).