From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ray Jui Subject: Re: [PATCH 11/61] gpio: bcm-kona: Use devm_gpiochip_add_data() for gpio registration Date: Mon, 22 Feb 2016 09:17:13 -0800 Message-ID: <67faee9e-e234-fc60-5465-3193bed4a7c3@broadcom.com> References: <1456150130-2668-1-git-send-email-ldewangan@nvidia.com> <1456150130-2668-12-git-send-email-ldewangan@nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from 5520-maca-inet1-outside.broadcom.com ([216.31.211.11]:55097 "EHLO mail-irv-18.broadcom.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751436AbcBVRRS (ORCPT ); Mon, 22 Feb 2016 12:17:18 -0500 In-Reply-To: <1456150130-2668-12-git-send-email-ldewangan@nvidia.com> Sender: linux-gpio-owner@vger.kernel.org List-Id: linux-gpio@vger.kernel.org To: Laxman Dewangan , linus.walleij@linaro.org, gnurou@gmail.com, michael.hennerich@analog.com, corbet@lwn.net, albeu@free.fr, rjui@broadcom.com, shc_work@mail.ru, support.opensource@diasemi.com, swarren@wwwdotorg.org, thierry.reding@gmail.com Cc: bjorn.andersson@sonymobile.com, a.kesavan@samsung.com, gregkh@linuxfoundation.org, catalin.marinas@arm.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, patches@opensource.wolfsonmicro.com, bcm-kernel-feedback-list@broadcom.com, linux-arm-kernel@lists.infradead.org, linux-tegra@vger.kernel.org On 2/22/2016 6:08 AM, Laxman Dewangan wrote: > Use devm_gpiochip_add_data() for GPIO registration. > > Signed-off-by: Laxman Dewangan > Cc: Ray Jui > --- > drivers/gpio/gpio-bcm-kona.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpio/gpio-bcm-kona.c b/drivers/gpio/gpio-bcm-kona.c > index b6c5abe..2fd38d5 100644 > --- a/drivers/gpio/gpio-bcm-kona.c > +++ b/drivers/gpio/gpio-bcm-kona.c > @@ -630,7 +630,7 @@ static int bcm_kona_gpio_probe(struct platform_device *pdev) > > bcm_kona_gpio_reset(kona_gpio); > > - ret = gpiochip_add_data(chip, kona_gpio); > + ret = devm_gpiochip_add_data(dev, chip, kona_gpio); > if (ret < 0) { > dev_err(dev, "Couldn't add GPIO chip -- %d\n", ret); > goto err_irq_domain; > Acked-by: Ray Jui Thanks!