From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9CF7C4727E for ; Thu, 1 Oct 2020 07:59:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6A1662145D for ; Thu, 1 Oct 2020 07:59:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725894AbgJAH7n (ORCPT ); Thu, 1 Oct 2020 03:59:43 -0400 Received: from bhuna.collabora.co.uk ([46.235.227.227]:33056 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725892AbgJAH7n (ORCPT ); Thu, 1 Oct 2020 03:59:43 -0400 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: eballetbo) with ESMTPSA id 7B4B129D23B Subject: Re: [PATCH v2] pinctrl: mediatek: Free eint data on failure To: Linus Walleij , Sean Wang Cc: lkml , Collabora Kernel ML , Matthias Brugger , Nicolas Boichat , hsinyi@chromium.org, linux-arm Mailing List , "open list:GPIO SUBSYSTEM" , "moderated list:ARM/Mediatek SoC support" References: <20200821075452.1543610-1-enric.balletbo@collabora.com> <99821f85-9a38-7591-f982-872603b6ce8a@collabora.com> From: Enric Balletbo i Serra Message-ID: <6a04c7b7-dd70-10c2-fc69-08b6b6c33d03@collabora.com> Date: Thu, 1 Oct 2020 09:59:38 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Hi, On 1/10/20 9:58, Linus Walleij wrote: > On Wed, Sep 30, 2020 at 6:33 PM Sean Wang wrote: >> On Wed, Sep 30, 2020 at 1:47 AM Linus Walleij wrote: >>> On Sun, Sep 27, 2020 at 7:57 PM Sean Wang wrote: >>> >>>> v2 seems the same with v1 or I was missing something. >>>> >>>> I just thought we call devm_ioremap_release to explicitly to free >>>> resource when a certain failure occurs after >>>> devm_ioremap_resource? >>> >>> What is the semantics around mtk_build_eint()? >>> >> >> mtk_build_eint is to add external interrupt function to the >> corresponding bound pins. >> mtk pinctrl driver still can work (than means probe() successfully) to >> keep pinctrl functional even with there is an error in mtk_build_eint. >> So the patch is used to explicitly free those data on failure in >> mtk_build_eint to let unused data is being free:ed immediately. > > OK then we need a v3 of this that will call *release > explicitly, indeed. > Yes, don't really know what happened with v2. I'll send a v3 ASAP. > Thanks Sean! > Linus Walleij >