From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A32DC43334 for ; Thu, 9 Jun 2022 15:32:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240115AbiFIPb7 (ORCPT ); Thu, 9 Jun 2022 11:31:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56464 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243423AbiFIPb6 (ORCPT ); Thu, 9 Jun 2022 11:31:58 -0400 Received: from mail-ed1-x52e.google.com (mail-ed1-x52e.google.com [IPv6:2a00:1450:4864:20::52e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0DDEE12768 for ; Thu, 9 Jun 2022 08:31:56 -0700 (PDT) Received: by mail-ed1-x52e.google.com with SMTP id v19so31698184edd.4 for ; Thu, 09 Jun 2022 08:31:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=PeAB4WdUupDaLbzIqQrrnRA29amPQ8PYJd3E0QmEGsE=; b=EakJTslO6FLE81sHxNC1bk/UhJdyWwE3LaolAbYnM/XwG1uFz5Ko+NX7UNNu3tbcoN K4rcFigA5wVJgxMnlO7NLPQdS3C/ggA1Vn8OzBb8vvyKZFT1e8iQCHxDYA2eB8gQtft+ 7HzbxwQvQgZY6ae+bwehfzc7RnStB3PIBUZf7baw2dZU6u3EZKK9c5vh03InUK7PI/Xs PjArKEXUAAVAQfrkTYYW6QeCkqxbR+gH5Pemmw+ozW5iwl6YhpAMgD9p9LlKl6lrcgHH VT+W3GXIoaXr5Nc/REr/+pECZOjR0CqcLiiXkWlDSxBfAIMKAiL7Nj6L+FzleyxE5OcS rrfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=PeAB4WdUupDaLbzIqQrrnRA29amPQ8PYJd3E0QmEGsE=; b=wIQsq4l7QpRL+iOfM+IsMk43D/E9+u41BjSzaUUIS9w861U64h90A4eVwat0kVeW/K 2Hj6nx7n61qWWvhoVlGeIYykQiwEN7Q8cGs4jEEnRplW/8gmkisEfIE4DkFaeS7oTZ3t DAEFPXCWrasBO39HUWGod6MaksbvxnLEGqqHtorejbabynNXHKeij1fJmKhtMXM5Hh/E 2pV3n++4wFMRqNcztg6rAZArM6xHri0sPZ14zgoco2ACgXWvtpVuzLykYxP18ZgIy6D/ KPg3xsK4a0zmEu4IdVDjv0/liqDDthPa92dUSvb4H6gJFjCtIt+OdRG94rYc4V8ddf3u 30VA== X-Gm-Message-State: AOAM532sp9vWBpwc6y0IR/Q7oeZH/T+yHBAG+12p3YPQXtXV/vZCpMFL c/obHFZZTeeTvEz3tQ/BxfVgUw== X-Google-Smtp-Source: ABdhPJwOIiJjZlxWJ8Qllh5BIHfUY6pWFLHsCbCBYUYtWh67b6d6/Fy01aSRrec+f5WJFGHljJB2KQ== X-Received: by 2002:a05:6402:2788:b0:431:3f86:1d4e with SMTP id b8-20020a056402278800b004313f861d4emr29911904ede.238.1654788714499; Thu, 09 Jun 2022 08:31:54 -0700 (PDT) Received: from [192.168.0.199] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id f27-20020a17090624db00b006f3ef214dcdsm10940096ejb.51.2022.06.09.08.31.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 09 Jun 2022 08:31:53 -0700 (PDT) Message-ID: <6d460a14-5da3-19f8-c614-307c2e737c17@linaro.org> Date: Thu, 9 Jun 2022 17:31:52 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH v2 04/48] dt-bindings: pinctrl: nuvoton,wpcm450-pinctrl: align key node name Content-Language: en-US To: =?UTF-8?Q?Jonathan_Neusch=c3=a4fer?= Cc: Arnd Bergmann , Olof Johansson , arm@kernel.org, soc@kernel.org, Linus Walleij , Rob Herring , Krzysztof Kozlowski , openbmc@lists.ozlabs.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220609113721.379932-1-krzysztof.kozlowski@linaro.org> <20220609113911.380368-3-krzysztof.kozlowski@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On 09/06/2022 17:20, Jonathan Neuschäfer wrote: > On Thu, Jun 09, 2022 at 01:39:06PM +0200, Krzysztof Kozlowski wrote: >> gpio-keys schema requires keys to have more generic name. >> >> Signed-off-by: Krzysztof Kozlowski >> --- >> .../devicetree/bindings/pinctrl/nuvoton,wpcm450-pinctrl.yaml | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/pinctrl/nuvoton,wpcm450-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/nuvoton,wpcm450-pinctrl.yaml >> index 47a56b83a610..4c7691c38b10 100644 >> --- a/Documentation/devicetree/bindings/pinctrl/nuvoton,wpcm450-pinctrl.yaml >> +++ b/Documentation/devicetree/bindings/pinctrl/nuvoton,wpcm450-pinctrl.yaml >> @@ -152,7 +152,7 @@ examples: >> pinctrl-names = "default"; >> pinctrl-0 = <&pinctrl_uid>, <&pinmux_uid>; >> >> - uid { >> + switch-uid { > > In this example, and more importantly the original copy in > nuvoton-wpcm450-supermicro-x9sci-ln4f.dts, I think button-uid fits > slightly better, because it's a momentary push button. (Still arguably a > switch, but not one that would stay in both the on and off position.) Sure, I'll change it to button-uid. Thanks! Best regards, Krzysztof