From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 991D6C433DB for ; Mon, 15 Feb 2021 13:58:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 602D2600CF for ; Mon, 15 Feb 2021 13:58:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230307AbhBON6C (ORCPT ); Mon, 15 Feb 2021 08:58:02 -0500 Received: from mx08-00178001.pphosted.com ([91.207.212.93]:4220 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S230142AbhBON6A (ORCPT ); Mon, 15 Feb 2021 08:58:00 -0500 Received: from pps.filterd (m0046660.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 11FDq8UQ009146; Mon, 15 Feb 2021 14:56:59 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h=subject : from : to : cc : references : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=selector1; bh=OBeyeTFxKgl8hhHSdOSxuj1e1QIjV0tDdTCwWxH9VkI=; b=IgesQH20dBFRCXv2Xlon5h08FLstAaZOB35Nv7yhho2QlPt9SZ6itqY8HzWMEzLnGK/w h7Xg/uvfCjPil3Rw3VWh57BaHC7XmjaAhlOlV5EU6hJ4/IBKr/O+9EqsFSiFTiWQ2g9a vp2HceZVenHx/dIEsHBQGvwv+rFAOlKvJYlJZd91yDLvhrFhBsiINDicqtyqz6d48uMm m4Dou1kcT/ApBV4Zapqvo4aDhsvfogf9MhYIwEz3GBRDRy8AFvLiHvtCFa0+lm4LtHv2 gWEkuozTvUJkF6T4hyCrkiQW7tEOc3lsG+QFO/A0tL8GMI+EZinRhH19YesJYZXXbPzq HQ== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com with ESMTP id 36p4sf3739-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 15 Feb 2021 14:56:59 +0100 Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id DCF7B100034; Mon, 15 Feb 2021 14:56:58 +0100 (CET) Received: from Webmail-eu.st.com (sfhdag2node3.st.com [10.75.127.6]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id C03A525F40C; Mon, 15 Feb 2021 14:56:58 +0100 (CET) Received: from [10.211.12.240] (10.75.127.47) by SFHDAG2NODE3.st.com (10.75.127.6) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Mon, 15 Feb 2021 14:56:57 +0100 Subject: Re: [PATCH] pinctrl: stm32: add missing of_node_put From: foss To: , , Maxime Coquelin , Alexandre TORGUE-SCND-02 , , Etienne CARRIERE-SCND-01 , , , CC: , "linux-stm32@st-md-mailman.stormreply.com" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , References: <4a576fb8-682e-d1af-777d-436f9bc53794@foss.st.com> Message-ID: <6d7ad2ea-92dc-3caa-a931-2c932325a46b@foss.st.com> Date: Mon, 15 Feb 2021 14:56:56 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <4a576fb8-682e-d1af-777d-436f9bc53794@foss.st.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [10.75.127.47] X-ClientProxiedBy: SFHDAG1NODE1.st.com (10.75.127.1) To SFHDAG2NODE3.st.com (10.75.127.6) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.369,18.0.761 definitions=2021-02-15_08:2021-02-12,2021-02-15 signatures=0 Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Resending in plain-text format. On 15/02/2021 2:26 pm, foss wrote: > > Hi Junlin > > > Thank you for the patch! > > > Fabien > > >> From: Junlin Yang >> >> Fix OF node leaks by calling of_node_put in for_each_available_child_of_node when the cycle returns. >> >> Generated by: scripts/coccinelle/iterators/for_each_child.cocci >> >> Signed-off-by: Junlin Yang > > Acked-by: Fabien Dessenne > > >> --- >> drivers/pinctrl/stm32/pinctrl-stm32.c | 5 ++++- >> 1 file changed, 4 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/pinctrl/stm32/pinctrl-stm32.c b/drivers/pinctrl/stm32/pinctrl-stm32.c >> index 7d9bded..da72e3e 100644 >> --- a/drivers/pinctrl/stm32/pinctrl-stm32.c >> +++ b/drivers/pinctrl/stm32/pinctrl-stm32.c >> @@ -1542,8 +1542,10 @@ int stm32_pctl_probe(struct platform_device *pdev) >> if (of_property_read_bool(child, "gpio-controller")) { >> bank->rstc = of_reset_control_get_exclusive(child, >> NULL); >> - if (PTR_ERR(bank->rstc) == -EPROBE_DEFER) >> + if (PTR_ERR(bank->rstc) == -EPROBE_DEFER) { >> + of_node_put(child); >> return -EPROBE_DEFER; >> + } >> >> bank->clk = of_clk_get_by_name(child, NULL); >> if (IS_ERR(bank->clk)) { >> @@ -1551,6 +1553,7 @@ int stm32_pctl_probe(struct platform_device *pdev) >> dev_err(dev, >> "failed to get clk (%ld)\n", >> PTR_ERR(bank->clk)); >> + of_node_put(child); >> return PTR_ERR(bank->clk); >> } >> i++; >> -- >> 1.9.1 >>