From: Krzysztof Kozlowski <krzk@kernel.org>
To: Cosmin-Gabriel Tanislav <cosmin-gabriel.tanislav.xa@renesas.com>
Cc: Geert Uytterhoeven <geert+renesas@glider.be>,
Linus Walleij <linus.walleij@linaro.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
"magnus.damm" <magnus.damm@gmail.com>,
Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>,
"linux-renesas-soc@vger.kernel.org"
<linux-renesas-soc@vger.kernel.org>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/8] dt-bindings: pinctrl: renesas,r9a09g077-pinctrl: Document GPIO IRQ
Date: Thu, 4 Dec 2025 17:00:03 +0100 [thread overview]
Message-ID: <6dbd12c9-08c3-4be5-b29c-c2dc29987015@kernel.org> (raw)
In-Reply-To: <TYYPR01MB1395515F6CBA3E3FBBAA4297085A6A@TYYPR01MB13955.jpnprd01.prod.outlook.com>
On 04/12/2025 10:30, Cosmin-Gabriel Tanislav wrote:
>>> @@ -119,6 +130,8 @@ required:
>>> - gpio-controller
>>> - '#gpio-cells'
>>> - gpio-ranges
>>> + - interrupt-controller
>>> + - '#interrupt-cells'
>>
>> This is technically an ABI break thus commit msg must explain WHY
>> breaking ABI is necessary and what is the impact on users.
>>
>> If your driver keeps things backwards compatible, then briefly mention
>> it in the commit msg that you require it only for complete hardware
>> picture. Or for whatever other reason.
>>
>
>
> It's not exactly required for the pinctrl to be defined as an interrupt
> controller, only if you use the interrupt functionality of the pins...
> I can remove them from required, that should keep compatibility.
>
> Would that be fine?
Yes.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-12-04 16:00 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-21 11:26 [PATCH 0/8] Add support for GPIO IRQs for RZ/T2H and RZ/N2H Cosmin Tanislav
2025-11-21 11:26 ` [PATCH 1/8] pinctrl: renesas: rzt2h: move GPIO enable/disable into separate function Cosmin Tanislav
2025-11-21 11:26 ` [PATCH 2/8] pinctrl: renesas: rzt2h: allow .get_direction() for IRQ function GPIOs Cosmin Tanislav
2025-11-21 11:26 ` [PATCH 3/8] dt-bindings: pinctrl: renesas,r9a09g077-pinctrl: Document GPIO IRQ Cosmin Tanislav
2025-12-03 8:03 ` Krzysztof Kozlowski
2025-12-04 9:30 ` Cosmin-Gabriel Tanislav
2025-12-04 16:00 ` Krzysztof Kozlowski [this message]
2025-11-21 11:26 ` [PATCH 4/8] pinctrl: renesas: rzt2h: add GPIO IRQ chip to handle interrupts Cosmin Tanislav
2025-12-03 23:34 ` Linus Walleij
2025-12-04 15:36 ` Cosmin-Gabriel Tanislav
2025-11-21 11:26 ` [PATCH 5/8] arm64: dts: renesas: r9a09g077: add GPIO IRQ support Cosmin Tanislav
2025-11-21 11:26 ` [PATCH 6/8] arm64: dts: renesas: r9a09g087: " Cosmin Tanislav
2025-11-21 11:26 ` [PATCH 7/8] arm64: dts: renesas: r9a09g077m44-rzt2h-evk: add GPIO keys Cosmin Tanislav
2025-11-21 11:26 ` [PATCH 8/8] arm64: dts: renesas: r9a09g087m44-rzn2h-evk: " Cosmin Tanislav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6dbd12c9-08c3-4be5-b29c-c2dc29987015@kernel.org \
--to=krzk@kernel.org \
--cc=conor+dt@kernel.org \
--cc=cosmin-gabriel.tanislav.xa@renesas.com \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=krzk+dt@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).