From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] arm64: dts: qcom: ipq8074: align TLMM pin configuration with DT schema
Date: Tue, 8 Nov 2022 17:48:45 +0100 [thread overview]
Message-ID: <6de8a161-b5fb-3360-fb01-636b47750ca0@linaro.org> (raw)
In-Reply-To: <20221108142357.67202-2-krzysztof.kozlowski@linaro.org>
On 08/11/2022 15:23, Krzysztof Kozlowski wrote:
> DT schema expects TLMM pin configuration nodes to be named with
> '-state' suffix and their optional children with '-pins' suffix.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
> arch/arm64/boot/dts/qcom/ipq8074.dtsi | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/ipq8074.dtsi b/arch/arm64/boot/dts/qcom/ipq8074.dtsi
> index d3d9e7eb5837..363ccc272cf1 100644
> --- a/arch/arm64/boot/dts/qcom/ipq8074.dtsi
> +++ b/arch/arm64/boot/dts/qcom/ipq8074.dtsi
> @@ -317,35 +317,35 @@ tlmm: pinctrl@1000000 {
> interrupt-controller;
> #interrupt-cells = <0x2>;
>
> - serial_4_pins: serial4-pinmux {
> + serial_4_pins: serial4-state {
> pins = "gpio23", "gpio24";
> function = "blsp4_uart1";
> drive-strength = <8>;
> bias-disable;
> };
>
> - i2c_0_pins: i2c-0-pinmux {
> + i2c_0_pins: i2c-0-state {
> pins = "gpio42", "gpio43";
> function = "blsp1_i2c";
> drive-strength = <8>;
> bias-disable;
> };
>
> - spi_0_pins: spi-0-pins {
> + spi_0_pins: spi-0-state {
> pins = "gpio38", "gpio39", "gpio40", "gpio41";
> function = "blsp0_spi";
> drive-strength = <8>;
> bias-disable;
> };
>
> - hsuart_pins: hsuart-pins {
> + hsuart_pins: hsuart-state {
> pins = "gpio46", "gpio47", "gpio48", "gpio49";
> function = "blsp2_uart";
> drive-strength = <8>;
> bias-disable;
> };
>
> - qpic_pins: qpic-pins {
> + qpic_pins: qpic-state {
> pins = "gpio1", "gpio3", "gpio4",
> "gpio5", "gpio6", "gpio7",
> "gpio8", "gpio10", "gpio11",
next prev parent reply other threads:[~2022-11-08 16:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-08 14:23 [PATCH 1/2] dt-bindings: pinctrl: qcom,ipq8074: convert to dtschema Krzysztof Kozlowski
2022-11-08 14:23 ` [PATCH 2/2] arm64: dts: qcom: ipq8074: align TLMM pin configuration with DT schema Krzysztof Kozlowski
2022-11-08 16:48 ` Konrad Dybcio [this message]
2022-11-09 9:09 ` [PATCH 1/2] dt-bindings: pinctrl: qcom,ipq8074: convert to dtschema Linus Walleij
2022-11-10 3:27 ` Bjorn Andersson
2022-11-10 4:09 ` (subset) " Bjorn Andersson
2022-11-14 9:40 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6de8a161-b5fb-3360-fb01-636b47750ca0@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).