From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47F87C433FE for ; Tue, 8 Nov 2022 16:48:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233925AbiKHQsx (ORCPT ); Tue, 8 Nov 2022 11:48:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36184 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233891AbiKHQsv (ORCPT ); Tue, 8 Nov 2022 11:48:51 -0500 Received: from mail-lj1-x22c.google.com (mail-lj1-x22c.google.com [IPv6:2a00:1450:4864:20::22c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7672557B52 for ; Tue, 8 Nov 2022 08:48:49 -0800 (PST) Received: by mail-lj1-x22c.google.com with SMTP id b9so21985817ljr.5 for ; Tue, 08 Nov 2022 08:48:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:to:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=1d8zM1Nk8TzoHcMhFh9hgmVPfiaP9d7SJOKHf4Sgw5U=; b=rQoPq/x5bDn6fzMrraOcEQR1STfeX+apF14pw1s4D7AeGlvFVI83vUXl0E5M4Dus1c VfTucuyBDcf8qVwOLKDgn8+7qV0pALj82vVRtppnjHXFCbILRuMKkmW4kIb25y/xrv/w HKagzTp/+eww6/F1zoJ5XKtIUDtWzzJ6TflIsRCb7EczjpLvWb9IBgTC6mu7qH6jUEwm X+PmxAUqWJLIy90RltXmvj1B0AnPNUkpIeGQwjM/FQRsGAtYcmmXMJzRl5HLdglQVLXb VDCkUfOz6KymP5e5p75PenWJMmdx0izaA0aN8tEOmNY8kvwEK89MthI1sbj/YaLub3gU LcqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to:subject :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=1d8zM1Nk8TzoHcMhFh9hgmVPfiaP9d7SJOKHf4Sgw5U=; b=gKHhIrCviUjulC4wLAo4c0yl7OdBeYGlHx3E15RlF8hRQZSh8GqatwFoD7k5ww8tvb kSvpBFCCkMlmVt1T43x8LvPNCVNJaZywVYe3IzD7iEbn/eUlAs/EakYx067a696WqfAc VjbhTgYnAvBAlbwBaTDgEKd4Bvdm2dPhtx0eaZcV9IgWtx3w7UuSQitwN89t4qAt+cM2 hoE7bDd0+CaLFhdKWYG5X6rpLRHyD2qtanPLRg46qMOtFIV2qeVo0p6934nxmKwL0Ajs Dt3G/y3xiNl7gVxNySJNHFr94u8Cvd8voSE4c9ZUYNM+UNbdBIPID7fbmQdCC1wB/bEr 5zFA== X-Gm-Message-State: ACrzQf0dYBe4pVQkkcEOdtVZJnwooyOoOjHd9D7duZcyAY9ELp0l9kbn hPdzfR6ag11bJwlQkc/3g8UdVxWnlNUfeV8X X-Google-Smtp-Source: AMsMyM5u/9SiHwFpF+uzGkWvQeS7YbWX5nP97SYIoeUaZGEPGJjeK8HJb6U4PCKJiuYxE+HDWNCIPA== X-Received: by 2002:a2e:b94a:0:b0:277:91a:737 with SMTP id 10-20020a2eb94a000000b00277091a0737mr18538157ljs.25.1667926127850; Tue, 08 Nov 2022 08:48:47 -0800 (PST) Received: from [192.168.31.208] ([194.29.137.22]) by smtp.gmail.com with ESMTPSA id cf29-20020a056512281d00b0049496855494sm1854737lfb.104.2022.11.08.08.48.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 08 Nov 2022 08:48:47 -0800 (PST) Message-ID: <6de8a161-b5fb-3360-fb01-636b47750ca0@linaro.org> Date: Tue, 8 Nov 2022 17:48:45 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH 2/2] arm64: dts: qcom: ipq8074: align TLMM pin configuration with DT schema To: Krzysztof Kozlowski , Andy Gross , Bjorn Andersson , Linus Walleij , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20221108142357.67202-1-krzysztof.kozlowski@linaro.org> <20221108142357.67202-2-krzysztof.kozlowski@linaro.org> From: Konrad Dybcio In-Reply-To: <20221108142357.67202-2-krzysztof.kozlowski@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On 08/11/2022 15:23, Krzysztof Kozlowski wrote: > DT schema expects TLMM pin configuration nodes to be named with > '-state' suffix and their optional children with '-pins' suffix. > > Signed-off-by: Krzysztof Kozlowski > --- Reviewed-by: Konrad Dybcio Konrad > arch/arm64/boot/dts/qcom/ipq8074.dtsi | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/ipq8074.dtsi b/arch/arm64/boot/dts/qcom/ipq8074.dtsi > index d3d9e7eb5837..363ccc272cf1 100644 > --- a/arch/arm64/boot/dts/qcom/ipq8074.dtsi > +++ b/arch/arm64/boot/dts/qcom/ipq8074.dtsi > @@ -317,35 +317,35 @@ tlmm: pinctrl@1000000 { > interrupt-controller; > #interrupt-cells = <0x2>; > > - serial_4_pins: serial4-pinmux { > + serial_4_pins: serial4-state { > pins = "gpio23", "gpio24"; > function = "blsp4_uart1"; > drive-strength = <8>; > bias-disable; > }; > > - i2c_0_pins: i2c-0-pinmux { > + i2c_0_pins: i2c-0-state { > pins = "gpio42", "gpio43"; > function = "blsp1_i2c"; > drive-strength = <8>; > bias-disable; > }; > > - spi_0_pins: spi-0-pins { > + spi_0_pins: spi-0-state { > pins = "gpio38", "gpio39", "gpio40", "gpio41"; > function = "blsp0_spi"; > drive-strength = <8>; > bias-disable; > }; > > - hsuart_pins: hsuart-pins { > + hsuart_pins: hsuart-state { > pins = "gpio46", "gpio47", "gpio48", "gpio49"; > function = "blsp2_uart"; > drive-strength = <8>; > bias-disable; > }; > > - qpic_pins: qpic-pins { > + qpic_pins: qpic-state { > pins = "gpio1", "gpio3", "gpio4", > "gpio5", "gpio6", "gpio7", > "gpio8", "gpio10", "gpio11",