From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B0D37134B0 for ; Thu, 11 Apr 2024 15:07:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712848050; cv=none; b=RXLT5DBDUNGI1ZJvIq9jLOyjxfPLKuRoyRfljBYp2/Mm7fE95zcfxSS91u6fLRGEKDIsrRT4uWeXKVoUhbPwj6+Knt8fnPvB2K1kvZE/Fr/ZEiBxR0i+pz162HdZy0tXKJv8Wp2Kq6H6TkgvbMGAsGs0XGVLXyvpiOCHekGMyFw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712848050; c=relaxed/simple; bh=UwT3dZsEUGf2cX1eyjAmLR3tU+VqTAbl7oBJMslcH8s=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=pufND2ZeMZm0yuNZmxU26xTzqEbpUnLmU5edQ1fLem7aevejG0GrjW2vzGPQLeTlGGo7xMc8iMdIgDQUZq0Tk83PD4luW2pFU1XD+OMCJoo5jEbPLxLWBxARofH6VpB/2/US2V2ew8u/vQ6BWDnzgrmITYvIKWmF4khpl3Mfw90= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=IciBfujm; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="IciBfujm" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-417d08135b6so6932985e9.1 for ; Thu, 11 Apr 2024 08:07:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1712848046; x=1713452846; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=/tLI+vFCnYgSsVdj6Lzrkmb8rf2aK1682Kp6/AzfUhU=; b=IciBfujmokgVCFRhr2rv1oivQTQcn6ij1bJpZFGJ5gkD5AdZHw1+JWf7CLas0iHnIa F+Osh1gnLtGgNHc3MigDvIlpx7XXAegryWkv1tUH9gjhzU4l3A+WSbekTfoFGYzteoiv /UfOBg+2mO8IO13i4Q2+rUQYwoL4LX3hME/OZmuXBiPZ7+96dKrAbIbxInC8TXPX5fUU Mg5cTIhqBdweSBKJBGyaN2LFlvHFSLFXKFMckVON7jMiSehVxGO+vbYm1XMk1oICgPh2 7TGD/29dnL/MKMbtwQ9CubWHB7clCtE/ipxIC4G/FzCJ34/XlNmZ2mBmMoqz66+CNtFB Pk1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712848046; x=1713452846; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=/tLI+vFCnYgSsVdj6Lzrkmb8rf2aK1682Kp6/AzfUhU=; b=hRoH9kJtR2xC6czCQtrsuNrNWz9ZdSjM/R540m4FLEc6Kvj/PczQc/JeivjMdVdODr 2MA0MSbQ8+e0XKX8gAJCdwQW5+sqYTmrRAKTAduBIds1ch1WmX3wfL4HOKDEWTcjQIt9 retwQ8TrxTIYYUq/aBtP7nsivs+m3CNeuJhvulnIudw6T83rnEelqqdsqqmEKbJq+UZS AiNqRDeDLcdilVxEp24Qd5YHR5C5iXzMOocJVYovf9qO3mT0vGFvcOFKOMa56Elq2BUx SWz5s0XeVY0m0VQeuNDyDUUEkqh7JcufrSlUFsUg+mfmfKZY9hV1+yy+BS6M54E5O6ok bJoQ== X-Forwarded-Encrypted: i=1; AJvYcCUD7DwsDUM+BG+lbHwK640gMLy9KU52Q6D/UW0YWKNlzq1RSzNpbJojdVmaONICDvkdxwVQxPMVAj6GGIGQVgY5+kRiw4kzLJHxtQ== X-Gm-Message-State: AOJu0YwY+93AYiH+QHmh4NsIcNeHo1U05sWUoNmoF0icaHotar0tSlqq DVyciEJmFf5hloRXcRc81UFNSqLyATW2gQ7bGM7p0qhOTl1663EghEhlZsqy8CI= X-Google-Smtp-Source: AGHT+IHZCpov/oi1/ULO8NO1QPM1SvVEcXaBk5vf2wbEFJTyGDjalN4vwdfxdRsfT+Gg820ixSQYZQ== X-Received: by 2002:a5d:504c:0:b0:343:61bb:115d with SMTP id h12-20020a5d504c000000b0034361bb115dmr4398793wrt.26.1712848045998; Thu, 11 Apr 2024 08:07:25 -0700 (PDT) Received: from [192.168.1.20] ([178.197.223.16]) by smtp.gmail.com with ESMTPSA id k1-20020a5d6281000000b003445bb2362esm1974138wru.65.2024.04.11.08.07.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 11 Apr 2024 08:07:25 -0700 (PDT) Message-ID: <6e3b02d9-9a1e-4fc0-9459-9c9c0d37aa92@linaro.org> Date: Thu, 11 Apr 2024 17:07:23 +0200 Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 08/11] MIPS: mobileye: eyeq5: add OLB syscon node To: =?UTF-8?Q?Th=C3=A9o_Lebrun?= , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Michael Turquette , Stephen Boyd , Philipp Zabel , Linus Walleij Cc: linux-mips@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org, Vladimir Kondratiev , Gregory CLEMENT , Thomas Petazzoni , Tawfik Bayouk References: <20240410-mbly-olb-v1-0-335e496d7be3@bootlin.com> <20240410-mbly-olb-v1-8-335e496d7be3@bootlin.com> Content-Language: en-US From: Krzysztof Kozlowski Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 11/04/2024 16:34, Théo Lebrun wrote: > Hello, > > On Thu Apr 11, 2024 at 8:15 AM CEST, Krzysztof Kozlowski wrote: >> On 10/04/2024 19:12, Théo Lebrun wrote: >>> The OLB ("Other Logic Block") is a syscon region hosting clock, reset >>> and pin controllers. It contains registers such as I2C speed mode that >>> need to be accessible by other nodes. >>> >>> Signed-off-by: Théo Lebrun >>> --- >>> arch/mips/boot/dts/mobileye/eyeq5.dtsi | 8 ++++++++ >>> 1 file changed, 8 insertions(+) >>> >>> diff --git a/arch/mips/boot/dts/mobileye/eyeq5.dtsi b/arch/mips/boot/dts/mobileye/eyeq5.dtsi >>> index 6cc5980e2fa1..e82d2a57f6da 100644 >>> --- a/arch/mips/boot/dts/mobileye/eyeq5.dtsi >>> +++ b/arch/mips/boot/dts/mobileye/eyeq5.dtsi >>> @@ -100,6 +100,14 @@ uart2: serial@a00000 { >>> clock-names = "uartclk", "apb_pclk"; >>> }; >>> >>> + olb: system-controller@e00000 { >>> + compatible = "mobileye,eyeq5-olb", "syscon", "simple-mfd"; >>> + reg = <0 0xe00000 0x0 0x400>; >>> + ranges = <0x0 0x0 0xe00000 0x400>; >>> + #address-cells = <1>; >>> + #size-cells = <1>; >> >> Do not add incomplete node. ranges, address/size-cells are incorrect in >> this context and you will have warnings. >> >> Add complete node, so these properties make sense. > > I'll squash all four commits into one. For reference, commits are: > > - MIPS: mobileye: eyeq5: add OLB syscon node > - MIPS: mobileye: eyeq5: use OLB clocks controller node > - MIPS: mobileye: eyeq5: add OLB reset controller node > - MIPS: mobileye: eyeq5: add pinctrl node & pinmux function nodes > > This means two things: (1) it won't be partially applicable and (2) it Why? > will make one big commit adding pins and editing clocks. It never was partially applicable. Causing warnings does not make things partially applicable. If node is too big, although I personally do not agree, it's quite moderate size chunk, then sure, split pinctrl groups or pinctrl node to additional patch. Best regards, Krzysztof