linux-gpio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: Shawn Guo <shawnguo2@yeah.net>
Cc: linux-arm-kernel@lists.infradead.org,
	Rob Herring <robh@kernel.org>,
	Alexander Stein <alexander.stein@ew.tq-group.com>,
	Conor Dooley <conor+dt@kernel.org>,
	Dong Aisheng <aisheng.dong@nxp.com>,
	Fabio Estevam <festevam@gmail.com>, Jacky Bai <ping.bai@nxp.com>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Shawn Guo <shawnguo@kernel.org>, Stefan Wahren <wahrenst@gmx.net>,
	devicetree@vger.kernel.org, imx@lists.linux.dev,
	kernel@dh-electronics.com, linux-gpio@vger.kernel.org
Subject: Re: [PATCH v3 01/12] dt-bindings: pinctrl: fsl,imx6ul-pinctrl: Convert i.MX35/5x/6 to YAML
Date: Tue, 22 Oct 2024 05:52:08 +0200	[thread overview]
Message-ID: <6eb23f6c-fe0c-4ee1-8f99-568041524073@denx.de> (raw)
In-Reply-To: <ZxcbHb5v05+XhFnM@dragon>

On 10/22/24 5:25 AM, Shawn Guo wrote:
> On Thu, Oct 17, 2024 at 11:11:18PM +0200, Marek Vasut wrote:
>> The IOMUXC controller description is almost identical on i.MX35/5x/6 SoCs,
>> except for the configuration bits which differ across SoCs. Rename the
>> fsl,imx6ul-pinctrl.yaml to fsl,imx35-pinctrl.yaml, fill in compatible
>> strings for the other SoCs and fill in the various bits into desciption.
>> This way, i.MX35/5x/6 series SoCs can all be converted to DT schema.
>> Remove the old text DT bindings description.
>>
>> Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
>> Signed-off-by: Marek Vasut <marex@denx.de>
>> ---
>> Cc: Alexander Stein <alexander.stein@ew.tq-group.com>
>> Cc: Conor Dooley <conor+dt@kernel.org>
>> Cc: Dong Aisheng <aisheng.dong@nxp.com>
>> Cc: Fabio Estevam <festevam@gmail.com>
>> Cc: Jacky Bai <ping.bai@nxp.com>
>> Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>
>> Cc: Linus Walleij <linus.walleij@linaro.org>
>> Cc: Pengutronix Kernel Team <kernel@pengutronix.de>
>> Cc: Rob Herring <robh@kernel.org>
>> Cc: Sascha Hauer <s.hauer@pengutronix.de>
>> Cc: Shawn Guo <shawnguo@kernel.org>
>> Cc: Stefan Wahren <wahrenst@gmx.net>
>> Cc: devicetree@vger.kernel.org
>> Cc: imx@lists.linux.dev
>> Cc: kernel@dh-electronics.com
>> Cc: linux-arm-kernel@lists.infradead.org
>> Cc: linux-gpio@vger.kernel.org
>> ---
>> V2: - Use DT schema to refer to the fsl,imx35-pinctrl.yaml file
>>      - Special-case the iMX50 compatible string
>> V3: Add RB from Rob
>> ---
>>   .../bindings/pinctrl/fsl,imx35-pinctrl.txt    | 33 -------
>>   ...ul-pinctrl.yaml => fsl,imx35-pinctrl.yaml} | 88 ++++++++++++++++---
>>   .../bindings/pinctrl/fsl,imx50-pinctrl.txt    | 32 -------
>>   .../bindings/pinctrl/fsl,imx51-pinctrl.txt    | 32 -------
>>   .../bindings/pinctrl/fsl,imx53-pinctrl.txt    | 32 -------
>>   .../bindings/pinctrl/fsl,imx6dl-pinctrl.txt   | 38 --------
>>   .../bindings/pinctrl/fsl,imx6q-pinctrl.txt    | 38 --------
>>   .../bindings/pinctrl/fsl,imx6sl-pinctrl.txt   | 39 --------
>>   .../bindings/pinctrl/fsl,imx6sll-pinctrl.txt  | 40 ---------
>>   .../bindings/pinctrl/fsl,imx6sx-pinctrl.txt   | 36 --------
>>   10 files changed, 78 insertions(+), 330 deletions(-)
>>   delete mode 100644 Documentation/devicetree/bindings/pinctrl/fsl,imx35-pinctrl.txt
>>   rename Documentation/devicetree/bindings/pinctrl/{fsl,imx6ul-pinctrl.yaml => fsl,imx35-pinctrl.yaml} (50%)
>>   delete mode 100644 Documentation/devicetree/bindings/pinctrl/fsl,imx50-pinctrl.txt
>>   delete mode 100644 Documentation/devicetree/bindings/pinctrl/fsl,imx51-pinctrl.txt
>>   delete mode 100644 Documentation/devicetree/bindings/pinctrl/fsl,imx53-pinctrl.txt
>>   delete mode 100644 Documentation/devicetree/bindings/pinctrl/fsl,imx6dl-pinctrl.txt
>>   delete mode 100644 Documentation/devicetree/bindings/pinctrl/fsl,imx6q-pinctrl.txt
>>   delete mode 100644 Documentation/devicetree/bindings/pinctrl/fsl,imx6sl-pinctrl.txt
>>   delete mode 100644 Documentation/devicetree/bindings/pinctrl/fsl,imx6sll-pinctrl.txt
>>   delete mode 100644 Documentation/devicetree/bindings/pinctrl/fsl,imx6sx-pinctrl.txt
> 
> I'm not sure it makes a lot sense to have "fsl,imx6ul-pinctrl: " in the
> subject prefix.
I can change it to imx-pinctrl or something and send V4 , or can you 
tweak it while applying since the series is somewhat large ? Which do 
you prefer ?

  reply	other threads:[~2024-10-22  3:52 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-17 21:11 [PATCH v3 01/12] dt-bindings: pinctrl: fsl,imx6ul-pinctrl: Convert i.MX35/5x/6 to YAML Marek Vasut
2024-10-17 21:11 ` [PATCH v3 02/12] ARM: dts: imx35: Align pin config nodes with bindings Marek Vasut
2024-11-01  8:13   ` Shawn Guo
2024-10-17 21:11 ` [PATCH v3 03/12] ARM: dts: imx50: " Marek Vasut
2024-10-17 21:11 ` [PATCH v3 04/12] ARM: dts: imx51: " Marek Vasut
2024-10-17 21:11 ` [PATCH v3 05/12] ARM: dts: imx53: " Marek Vasut
2024-10-17 21:11 ` [PATCH v3 06/12] ARM: dts: imx6dl: " Marek Vasut
2024-10-17 21:11 ` [PATCH v3 07/12] ARM: dts: imx6q: " Marek Vasut
2024-10-17 21:11 ` [PATCH v3 08/12] ARM: dts: imx6qdl: " Marek Vasut
2024-10-17 21:11 ` [PATCH v3 09/12] ARM: dts: imx6qp: " Marek Vasut
2024-10-17 21:11 ` [PATCH v3 10/12] ARM: dts: imx6sl: imx6sll: " Marek Vasut
2024-10-17 21:11 ` [PATCH v3 11/12] ARM: dts: imx6sx: " Marek Vasut
2024-10-17 21:11 ` [PATCH v3 12/12] ARM: dts: imx6ul: Drop duplicate space in iomux node groups Marek Vasut
2024-10-22  3:25 ` [PATCH v3 01/12] dt-bindings: pinctrl: fsl,imx6ul-pinctrl: Convert i.MX35/5x/6 to YAML Shawn Guo
2024-10-22  3:52   ` Marek Vasut [this message]
2024-10-22  6:16     ` Shawn Guo
2024-10-22 11:23       ` Marek Vasut
2024-10-22 12:55 ` Linus Walleij
2024-10-22 13:56   ` Marek Vasut
2024-10-23  9:55 ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6eb23f6c-fe0c-4ee1-8f99-568041524073@denx.de \
    --to=marex@denx.de \
    --cc=aisheng.dong@nxp.com \
    --cc=alexander.stein@ew.tq-group.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=imx@lists.linux.dev \
    --cc=kernel@dh-electronics.com \
    --cc=kernel@pengutronix.de \
    --cc=krzk+dt@kernel.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=ping.bai@nxp.com \
    --cc=robh@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo2@yeah.net \
    --cc=shawnguo@kernel.org \
    --cc=wahrenst@gmx.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).