From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9546BECAAD8 for ; Tue, 20 Sep 2022 08:48:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231135AbiITIsD (ORCPT ); Tue, 20 Sep 2022 04:48:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36246 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231526AbiITIru (ORCPT ); Tue, 20 Sep 2022 04:47:50 -0400 Received: from mail-lf1-x12c.google.com (mail-lf1-x12c.google.com [IPv6:2a00:1450:4864:20::12c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7560D3F32B for ; Tue, 20 Sep 2022 01:47:42 -0700 (PDT) Received: by mail-lf1-x12c.google.com with SMTP id a3so2584413lfk.9 for ; Tue, 20 Sep 2022 01:47:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=bPC0wOWHS3IfkpyiNHTrPOKy7lllIftEAhOiSZ57lWE=; b=xx1IH7gi6vuXdqBC8gCyQHJnBpx94OKrk8RWttmSL7BTYXLGZYOAlUaOt5XuevZRnI 9mSoFEAlQNRW61/D2d1n/yX+9Dpz8Yu6GH3mETVc/M1epxE3yWY+B1QVJSFOqmmDrR7T xRXFcc8j6PJmvvPziypomGMvbLcSUw8Zw5j+9gguuGJHRlf4aLbzn6XIoIFLgN/F8c8z HJfRm3xT9jZxkfNdJxEZKyb6cZJ+UA0/c8SRFXYiowtu1Vmx4Y8RhqEbIf57ZdIwtSv/ G9u7MDQwRP+0LWtaOjq1H5EGhEDOJU0yCBXB261I5VwDV7N3/ApG/rF8WseQw7wYCd4q JIbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=bPC0wOWHS3IfkpyiNHTrPOKy7lllIftEAhOiSZ57lWE=; b=nEkROG8XIHgz7YV6vyU5W7ZeIJlhRZIpqKSimjm0tFdt86aoxaV5EmSB8HU2T1zS7S p8RtaitSVcxyqgeUHAp8tQwebV5AZehdmwRXPcrtfQw0K85FvX2GgZPs+Rm2ztTFMQS5 QJgtVjhY3HfnEjBjSRL2B/Z2UYiNj6ZTRrgDaM6cXxOGi14BmxQtSnRK0CqIOF7ablKz qHNjoB1FJDgdjSmG5w8XvGz23ZLGCA9embFy2Jrql2YZUagGPx07qyrYn1xf8OtSCKlJ kBjq5bA6Z9W9iJF8aqs6APSdzZlfU3iGXyj9lo9NBXLLz4fg55mPOBIbtBwfh1As50jM wdHw== X-Gm-Message-State: ACrzQf0DdJjlatrLB85AD4wUW0gL+7Zka4C6ELb8zK/UO7x1/aOnIL1G UXwKdr2VpGqeX4T6W+XBrGYojg== X-Google-Smtp-Source: AMsMyM5H098ZyPcH4hQiK06tnggqiLZI22yq2+Z+n6Ilu5uMR/fxGiIdZGjRfa+iAg143TZk4rwxyw== X-Received: by 2002:a05:6512:3c9f:b0:49d:d486:96d7 with SMTP id h31-20020a0565123c9f00b0049dd48696d7mr7980206lfv.596.1663663660813; Tue, 20 Sep 2022 01:47:40 -0700 (PDT) Received: from [192.168.0.21] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id q9-20020ac246e9000000b0049486c66140sm205437lfo.119.2022.09.20.01.47.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 20 Sep 2022 01:47:40 -0700 (PDT) Message-ID: <6f1ad082-74e4-e4e7-9304-5cdd95cc9f66@linaro.org> Date: Tue, 20 Sep 2022 10:47:39 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [PATCH v2 1/2] dt-binding: pinctrl: Add NPCM8XX pinctrl and GPIO documentation Content-Language: en-US To: Tomer Maimon Cc: Rob Herring , Avi Fishman , Tali Perry , Joel Stanley , Patrick Venture , Nancy Yuen , Benjamin Fair , Linus Walleij , Krzysztof Kozlowski , =?UTF-8?Q?Jonathan_Neusch=c3=a4fer?= , zhengbin13@huawei.com, OpenBMC Maillist , "open list:GPIO SUBSYSTEM" , Linux Kernel Mailing List , devicetree References: <20220714122322.63663-1-tmaimon77@gmail.com> <20220714122322.63663-2-tmaimon77@gmail.com> <20220718211046.GA3547663-robh@kernel.org> <3981e6e8-d4bb-b13d-7aaa-7aea83ffaad9@linaro.org> <2b0e6e33-ef76-4bd4-8894-53f9a3fe68b4@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On 20/09/2022 10:32, Tomer Maimon wrote: > On Tue, 20 Sept 2022 at 11:21, Krzysztof Kozlowski > wrote: >> >> On 20/09/2022 09:59, Tomer Maimon wrote: >>>>>>>>> + pinctrl: pinctrl@f0800000 { >>>>>>>>> + compatible = "nuvoton,npcm845-pinctrl"; >>>>>>>>> + ranges = <0x0 0x0 0xf0010000 0x8000>; >>>>>>>>> + #address-cells = <1>; >>>>>>>>> + #size-cells = <1>; >>>>>>>>> + nuvoton,sysgcr = <&gcr>; >>>>>>>>> + >>>>>>>>> + gpio0: gpio@f0010000 { >>>>>>>> >>>>>>>> gpio@0 >>>>>>>> >>>>>>>> Is this really a child block of the pinctrl? Doesn't really look like it >>>>>>>> based on addressess. Where are the pinctrl registers? In the sysgcr? If >>>>>>>> so, then pinctrl should be a child of it. But that doesn't really work >>>>>>>> too well with gpio child nodes... >>>>>>> the pin controller mux is handled by sysgcr this is why the sysgcr in >>>>>>> the mother node, >>>>>>> and the pin configuration are handled by the GPIO registers. each >>>>>>> GPIO bank (child) contains 32 GPIO. >>>>>>> this is why the GPIO is the child node. >>>>>> >>>>>> Then maybe pinctrl should be the sysgcr and expose regmap for other devices? >>>>> The pin controller using the sysgcr to handle the pinmux, this is why >>>>> the sysgcr is in the mother node, is it problematic? >>>> >>>> You said pin-controller mux registers are in sysgcr, so it should not be >>>> used via syscon. >>> Sorry but maybe I missed something. >>> the sysgcr is used for miscellaneous features and not only for the pin >>> controller mux, this is why it used syscon and defined in the dtsi: >>> gcr: system-controller@f0800000 { >>> compatible = "nuvoton,npcm845-gcr", "syscon"; >>> reg = <0x0 0xf0800000 0x0 0x1000>; >>> }; >>>> >>>> Please provide address map description to convince us that this is >>>> correct HW representation. >>> GCR (sysgcr) registers 0xf0800000-0xf0801000 - used for miscellaneous >>> features, not only pin mux. >>> GPIO0 0xf0010000-0xf0011000 >>> GPIO1 0xf0011000-0xf0012000 >>> ... >>> GPIO7 0xf0017000-0xf0018000 >>>> >> >> Then why your pinctrl is in sysgcr IO range? (pinctrl@f0800000) > you suggest using pinctrl@0 or pinctrl@f0010000 and not > pinctrl@f0800000 because 0xf0800000 is the GCR address that serve > miscellaneous features and not only pinmux controller ? If you have a map like you pasted, then DTS like this: syscon@f0800000 {} pinctrl@f0800000 { gpio@f0010000 {} } Is quite weird, don't you think? You have two devices on the same unit address which is not allowed. You have child of pinctrl with entirely different unit address, so how is it its child? Best regards, Krzysztof