From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DAA2AC433E0 for ; Thu, 2 Jul 2020 12:18:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A191320772 for ; Thu, 2 Jul 2020 12:18:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gorani.run header.i=@gorani.run header.b="myuci/fR" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728949AbgGBMSh (ORCPT ); Thu, 2 Jul 2020 08:18:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55030 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728719AbgGBMSg (ORCPT ); Thu, 2 Jul 2020 08:18:36 -0400 Received: from mout-p-103.mailbox.org (mout-p-103.mailbox.org [IPv6:2001:67c:2050::465:103]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CD1C6C08C5C1; Thu, 2 Jul 2020 05:18:36 -0700 (PDT) Received: from smtp1.mailbox.org (smtp1.mailbox.org [80.241.60.240]) (using TLSv1.2 with cipher ECDHE-RSA-CHACHA20-POLY1305 (256/256 bits)) (No client certificate requested) by mout-p-103.mailbox.org (Postfix) with ESMTPS id 49yHF72b7SzKmV1; Thu, 2 Jul 2020 14:18:35 +0200 (CEST) X-Virus-Scanned: amavisd-new at heinlein-support.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gorani.run; s=MBO0001; t=1593692313; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8PdW4mY0M10JbXsnQKZPQGWOov3L8734sg9udOp2odM=; b=myuci/fRw15/QzDb3nTia6hCdEO/4qQDCzXXK8x0k4uR/xxZcky8rf249YE93rqV+l4UNS mp/jqH72t546XWpFyJRasU2fVyJHP6kYW/4tkXdpTtt9gWPXXin25lv+IFPTsgIuKklrO/ /2Gl2+doiqmOEgkuZxHWIYRPuY7rEAC2e4rxQ3DUkGIZCCZaNyon3lvkodXNXQqIvTeAz4 NahrXayIWFOyVLQtaFjoUYPes/tLihjK1xNSlorsR7gvMPE+/jRXdtZySe+q6QsRhwx5zS g8bkvbSx0cz8O+1IBpA3UMWLfrsYU+r4g3Ndgp+czbfR+fjMFJitU7BlBtzy4A== Received: from smtp1.mailbox.org ([80.241.60.240]) by spamfilter03.heinlein-hosting.de (spamfilter03.heinlein-hosting.de [80.241.56.117]) (amavisd-new, port 10030) with ESMTP id K4S0sSUXSksq; Thu, 2 Jul 2020 14:18:32 +0200 (CEST) Subject: Re: [PATCH v3 1/2] gpio: add GPO driver for PCA9570 To: Andy Shevchenko Cc: Linus Walleij , Bartosz Golaszewski , Michael Walle , Linux Kernel Mailing List , "open list:GPIO SUBSYSTEM" References: <20200630160736.1196697-1-mans0n@gorani.run> From: Sungbo Eo Message-ID: <70c39afa-ee69-f867-61ae-a7e3a5c149d6@gorani.run> Date: Thu, 2 Jul 2020 21:18:24 +0900 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-MBO-SPAM-Probability: 0 X-Rspamd-Score: -2.70 / 15.00 / 15.00 X-Rspamd-Queue-Id: 32C4F1807 X-Rspamd-UID: 0a1fcb Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On 2020-07-01 06:30, Andy Shevchenko wrote: > On Tue, Jun 30, 2020 at 7:08 PM Sungbo Eo wrote: >> >> NXP PCA9570 is 4-bit I2C GPO expander without interrupt functionality. >> Its ports are controlled only by a data byte without register address. >> >> As there is no other driver similar enough to be adapted for it, a new >> driver is introduced here. >> > > It looks good, but I would add ->get() to return buffered value. > Thanks, your suggestion was indeed valuable. I reworked the driver, please have a look.