From: "TY_Chang[張子逸]" <tychang@realtek.com>
To: Michael Walle <michael@walle.cc>
Cc: Andy Shevchenko <andy@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v3 2/2] Add GPIO support for Realtek DHC(Digital Home Center) RTD SoCs.
Date: Wed, 20 Dec 2023 07:13:25 +0000 [thread overview]
Message-ID: <70fbe20aaf334d758d87974b4acdb3fc@realtek.com> (raw)
In-Reply-To: <202312181420.3BIEK9gtC1692907@rtits1.realtek.com.tw>
Hi Michael,
>Hi,
>
>> I have looked into regmap-irq, it appears that using the default irq
>> thread_fn(regmap_irq_thread) is required. However, due to hardware
>> limitation, we need to inspect the IRQ_TYPE to determine whether to
>> manage the irq within the irq handler. I think our irq portion does
>> not perfectly fit the regmap-irq.
>> Moreover, it seems that the gpio-regmap.c file needs to be modified if
>> the GPIO driver requires debounce settings. I think the gpio-regmap
>> may not be appropriate for our driver.
>> Do you have any suggestions?
>
>Can't say anything regarding the interrupt handling but adding literally one line
>to gpio-regmap shouldn't be a reason not to use it.
>
I agree that this should not be the reason. Sorry about that.
However, the interrupt handler issue may still be the limitation for our platform.
Thanks,
Tzuyi Chang
next prev parent reply other threads:[~2023-12-20 7:13 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-07 10:07 [PATCH v3 0/2] Add gpio driver support for Realtek DHC SoCs TY Chang
2023-12-07 10:07 ` [PATCH v3 1/2] dt-bindings: gpio: realtek: Add realtek,rtd-gpio TY Chang
2023-12-07 13:54 ` Krzysztof Kozlowski
2023-12-08 9:03 ` TY_Chang[張子逸]
2023-12-08 12:19 ` Krzysztof Kozlowski
2023-12-07 10:07 ` [PATCH v3 2/2] Add GPIO support for Realtek DHC(Digital Home Center) RTD SoCs TY Chang
2023-12-07 13:45 ` Andy Shevchenko
2023-12-12 9:55 ` TY_Chang[張子逸]
2023-12-13 13:40 ` Andy Shevchenko
2023-12-14 7:57 ` TY_Chang[張子逸]
2023-12-14 13:58 ` Andy Shevchenko
2023-12-14 14:35 ` Michael Walle
2023-12-14 14:49 ` Andy Shevchenko
2023-12-15 6:50 ` TY_Chang[張子逸]
2023-12-18 8:50 ` Michael Walle
[not found] ` <202312181420.3BIEK9gtC1692907@rtits1.realtek.com.tw>
2023-12-20 7:13 ` TY_Chang[張子逸] [this message]
2023-12-15 3:29 ` TY_Chang[張子逸]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=70fbe20aaf334d758d87974b4acdb3fc@realtek.com \
--to=tychang@realtek.com \
--cc=andy@kernel.org \
--cc=brgl@bgdev.pl \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael@walle.cc \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).