From: Clement LE GOFFIC <clement.legoffic@foss.st.com>
To: Krzysztof Kozlowski <krzk@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Bartosz Golaszewski <brgl@bgdev.pl>
Cc: <linux-kernel@vger.kernel.org>, <linux-gpio@vger.kernel.org>,
<devicetree@vger.kernel.org>,
<linux-stm32@st-md-mailman.stormreply.com>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v3 5/9] ARM: dts: stm32: add Hardware debug port (HDP) on stm32mp13
Date: Tue, 10 Jun 2025 14:02:34 +0200 [thread overview]
Message-ID: <714ad17d-53f1-4703-8e13-61c290a8da89@foss.st.com> (raw)
In-Reply-To: <3ba588ed-1614-4877-b6fc-b5aa853b8c2e@kernel.org>
On 5/29/25 11:01, Krzysztof Kozlowski wrote:
> On 28/05/2025 14:14, Clement LE GOFFIC wrote:
>>>
>>>> + };
>>>> +
>>>> + hdp: pinctrl@5002a000 {
>>>> + compatible = "st,stm32mp131-hdp";
>>>> + reg = <0x5002a000 0x400>;
>>>> + clocks = <&rcc HDP>;
>>>> status = "disabled";
>>>
>>> Why are you disabling it? What is missing?
>>
>> Nothing is missing just disabled by default.
>> The node is then enabled when needed in board's dts file.
> Nodes should not be disabled by default if they are complete. That's why
> I asked what is missing. Drop.
Hi Krzysztof, OK I better understand now.
So yes the 'pinctrl-*' properties which are board dependent are lacking.
In the last patch of my serie I add them (only for stm32mp157f-dk2) but
keep it disabled because the pin is on an external connector (the
Arduino connector of the board).
This prevent any issue with a possible connected module.
> Best regards,
> Krzysztof
next prev parent reply other threads:[~2025-06-10 12:04 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-23 12:38 [PATCH v3 0/9] Introduce HDP support for STM32MP platforms Clément Le Goffic
2025-05-23 12:38 ` [PATCH v3 1/9] gpio: mmio: add BGPIOF_NO_INPUT flag for GPO gpiochip Clément Le Goffic
2025-06-05 12:58 ` Linus Walleij
2025-05-23 12:38 ` [PATCH v3 2/9] dt-bindings: pinctrl: stm32: Introduce HDP Clément Le Goffic
2025-05-28 8:21 ` Krzysztof Kozlowski
2025-05-23 12:38 ` [PATCH v3 3/9] pinctrl: stm32: Introduce HDP driver Clément Le Goffic
2025-05-28 8:28 ` Krzysztof Kozlowski
2025-05-28 11:43 ` Clement LE GOFFIC
2025-05-23 12:38 ` [PATCH v3 4/9] MAINTAINERS: Add Clément Le Goffic as STM32 HDP maintainer Clément Le Goffic
2025-05-23 12:38 ` [PATCH v3 5/9] ARM: dts: stm32: add Hardware debug port (HDP) on stm32mp13 Clément Le Goffic
2025-05-28 8:55 ` Krzysztof Kozlowski
2025-05-28 12:14 ` Clement LE GOFFIC
2025-05-29 9:01 ` Krzysztof Kozlowski
2025-06-10 12:02 ` Clement LE GOFFIC [this message]
2025-06-10 12:38 ` Krzysztof Kozlowski
2025-06-10 13:33 ` Clement LE GOFFIC
2025-06-11 6:35 ` Krzysztof Kozlowski
2025-06-11 14:08 ` Clement LE GOFFIC
2025-06-11 15:48 ` Krzysztof Kozlowski
2025-06-12 9:31 ` Clement LE GOFFIC
2025-06-12 11:05 ` Krzysztof Kozlowski
2025-06-12 13:02 ` Clement LE GOFFIC
2025-06-12 13:09 ` Krzysztof Kozlowski
2025-06-12 13:21 ` Clement LE GOFFIC
2025-06-12 13:28 ` [Linux-stm32] " Clement LE GOFFIC
2025-05-29 9:15 ` Krzysztof Kozlowski
2025-05-23 12:38 ` [PATCH v3 6/9] ARM: dts: stm32: add Hardware debug port (HDP) on stm32mp15 Clément Le Goffic
2025-05-28 9:00 ` Krzysztof Kozlowski
2025-05-28 12:15 ` Clement LE GOFFIC
2025-05-29 9:01 ` Krzysztof Kozlowski
2025-05-23 12:38 ` [PATCH v3 7/9] ARM: dts: stm32: add Hardware debug port (HDP) on stm32mp25 Clément Le Goffic
2025-05-23 12:38 ` [PATCH v3 8/9] ARM: dts: stm32: add alternate pinmux for HDP pin and add HDP pinctrl node Clément Le Goffic
2025-06-05 12:57 ` Linus Walleij
2025-06-10 12:07 ` Clement LE GOFFIC
2025-05-23 12:38 ` [PATCH v3 9/9] ARM: dts: stm32: add Hardware debug port (HDP) on stm32mp157c-dk2 board Clément Le Goffic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=714ad17d-53f1-4703-8e13-61c290a8da89@foss.st.com \
--to=clement.legoffic@foss.st.com \
--cc=alexandre.torgue@foss.st.com \
--cc=brgl@bgdev.pl \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).