[PATCH 0/4] Add support for pinctrl in pmic chips.

[PATCH 0/4] Add support for pinctrl in pmic chips.

[Rohit Agarwal]

Hi,

This series adds GPIO support for PM7550ba and PMX75 pmic.

Thanks,
Rohit.

Rohit Agarwal (4):
  dt-bindings: pinctrl: qcom-pmic-gpio: Add pm7550ba support
  dt-bindings: pinctrl: qcom-pmic-gpio: Add pmx75 support
  pinctrl: qcom-pmic-gpio: Add support for pm7550ba
  pinctrl: qcom-pmic-gpio: Add support for pmx75

 Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml | 6 ++++++
 drivers/pinctrl/qcom/pinctrl-spmi-gpio.c                      | 2 ++
 2 files changed, 8 insertions(+)

-- 
2.7.4

[PATCH 1/4] dt-bindings: pinctrl: qcom-pmic-gpio: Add pm7550ba support

[Rohit Agarwal]

Add support for the pm7550ba GPIO support to the Qualcomm PMIC GPIO
binding.

Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com>
---
 Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml
index 8aaf501..3585031 100644
--- a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml
@@ -26,6 +26,7 @@ properties:
           - qcom,pm6350-gpio
           - qcom,pm7250b-gpio
           - qcom,pm7325-gpio
+          - qcom,pm7550ba-gpio
           - qcom,pm8005-gpio
           - qcom,pm8008-gpio
           - qcom,pm8018-gpio
@@ -172,6 +173,7 @@ allOf:
         compatible:
           contains:
             enum:
+              - qcom,pm7550ba-gpio
               - qcom,pm8226-gpio
               - qcom,pm8350b-gpio
               - qcom,pm8550ve-gpio
@@ -413,6 +415,7 @@ $defs:
                  - gpio1-gpio9 for pm6350
                  - gpio1-gpio12 for pm7250b
                  - gpio1-gpio10 for pm7325
+                 - gpio1-gpio8 for pm7550ba
                  - gpio1-gpio4 for pm8005
                  - gpio1-gpio2 for pm8008
                  - gpio1-gpio6 for pm8018
-- 
2.7.4

Re: [PATCH 1/4] dt-bindings: pinctrl: qcom-pmic-gpio: Add pm7550ba support

[Krzysztof Kozlowski]

On 06/07/2023 15:30, Rohit Agarwal wrote:
> Add support for the pm7550ba GPIO support to the Qualcomm PMIC GPIO
> binding.
> 
> Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com>
> ---
>  Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml | 3 +++

I doubt that all your patches here and other patchsets are v1. Otherwise
how did you get my Acks and Rbs? Please use proper versioning and
provide changelog.

What changed here?

Best regards,
Krzysztof

Re: [PATCH 1/4] dt-bindings: pinctrl: qcom-pmic-gpio: Add pm7550ba support

[Rohit Agarwal]

On 7/6/2023 8:05 PM, Krzysztof Kozlowski wrote:
> On 06/07/2023 15:30, Rohit Agarwal wrote:
>> Add support for the pm7550ba GPIO support to the Qualcomm PMIC GPIO
>> binding.
>>
>> Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com>
>> ---
>>   Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml | 3 +++
> I doubt that all your patches here and other patchsets are v1. Otherwise
> how did you get my Acks and Rbs? Please use proper versioning and
> provide changelog.
>
> What changed here?

Actually this is part of the original bigger series [1] that as per 
Bjorn's suggestion need to be broken
down according to the subsystem/maintainer.
Since it got broken down into multiple smaller series, I didnt include 
the versioning.

[1] 
https://lore.kernel.org/all/9de424ca-271a-8ed2-5550-658a828c4ea5@quicinc.com/

>
> Best regards,
> Krzysztof
>

Re: [PATCH 1/4] dt-bindings: pinctrl: qcom-pmic-gpio: Add pm7550ba support

[Konrad Dybcio]

On 6.07.2023 16:45, Rohit Agarwal wrote:
> 
> On 7/6/2023 8:05 PM, Krzysztof Kozlowski wrote:
>> On 06/07/2023 15:30, Rohit Agarwal wrote:
>>> Add support for the pm7550ba GPIO support to the Qualcomm PMIC GPIO
>>> binding.
>>>
>>> Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com>
>>> ---
>>>   Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml | 3 +++
>> I doubt that all your patches here and other patchsets are v1. Otherwise
>> how did you get my Acks and Rbs? Please use proper versioning and
>> provide changelog.
>>
>> What changed here?
> 
> Actually this is part of the original bigger series [1] that as per Bjorn's suggestion need to be broken
> down according to the subsystem/maintainer.
> Since it got broken down into multiple smaller series, I didnt include the versioning.
All of that information should be included in the cover letter, to
limit confusion both for maintainers and patch workflow tools.

Since these patches all come from a separate series, it would be
good for you to version this one as v(BIG_SERIES_REVISION)+1 because
they've already been on LKML at least once. That would especially hold
true if this revision included any changes.

Konrad
> 
> [1] https://lore.kernel.org/all/9de424ca-271a-8ed2-5550-658a828c4ea5@quicinc.com/
> 
>>
>> Best regards,
>> Krzysztof
>>

Re: [PATCH 1/4] dt-bindings: pinctrl: qcom-pmic-gpio: Add pm7550ba support

[Rohit Agarwal]

On 7/6/2023 8:34 PM, Konrad Dybcio wrote:
> On 6.07.2023 16:45, Rohit Agarwal wrote:
>> On 7/6/2023 8:05 PM, Krzysztof Kozlowski wrote:
>>> On 06/07/2023 15:30, Rohit Agarwal wrote:
>>>> Add support for the pm7550ba GPIO support to the Qualcomm PMIC GPIO
>>>> binding.
>>>>
>>>> Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com>
>>>> ---
>>>>    Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml | 3 +++
>>> I doubt that all your patches here and other patchsets are v1. Otherwise
>>> how did you get my Acks and Rbs? Please use proper versioning and
>>> provide changelog.
>>>
>>> What changed here?
>> Actually this is part of the original bigger series [1] that as per Bjorn's suggestion need to be broken
>> down according to the subsystem/maintainer.
>> Since it got broken down into multiple smaller series, I didnt include the versioning.
> All of that information should be included in the cover letter, to
> limit confusion both for maintainers and patch workflow tools.
>
> Since these patches all come from a separate series, it would be
> good for you to version this one as v(BIG_SERIES_REVISION)+1 because
> they've already been on LKML at least once. That would especially hold
> true if this revision included any changes.
Understood. Will send all the smaller series again with v2 as version 
with changelog.

Thanks,
Rohit.
> Konrad
>> [1] https://lore.kernel.org/all/9de424ca-271a-8ed2-5550-658a828c4ea5@quicinc.com/
>>
>>> Best regards,
>>> Krzysztof
>>>

Re: [PATCH 1/4] dt-bindings: pinctrl: qcom-pmic-gpio: Add pm7550ba support

[Konrad Dybcio]

On 6.07.2023 17:11, Rohit Agarwal wrote:
> 
> On 7/6/2023 8:34 PM, Konrad Dybcio wrote:
>> On 6.07.2023 16:45, Rohit Agarwal wrote:
>>> On 7/6/2023 8:05 PM, Krzysztof Kozlowski wrote:
>>>> On 06/07/2023 15:30, Rohit Agarwal wrote:
>>>>> Add support for the pm7550ba GPIO support to the Qualcomm PMIC GPIO
>>>>> binding.
>>>>>
>>>>> Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com>
>>>>> ---
>>>>>    Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml | 3 +++
>>>> I doubt that all your patches here and other patchsets are v1. Otherwise
>>>> how did you get my Acks and Rbs? Please use proper versioning and
>>>> provide changelog.
>>>>
>>>> What changed here?
>>> Actually this is part of the original bigger series [1] that as per Bjorn's suggestion need to be broken
>>> down according to the subsystem/maintainer.
>>> Since it got broken down into multiple smaller series, I didnt include the versioning.
>> All of that information should be included in the cover letter, to
>> limit confusion both for maintainers and patch workflow tools.
>>
>> Since these patches all come from a separate series, it would be
>> good for you to version this one as v(BIG_SERIES_REVISION)+1 because
>> they've already been on LKML at least once. That would especially hold
>> true if this revision included any changes.
> Understood. Will send all the smaller series again with v2 as version with changelog.
v3, this was essentially a v2.

Konrad
> 
> Thanks,
> Rohit.
>> Konrad
>>> [1] https://lore.kernel.org/all/9de424ca-271a-8ed2-5550-658a828c4ea5@quicinc.com/
>>>
>>>> Best regards,
>>>> Krzysztof
>>>>

Re: [PATCH 1/4] dt-bindings: pinctrl: qcom-pmic-gpio: Add pm7550ba support

[Rohit Agarwal]

On 7/6/2023 8:53 PM, Konrad Dybcio wrote:
> On 6.07.2023 17:11, Rohit Agarwal wrote:
>> On 7/6/2023 8:34 PM, Konrad Dybcio wrote:
>>> On 6.07.2023 16:45, Rohit Agarwal wrote:
>>>> On 7/6/2023 8:05 PM, Krzysztof Kozlowski wrote:
>>>>> On 06/07/2023 15:30, Rohit Agarwal wrote:
>>>>>> Add support for the pm7550ba GPIO support to the Qualcomm PMIC GPIO
>>>>>> binding.
>>>>>>
>>>>>> Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com>
>>>>>> ---
>>>>>>     Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml | 3 +++
>>>>> I doubt that all your patches here and other patchsets are v1. Otherwise
>>>>> how did you get my Acks and Rbs? Please use proper versioning and
>>>>> provide changelog.
>>>>>
>>>>> What changed here?
>>>> Actually this is part of the original bigger series [1] that as per Bjorn's suggestion need to be broken
>>>> down according to the subsystem/maintainer.
>>>> Since it got broken down into multiple smaller series, I didnt include the versioning.
>>> All of that information should be included in the cover letter, to
>>> limit confusion both for maintainers and patch workflow tools.
>>>
>>> Since these patches all come from a separate series, it would be
>>> good for you to version this one as v(BIG_SERIES_REVISION)+1 because
>>> they've already been on LKML at least once. That would especially hold
>>> true if this revision included any changes.
>> Understood. Will send all the smaller series again with v2 as version with changelog.
> v3, this was essentially a v2.
Okay.

Thanks,
Rohit.
>
> Konrad
>> Thanks,
>> Rohit.
>>> Konrad
>>>> [1] https://lore.kernel.org/all/9de424ca-271a-8ed2-5550-658a828c4ea5@quicinc.com/
>>>>
>>>>> Best regards,
>>>>> Krzysztof
>>>>>

[PATCH 2/4] dt-bindings: pinctrl: qcom-pmic-gpio: Add pmx75 support

[Rohit Agarwal]

Add support for the pmx75 GPIO support to the Qualcomm PMIC GPIO
binding.

Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml
index 3585031..52b3d78 100644
--- a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml
@@ -69,6 +69,7 @@ properties:
           - qcom,pms405-gpio
           - qcom,pmx55-gpio
           - qcom,pmx65-gpio
+          - qcom,pmx75-gpio
 
       - enum:
           - qcom,spmi-gpio
@@ -303,6 +304,7 @@ allOf:
           contains:
             enum:
               - qcom,pmx65-gpio
+              - qcom,pmx75-gpio
     then:
       properties:
         gpio-line-names:
@@ -459,6 +461,7 @@ $defs:
                  - gpio1-gpio11 for pmx55 (holes on gpio3, gpio7, gpio10
                                             and gpio11)
                  - gpio1-gpio16 for pmx65
+                 - gpio1-gpio16 for pmx75
 
         items:
           pattern: "^gpio([0-9]+)$"
-- 
2.7.4

[PATCH 3/4] pinctrl: qcom-pmic-gpio: Add support for pm7550ba

[Rohit Agarwal]

pm7550ba pmic support gpio controller so add compatible in the driver.

Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com>
---
 drivers/pinctrl/qcom/pinctrl-spmi-gpio.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
index b4cd668..f1918fe 100644
--- a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
+++ b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
@@ -1205,6 +1205,7 @@ static const struct of_device_id pmic_gpio_of_match[] = {
 	{ .compatible = "qcom,pm6350-gpio", .data = (void *) 9 },
 	{ .compatible = "qcom,pm7250b-gpio", .data = (void *) 12 },
 	{ .compatible = "qcom,pm7325-gpio", .data = (void *) 10 },
+	{ .compatible = "qcom,pm7550ba-gpio", .data = (void *) 8},
 	{ .compatible = "qcom,pm8005-gpio", .data = (void *) 4 },
 	{ .compatible = "qcom,pm8008-gpio", .data = (void *) 2 },
 	{ .compatible = "qcom,pm8019-gpio", .data = (void *) 6 },
-- 
2.7.4

[PATCH 4/4] pinctrl: qcom-pmic-gpio: Add support for pmx75

[Rohit Agarwal]

pmx75 pmic support gpio controller so add compatible in the driver.

Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com>
---
 drivers/pinctrl/qcom/pinctrl-spmi-gpio.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
index f1918fe..deded9c 100644
--- a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
+++ b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
@@ -1253,6 +1253,7 @@ static const struct of_device_id pmic_gpio_of_match[] = {
 	/* pmx55 has 11 GPIOs with holes on 3, 7, 10, 11 */
 	{ .compatible = "qcom,pmx55-gpio", .data = (void *) 11 },
 	{ .compatible = "qcom,pmx65-gpio", .data = (void *) 16 },
+	{ .compatible = "qcom,pmx75-gpio", .data = (void *) 16 },
 	{ },
 };
 
-- 
2.7.4

Re: [PATCH 0/4] Add support for pinctrl in pmic chips.

[Konrad Dybcio]

On 6.07.2023 15:30, Rohit Agarwal wrote:
> Hi,
The subject should definitely specify which PMIC chips (or what platform)
the changes are for, otherwise it's overly generic, so for example:

Add pinctrl support for SDX75 PMICs


It's not a big issue, but it helps when one needs to search through email
history for a specific thread.

Konrad
> 
> This series adds GPIO support for PM7550ba and PMX75 pmic.
> 
> Thanks,
> Rohit.
> 
> Rohit Agarwal (4):
>   dt-bindings: pinctrl: qcom-pmic-gpio: Add pm7550ba support
>   dt-bindings: pinctrl: qcom-pmic-gpio: Add pmx75 support
>   pinctrl: qcom-pmic-gpio: Add support for pm7550ba
>   pinctrl: qcom-pmic-gpio: Add support for pmx75
> 
>  Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml | 6 ++++++
>  drivers/pinctrl/qcom/pinctrl-spmi-gpio.c                      | 2 ++
>  2 files changed, 8 insertions(+)
> 

Re: [PATCH 0/4] Add support for pinctrl in pmic chips.

[Rohit Agarwal]

On 7/6/2023 8:32 PM, Konrad Dybcio wrote:
> On 6.07.2023 15:30, Rohit Agarwal wrote:
>> Hi,
> The subject should definitely specify which PMIC chips (or what platform)
> the changes are for, otherwise it's overly generic, so for example:
>
> Add pinctrl support for SDX75 PMICs
>
>
> It's not a big issue, but it helps when one needs to search through email
> history for a specific thread.
Understood will update in the next version.

Thanks,
Rohit.
>
> Konrad
>> This series adds GPIO support for PM7550ba and PMX75 pmic.
>>
>> Thanks,
>> Rohit.
>>
>> Rohit Agarwal (4):
>>    dt-bindings: pinctrl: qcom-pmic-gpio: Add pm7550ba support
>>    dt-bindings: pinctrl: qcom-pmic-gpio: Add pmx75 support
>>    pinctrl: qcom-pmic-gpio: Add support for pm7550ba
>>    pinctrl: qcom-pmic-gpio: Add support for pmx75
>>
>>   Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml | 6 ++++++
>>   drivers/pinctrl/qcom/pinctrl-spmi-gpio.c                      | 2 ++
>>   2 files changed, 8 insertions(+)
>>