From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C936B368D79 for ; Thu, 11 Jun 2026 11:05:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781175933; cv=none; b=Nf2YKJU9EPv4VaXKWw6n7unPRF5ilA9aaoanSVP8/CUCsDnNX1SdDyuZcGGmRyqIJGVxM4NeHEUVmwVCjRxZl6wvjgtAbMk/jepmsWGeUoUfC5bZ8xTBfcULKoAMKI/IecipT7SDesYkHKe5YWmxloHYmdl8Z+fQ7kmztMBJwno= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781175933; c=relaxed/simple; bh=/wxQSaRakumNKYB4vqjOTBgyQzqMLc8DAYpMLHYYAXA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=pGVUXkfmCJWwfFXNr8ZaUsT2l0OwFFfskNEvh/UQhIRvxHu30bGVtOPqgw+U17n9Br+EX6XX9SPj+U6vVsc8JnaXw7LaPLV7J1sWlgW+OhrCcJa4YrBxbY267z2UYHakKhPWf6/w9EhqRj8cV8LFFKOI+Es41YJrp3fb6BzT9As= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=I2xWBKdv; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=FFavymKI; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="I2xWBKdv"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="FFavymKI" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65B9xJjs2890193 for ; Thu, 11 Jun 2026 11:05:32 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= MaD+SVyMDIg2d/edNc/15/ePklSjOmExxWuDVzVekf4=; b=I2xWBKdvhWa3HVSh QJ+IsVIexhJqMUy6ElBfAfFWdp5vQS6zDAdb3s4+Ud8avq+JzY8O82W9FJRW540n wZoMLSObdhjjI70P2oXAaSOzmoMiXI1PcIodMEIWmbRRGv/V9fmPGtKGEzj7/SgH lfAO37K6fhVHofZ02qqIjv51qiaCx0Ex9rO95EFp87SYQDR1Zzr3sMl9JZYM5WdP 5bvYjISYlxNGSnvggUKGLw4PPNgLNyFknKDLP9NiAPWMdCDDeGteGa05jUx0p9bl OE0itsiGObG3+PJlmSsZeTRgYRRFQnEmY2CPM3dlNFY3UdtY+/bOW98xzpv4gM/Z DNY4zg== Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4eqe79k1c6-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 11 Jun 2026 11:05:32 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-51759082206so23295481cf.3 for ; Thu, 11 Jun 2026 04:05:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1781175931; x=1781780731; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=MaD+SVyMDIg2d/edNc/15/ePklSjOmExxWuDVzVekf4=; b=FFavymKIHYJJwHUugIKrhSGRBc3MhFprYBZw6k2R3A+Ie1UtCG1nNgHJttQqmWKKPb EaBLaQsD8HOieM1VsI7XoJx3qn9F6zk7wzr5wZSWZsl4yIgM1T+1oNiPJDYY7McLmzOB MJrK3vmdeYRM+jmcRw1mKdphVEqyfNBWj6NF/brR4nnItcmc1Jml7d95x+x11GydSS3w 8GZAX5QS/OFXpej36PfiUb1RkPCB22+zwizBnkr8KUMb0mgzBB96RhQitxkiWyRVXkN0 I5tvVdLXRA0gW4QRpVdWsnP1QgmLO/tyQmzVGW1NWQ1H1ZI+bZY6JENvFkKa2oHbgUqq S4fg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781175931; x=1781780731; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=MaD+SVyMDIg2d/edNc/15/ePklSjOmExxWuDVzVekf4=; b=pnSHCbSmgCg0W3jtLPR/S/RrRr4BCMZddC9fG3H1y4aebuswk+Fv8Zu50qbj+GNl80 jL3IkYxqLTLeh1in8UlL2PndXpE6N79uCrkCCZeJfSXp7B7DY2my1JJQ1jSV4DyBRZlO LzcMLAZ27CET5KWaqoKpVDEDpf+mrA7ridynGrC/owhldld26R2sn0+LzaaEVjoO4swG SYEgb5l9eimHMVam6Lw/b7BjTcxgqx/DcBZHOWRRiixamhZDsYyCj1U3ArdSL4l4wQGf acEG2CSQ7hkvmeE55Z8CgQ6u2lIYvCfvkQyWOI4Ce06pIEZhVw49F60jN7m5hfX8Fbjk imSw== X-Forwarded-Encrypted: i=1; AFNElJ8+ioLpyZ2D8skwQ2Chyi1EiALdsjgt9Gx4y8+WsQAvBbegYuW76blCnyjXG+r1FxeDz7o2PALglGn0@vger.kernel.org X-Gm-Message-State: AOJu0Yy723Pgd9uyH05EQoc2/nYFVDuVsROuoPyeF+MMGaf4CUD6FHTh wkVDUyN/1oUNBhwAFgV6VZx6FlAf66shXosLkLA+vXXOmooxx/ZFk5aDHorCJ5Q5xrHP+c20xC/ K9V10lFB8Z+dljebGmS0CRw/EmyD21NjAyb8O55MdRui6j6btTEzD0x+IZCcDGA4V X-Gm-Gg: Acq92OGx3+WzBbKBG4s1LXkvxVVhpiI3JSJ46YWjuU7rMIMTdFSf6ZPOZ2aVNU5MmSG CKDAo8u5hTLN3gh6KnwC7+ODY10aCGJ89pGnkegWqvxu2I+ZEPFGfALRGcr3rwXtPwpohvkG83e 9hzJJrqD7cWiTVpNdHStq0oeYlRfZEGrHcqS5T2DnyQBTlSprRWGmBXnLxtkQUanrntaAgu1Dux vOWKUSmr1qpS+mFM934BVehBwHoXalwgOtTqpWCK9Bv/SXbjBJM8hyqJBMGM30gaQ4OB9JQd+ov n0aCtAHWiuktdmTBsB4eXX3W5KTPIqjllPjelBVXpi0BK+ybgdQF7Mn4R0u9Bv3ZJRl2qidDwDE zWkY3ieio3gFjww0mEorvmIeFCrpAD9BMFybW4AKOJAqPu8OS93MUMV8E X-Received: by 2002:a05:620a:1713:b0:902:daaf:22cd with SMTP id af79cd13be357-9160a4f660cmr192689785a.0.1781175931062; Thu, 11 Jun 2026 04:05:31 -0700 (PDT) X-Received: by 2002:a05:620a:1713:b0:902:daaf:22cd with SMTP id af79cd13be357-9160a4f660cmr192684285a.0.1781175930499; Thu, 11 Jun 2026 04:05:30 -0700 (PDT) Received: from [192.168.120.170] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-68e65867e7dsm10880036a12.20.2026.06.11.04.05.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 11 Jun 2026 04:05:29 -0700 (PDT) Message-ID: <73f700f2-7cba-4832-bd06-e82a7fd51a7a@oss.qualcomm.com> Date: Thu, 11 Jun 2026 13:05:26 +0200 Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 5/8] irqchip/qcom-pdc: Configure PDC to pass through mode To: Maulik Shah , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Thomas Gleixner , Linus Walleij Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-gpio@vger.kernel.org, Sneh Mankad References: <20260526-hamoa_pdc-v2-0-f6857af1ce91@oss.qualcomm.com> <20260526-hamoa_pdc-v2-5-f6857af1ce91@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260526-hamoa_pdc-v2-5-f6857af1ce91@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: QdShkc4L7gtB461QVVpM0hyOGnY9Saa2 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjExMDExMSBTYWx0ZWRfX+GBaIDXkfoq0 7OHtddJ0NknYmX2VF6GoISMBlOV7Yx7ghkhf0mwX6qTXIkuPhOObTEo3geDJw/U/5gZXqhHO76F s0c/oB862ULs/RyUqRWgJ8McjX7D3XtqWpkcKbLETj5N92dqsGl07W4yyemuZYgRfo84vX0it7F AbaShOfQ3tukL0kywSlifvOLMfRugGzYu7tr0YQab3bhWxT+PBBiysPXenTxzNwn+fv21j/UKEg 0vL44dWTs9S6SpSnaoXB26VoNOmiBdMFrDG6NFscDJ2/NINdGtusR9ntJirO+XqV+lQ594sXeBw E1dBc4ICH1LzQtLeOAKan2HR1PRWIGPgDgookoPEJIH6/d1TM6dkupFmwOLd2dFaLMoB9MtgBan 3XZt7kGIQTPkhYygUWFw46+SgcTT6yr4ND7+V5MtVbsZxeekhy9CO49f4UoGdvdSMGiGrA/MTcc mm9kbzN50/SIYbM/VpA== X-Proofpoint-GUID: QdShkc4L7gtB461QVVpM0hyOGnY9Saa2 X-Authority-Analysis: v=2.4 cv=fbydDUQF c=1 sm=1 tr=0 ts=6a2a967c cx=c_pps a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=EUspDBNiAAAA:8 a=avOr_zNKPfybmo9zg3EA:9 a=QEXdDO2ut3YA:10 a=a_PwQJl-kcHnX1M80qC6:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwNjExMDExMSBTYWx0ZWRfX8z0rVRtQ0keT mYQWE+gO1RfihxRXD5BjJ87u3AB+JEGZPGfpacSou8Ab2zUESB+9MwqWZe0Gz8Agp0bSIOQfIVf Uu+k2eu1GptsC2LFN0/DuwuvNUBiAGk= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-11_02,2026-06-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 bulkscore=0 suspectscore=0 spamscore=0 adultscore=0 priorityscore=1501 lowpriorityscore=0 clxscore=1015 malwarescore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606040000 definitions=main-2606110111 On 5/26/26 12:54 PM, Maulik Shah wrote: > All PDC irqchip supports pass through mode in which both Direct SPIs and > GPIO IRQs (as SPIs) are sent to GIC without latching at PDC. > > Newer PDCs (v3.0 onwards) also support additional secondary controller mode > where PDC latches GPIO IRQs and sends to GIC as level type IRQ. Direct SPIs > still works same as pass through mode without latching at PDC even in > secondary controller mode. > > All the SoCs so far default uses pass through mode with the exception of > x1e. x1e PDC may be set to secondary controller mode for builds on CRD > boards whereas it may be set to pass through mode for IoT-EVK boards. > The mode configuration is done in firmware and initially shipped windows > firmware did not have SCM interface to read or modify the PDC mode. > Later only write access is opened up for non secure world. > > Using the write access available add changes to modify the PDC mode to > pass through mode via SCM write. When the write fails (on older firmware) > assume to work in secondary mode. > > Co-developed-by: Sneh Mankad > Signed-off-by: Sneh Mankad > Signed-off-by: Maulik Shah > --- [...] > +static inline bool pdc_pin_uses_seconary_mode(int pin_out) Please add a comment somewhere near here, repeating what you said in the previous commit message (about the SPIs being mapped first, followed by GPIO-as-SPIs) Konrad