From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: Hugo Villeneuve <hugo@hugovil.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
conor+dt@kernel.org, Jiri Slaby <jirislaby@kernel.org>,
jringle@gridpoint.com, tomasz.mon@camlingroup.com,
l.perczak@camlintechnologies.com,
linux-serial <linux-serial@vger.kernel.org>,
devicetree@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
linux-gpio@vger.kernel.org,
Hugo Villeneuve <hvilleneuve@dimonoff.com>
Subject: Re: [PATCH v3 03/11] serial: sc16is7xx: mark IOCONTROL register as volatile
Date: Thu, 25 May 2023 14:02:19 +0300 (EEST) [thread overview]
Message-ID: <751bc02d-d06f-55cb-cb7a-a39871a0775d@linux.intel.com> (raw)
In-Reply-To: <20230525040324.3773741-4-hugo@hugovil.com>
On Thu, 25 May 2023, Hugo Villeneuve wrote:
> From: Hugo Villeneuve <hvilleneuve@dimonoff.com>
>
> Bit SRESET (3) is cleared when a reset operation is completed. Having
> the IOCONTROL register as non-volatile will always read SRESET as 1.
> Therefore mark IOCONTROL register as a volatile register.
>
> Fixes: dfeae619d781 ("serial: sc16is7xx")
> Signed-off-by: Hugo Villeneuve <hvilleneuve@dimonoff.com>
What is the impact of this problem? That is, what doesn't work? I only see
writes to SC16IS7XX_IOCONTROL_REG. If there are no concrete problems
fixed, don't put Fixes tag.
--
i.
> ---
> drivers/tty/serial/sc16is7xx.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/tty/serial/sc16is7xx.c b/drivers/tty/serial/sc16is7xx.c
> index 00054bb49780..a7c4da3cfd2b 100644
> --- a/drivers/tty/serial/sc16is7xx.c
> +++ b/drivers/tty/serial/sc16is7xx.c
> @@ -488,6 +488,7 @@ static bool sc16is7xx_regmap_volatile(struct device *dev, unsigned int reg)
> case SC16IS7XX_TXLVL_REG:
> case SC16IS7XX_RXLVL_REG:
> case SC16IS7XX_IOSTATE_REG:
> + case SC16IS7XX_IOCONTROL_REG:
> return true;
> default:
> break;
>
next prev parent reply other threads:[~2023-05-25 11:03 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-25 4:03 [PATCH v3 00/11] serial: sc16is7xx: fix GPIO regression and rs485 improvements Hugo Villeneuve
2023-05-25 4:03 ` [PATCH v3 01/11] serial: sc16is7xx: fix syntax error in comments Hugo Villeneuve
2023-05-25 4:03 ` [PATCH v3 02/11] serial: sc16is7xx: improve comments about variants Hugo Villeneuve
2023-05-25 4:03 ` [PATCH v3 03/11] serial: sc16is7xx: mark IOCONTROL register as volatile Hugo Villeneuve
2023-05-25 11:02 ` Ilpo Järvinen [this message]
2023-05-25 13:45 ` Hugo Villeneuve
2023-05-25 4:03 ` [PATCH v3 04/11] serial: sc16is7xx: add post reset delay Hugo Villeneuve
2023-05-25 10:30 ` andy.shevchenko
2023-05-25 13:18 ` Hugo Villeneuve
2023-05-25 11:05 ` Ilpo Järvinen
2023-05-25 14:05 ` Hugo Villeneuve
2023-05-25 4:03 ` [PATCH v3 05/11] serial: sc16is7xx: fix broken port 0 uart init Hugo Villeneuve
2023-05-25 11:20 ` Ilpo Järvinen
2023-05-25 15:10 ` Hugo Villeneuve
2023-05-25 4:03 ` [PATCH v3 06/11] serial: sc16is7xx: fix bug when first setting GPIO direction Hugo Villeneuve
2023-05-25 11:10 ` andy.shevchenko
2023-05-25 14:24 ` Hugo Villeneuve
2023-05-25 4:03 ` [PATCH v3 07/11] dt-bindings: sc16is7xx: Add property to change GPIO function Hugo Villeneuve
2023-05-25 11:11 ` andy.shevchenko
2023-05-25 14:34 ` Hugo Villeneuve
2023-05-25 15:15 ` Conor Dooley
2023-05-26 18:28 ` andy.shevchenko
2023-05-25 4:03 ` [PATCH v3 08/11] serial: sc16is7xx: fix regression with GPIO configuration Hugo Villeneuve
2023-05-25 11:19 ` andy.shevchenko
2023-05-25 15:02 ` Hugo Villeneuve
2023-05-26 18:34 ` andy.shevchenko
2023-05-25 12:03 ` Ilpo Järvinen
2023-05-25 15:19 ` Hugo Villeneuve
2023-05-25 4:03 ` [PATCH v3 09/11] serial: sc16is7xx: add I/O register translation offset Hugo Villeneuve
2023-05-25 11:22 ` andy.shevchenko
2023-05-25 15:31 ` Hugo Villeneuve
2023-05-25 17:20 ` Hugo Villeneuve
2023-05-26 18:36 ` andy.shevchenko
2023-05-25 12:10 ` Ilpo Järvinen
2023-05-25 15:25 ` Hugo Villeneuve
2023-05-25 4:03 ` [PATCH v3 10/11] serial: sc16is7xx: add call to get rs485 DT flags and properties Hugo Villeneuve
2023-05-25 12:17 ` Ilpo Järvinen
2023-05-25 4:03 ` [PATCH v3 11/11] serial: sc16is7xx: add dump registers function Hugo Villeneuve
2023-05-25 11:26 ` andy.shevchenko
2023-05-25 19:49 ` Hugo Villeneuve
2023-05-26 18:38 ` andy.shevchenko
2023-05-28 11:56 ` Greg KH
2023-05-25 10:27 ` [PATCH v3 00/11] serial: sc16is7xx: fix GPIO regression and rs485 improvements andy.shevchenko
2023-05-25 13:26 ` Hugo Villeneuve
2023-05-25 13:37 ` Andy Shevchenko
2023-05-25 13:39 ` Hugo Villeneuve
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=751bc02d-d06f-55cb-cb7a-a39871a0775d@linux.intel.com \
--to=ilpo.jarvinen@linux.intel.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hugo@hugovil.com \
--cc=hvilleneuve@dimonoff.com \
--cc=jirislaby@kernel.org \
--cc=jringle@gridpoint.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=l.perczak@camlintechnologies.com \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=tomasz.mon@camlingroup.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).