From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Mukesh Ojha <quic_mojha@quicinc.com>,
corbet@lwn.net, agross@kernel.org, andersson@kernel.org,
konrad.dybcio@linaro.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
keescook@chromium.org, tony.luck@intel.com, gpiccoli@igalia.com,
mathieu.poirier@linaro.org, catalin.marinas@arm.com,
will@kernel.org, linus.walleij@linaro.org,
andy.shevchenko@gmail.com, vigneshr@ti.com, nm@ti.com,
matthias.bgg@gmail.com, kgene@kernel.org,
alim.akhtar@samsung.com, bmasney@redhat.com,
quic_tsoni@quicinc.com
Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org, linux-hardening@vger.kernel.org,
linux-remoteproc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org,
linux-mediatek@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, kernel@quicinc.com
Subject: Re: [PATCH v5 07/17] soc: qcom: minidump: Add pending region registration
Date: Mon, 11 Sep 2023 13:08:48 +0200 [thread overview]
Message-ID: <75466db4-3d19-33f6-b2de-db714186a96b@linaro.org> (raw)
In-Reply-To: <1694290578-17733-8-git-send-email-quic_mojha@quicinc.com>
On 09/09/2023 22:16, Mukesh Ojha wrote:
> static int qcom_apss_minidump_probe(struct platform_device *pdev)
> {
> struct minidump_global_toc *mdgtoc;
> @@ -571,7 +688,10 @@ static int qcom_apss_minidump_probe(struct platform_device *pdev)
> return ret;
> }
>
> + mutex_lock(&md_plist.plock);
> platform_set_drvdata(pdev, md);
Why this is locked?
> + qcom_apss_register_pending_regions(md);
Why this one is locked? It seems ordering of your operations is not
correct if you need to lock the providers probe().
> + mutex_unlock(&md_plist.plock);
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-09-11 21:05 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-09 20:16 [PATCH v5 00/17] Add Qualcomm Minidump kernel driver related support Mukesh Ojha
2023-09-09 20:16 ` [PATCH v5 01/17] docs: qcom: Add qualcomm minidump guide Mukesh Ojha
2023-09-09 20:16 ` [PATCH v5 02/17] soc: qcom: Add qcom_rproc_minidump module Mukesh Ojha
2023-09-09 20:16 ` [PATCH v5 03/17] remoteproc: qcom_q6v5_pas: Use qcom_rproc_minidump() Mukesh Ojha
2023-09-09 20:16 ` [PATCH v5 04/17] remoteproc: qcom: Remove minidump related data from qcom_common.c Mukesh Ojha
2023-09-09 20:16 ` [PATCH v5 05/17] init: export linux_banner data variable Mukesh Ojha
2023-09-09 20:16 ` [PATCH v5 06/17] soc: qcom: Add Qualcomm APSS minidump kernel driver Mukesh Ojha
2023-09-11 11:01 ` Krzysztof Kozlowski
2023-09-12 9:26 ` Mukesh Ojha
2023-09-12 9:54 ` Krzysztof Kozlowski
2023-09-13 7:09 ` Mukesh Ojha
2023-09-12 9:58 ` Mukesh Ojha
2023-09-11 11:07 ` Krzysztof Kozlowski
2023-09-11 19:09 ` Jeff Johnson
2023-09-11 19:33 ` Konrad Dybcio
2023-09-13 15:18 ` Mukesh Ojha
2023-09-09 20:16 ` [PATCH v5 07/17] soc: qcom: minidump: Add pending region registration Mukesh Ojha
2023-09-11 11:08 ` Krzysztof Kozlowski [this message]
2023-09-11 18:59 ` Jeff Johnson
2023-09-09 20:16 ` [PATCH v5 08/17] arm64: mm: Add dynamic ramoops region support through command line Mukesh Ojha
2023-09-11 5:22 ` Pavan Kondeti
2023-09-09 20:16 ` [PATCH v5 09/17] pstore/ram: Use dynamic ramoops reserve resource Mukesh Ojha
2023-09-11 5:33 ` Pavan Kondeti
2023-09-11 10:51 ` Mukesh Ojha
2023-09-12 0:39 ` Pavan Kondeti
2023-09-12 9:46 ` Mukesh Ojha
2023-09-09 20:16 ` [PATCH v5 10/17] pstore: Add pstore_region_defined() helper and export it Mukesh Ojha
2023-09-09 20:16 ` [PATCH v5 11/17] qcom_minidump: Register ramoops region with minidump Mukesh Ojha
2023-09-11 6:01 ` Pavan Kondeti
2023-09-11 7:58 ` Mukesh Ojha
2023-09-11 11:09 ` Krzysztof Kozlowski
2023-09-09 20:16 ` [PATCH v5 12/17] MAINTAINERS: Add entry for minidump related files Mukesh Ojha
2023-09-09 20:16 ` [PATCH v5 13/17] firmware: qcom_scm: provide a read-modify-write function Mukesh Ojha
2023-09-11 8:08 ` Kathiravan Thirumoorthy
2023-09-11 8:11 ` Kathiravan Thirumoorthy
2023-09-09 20:16 ` [PATCH v5 14/17] pinctrl: qcom: Use qcom_scm_io_update_field() Mukesh Ojha
2023-09-09 20:16 ` [PATCH v5 15/17] firmware: scm: Modify only the download bits in TCSR register Mukesh Ojha
2023-09-11 8:11 ` Kathiravan Thirumoorthy
2023-09-11 8:16 ` Kathiravan Thirumoorthy
2023-09-09 20:16 ` [PATCH v5 16/17] firmware: qcom_scm: Refactor code to support multiple download mode Mukesh Ojha
2023-09-09 20:16 ` [PATCH v5 17/17] firmware: qcom_scm: Add multiple download mode support Mukesh Ojha
2023-09-11 7:59 ` [PATCH v5 00/17] Add Qualcomm Minidump kernel driver related support Kathiravan Thirumoorthy
2023-09-11 8:52 ` Bagas Sanjaya
2023-09-11 10:39 ` Mukesh Ojha
2023-09-11 13:14 ` Bagas Sanjaya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=75466db4-3d19-33f6-b2de-db714186a96b@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=andersson@kernel.org \
--cc=andy.shevchenko@gmail.com \
--cc=bmasney@redhat.com \
--cc=catalin.marinas@arm.com \
--cc=conor+dt@kernel.org \
--cc=corbet@lwn.net \
--cc=gpiccoli@igalia.com \
--cc=keescook@chromium.org \
--cc=kernel@quicinc.com \
--cc=kgene@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=matthias.bgg@gmail.com \
--cc=nm@ti.com \
--cc=quic_mojha@quicinc.com \
--cc=quic_tsoni@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=tony.luck@intel.com \
--cc=vigneshr@ti.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).