From: "Jernej Škrabec" <jernej.skrabec@gmail.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] pinctrl: pinmux: Use dev_err_probe() in pin_request()
Date: Tue, 12 Sep 2023 17:52:35 +0200 [thread overview]
Message-ID: <7566964.EvYhyI6sBW@jernej-laptop> (raw)
In-Reply-To: <CACRpkdbTZYnehWiWFgY3KJLFdS47RpxOp-Cct4BDqgYCYtd2vw@mail.gmail.com>
Dne torek, 12. september 2023 ob 10:15:31 CEST je Linus Walleij napisal(a):
> Hi Jenej,
>
> thanks for your patch!
>
> On Sat, Sep 9, 2023 at 8:36 AM Jernej Skrabec <jernej.skrabec@gmail.com>
wrote:
> > Use dev_err_probe() when printing error message in pin_request() since
> > it may fail with -EPROBE_DEFER.
> >
> > Signed-off-by: Jernej Skrabec <jernej.skrabec@gmail.com>
>
> (...)
>
> > if (status)
> >
> > - dev_err(pctldev->dev, "pin-%d (%s) status %d\n",
> > - pin, owner, status);
> > + dev_err_probe(pctldev->dev, "pin-%d (%s) status %d\n",
> > + pin, owner, status);
> >
> > return status;
>
> That's not how you use dev_err_probe()
>
> Just replace all of the lines above with return dev_err_probe(...)
I already send v2 of this patch soon after I got report from kernel test
robot.
Best regards,
Jernej
>
> Yours,
> Linus Walleij
prev parent reply other threads:[~2023-09-12 15:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-09 6:36 [PATCH 0/2] pinctrl: pinmux: Update error reporting in pin_request() Jernej Skrabec
2023-09-09 6:36 ` [PATCH 1/2] pinctrl: pinmux: Remove duplicate error message " Jernej Skrabec
2023-09-12 8:16 ` Linus Walleij
2023-09-09 6:36 ` [PATCH 2/2] pinctrl: pinmux: Use dev_err_probe() " Jernej Skrabec
2023-09-09 9:44 ` kernel test robot
2023-09-09 10:06 ` kernel test robot
2023-09-09 13:12 ` kernel test robot
2023-09-12 8:15 ` Linus Walleij
2023-09-12 15:52 ` Jernej Škrabec [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7566964.EvYhyI6sBW@jernej-laptop \
--to=jernej.skrabec@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox