* [PATCH] pinctrl: qcom: sa8775p: add the wakeirq map
@ 2023-05-12 15:32 Bartosz Golaszewski
2023-05-13 9:26 ` Konrad Dybcio
0 siblings, 1 reply; 3+ messages in thread
From: Bartosz Golaszewski @ 2023-05-12 15:32 UTC (permalink / raw)
To: Bjorn Andersson, Andy Gross, Konrad Dybcio, Linus Walleij
Cc: linux-arm-msm, linux-gpio, linux-kernel, Bartosz Golaszewski
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
The SA8775P TLMM driver is missing the GPIO-to-wakeup-pin mapping. This
adds it.
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
---
drivers/pinctrl/qcom/pinctrl-sa8775p.c | 19 +++++++++++++++++++
1 file changed, 19 insertions(+)
diff --git a/drivers/pinctrl/qcom/pinctrl-sa8775p.c b/drivers/pinctrl/qcom/pinctrl-sa8775p.c
index 2ae7cdca65d3..422d72ed1012 100644
--- a/drivers/pinctrl/qcom/pinctrl-sa8775p.c
+++ b/drivers/pinctrl/qcom/pinctrl-sa8775p.c
@@ -1491,6 +1491,23 @@ static const struct msm_pingroup sa8775p_groups[] = {
[153] = SDC_QDSD_PINGROUP(sdc1_data, 0x199000, 9, 0),
};
+static const struct msm_gpio_wakeirq_map sa8775p_pdc_map[] = {
+ { 0, 169 }, { 1, 174 }, { 2, 170 }, { 3, 175 }, { 4, 171 }, { 5, 173 },
+ { 6, 172 }, { 7, 182 }, { 10, 220 }, { 11, 213 }, { 12, 221 },
+ { 16, 230 }, { 19, 231 }, { 20, 232 }, { 23, 233 }, { 24, 234 },
+ { 26, 223 }, { 27, 235 }, { 28, 209 }, { 29, 176 }, { 39, 200 },
+ { 31, 201 }, { 32, 212 }, { 35, 177 }, { 36, 178 }, { 39, 184 },
+ { 40, 185 }, { 41, 227 }, { 42, 186 }, { 43, 228 }, { 45, 187 },
+ { 47, 188 }, { 48, 194 }, { 51, 195 }, { 52, 196 }, { 55, 197 },
+ { 56, 198 }, { 57, 236 }, { 58, 192 }, { 59, 193 }, { 72, 179 },
+ { 73, 180 }, { 74, 181 }, { 75, 202 }, { 76, 183 }, { 77, 189 },
+ { 78, 190 }, { 79, 191 }, { 80, 199 }, { 83, 204 }, { 84, 205 },
+ { 85, 229 }, { 86, 206 }, { 89, 207 }, { 91, 208 }, { 94, 214 },
+ { 95, 215 }, { 96, 237 }, { 97, 216 }, { 98, 238 }, { 99, 217 },
+ { 100, 239 }, { 105, 219 }, { 106, 210 }, { 107, 211 }, { 108, 222 },
+ { 109, 203 }, { 145, 225 }, { 146, 226 },
+};
+
static const struct msm_pinctrl_soc_data sa8775p_pinctrl = {
.pins = sa8775p_pins,
.npins = ARRAY_SIZE(sa8775p_pins),
@@ -1499,6 +1516,8 @@ static const struct msm_pinctrl_soc_data sa8775p_pinctrl = {
.groups = sa8775p_groups,
.ngroups = ARRAY_SIZE(sa8775p_groups),
.ngpios = 150,
+ .wakeirq_map = sa8775p_pdc_map,
+ .nwakeirq_map = ARRAY_SIZE(sa8775p_pdc_map),
};
static int sa8775p_pinctrl_probe(struct platform_device *pdev)
--
2.39.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] pinctrl: qcom: sa8775p: add the wakeirq map
2023-05-12 15:32 [PATCH] pinctrl: qcom: sa8775p: add the wakeirq map Bartosz Golaszewski
@ 2023-05-13 9:26 ` Konrad Dybcio
2023-05-15 8:01 ` Bartosz Golaszewski
0 siblings, 1 reply; 3+ messages in thread
From: Konrad Dybcio @ 2023-05-13 9:26 UTC (permalink / raw)
To: Bartosz Golaszewski, Bjorn Andersson, Andy Gross, Linus Walleij
Cc: linux-arm-msm, linux-gpio, linux-kernel, Bartosz Golaszewski
On 12.05.2023 17:32, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>
> The SA8775P TLMM driver is missing the GPIO-to-wakeup-pin mapping. This
> adds it.
>
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> ---
This almost matches
https://git.codelinaro.org/clo/la/kernel/msm-5.15/-/commit/d7af4a14603957d414e931b5f175f36f3537ae34
minus one diff:
< { 39, 200 },
---
> { 30, 200 },
please consult which one is correct with qc folks
Konrad
> drivers/pinctrl/qcom/pinctrl-sa8775p.c | 19 +++++++++++++++++++
> 1 file changed, 19 insertions(+)
>
> diff --git a/drivers/pinctrl/qcom/pinctrl-sa8775p.c b/drivers/pinctrl/qcom/pinctrl-sa8775p.c
> index 2ae7cdca65d3..422d72ed1012 100644
> --- a/drivers/pinctrl/qcom/pinctrl-sa8775p.c
> +++ b/drivers/pinctrl/qcom/pinctrl-sa8775p.c
> @@ -1491,6 +1491,23 @@ static const struct msm_pingroup sa8775p_groups[] = {
> [153] = SDC_QDSD_PINGROUP(sdc1_data, 0x199000, 9, 0),
> };
>
> +static const struct msm_gpio_wakeirq_map sa8775p_pdc_map[] = {
> + { 0, 169 }, { 1, 174 }, { 2, 170 }, { 3, 175 }, { 4, 171 }, { 5, 173 },
> + { 6, 172 }, { 7, 182 }, { 10, 220 }, { 11, 213 }, { 12, 221 },
> + { 16, 230 }, { 19, 231 }, { 20, 232 }, { 23, 233 }, { 24, 234 },
> + { 26, 223 }, { 27, 235 }, { 28, 209 }, { 29, 176 }, { 39, 200 },
> + { 31, 201 }, { 32, 212 }, { 35, 177 }, { 36, 178 }, { 39, 184 },
> + { 40, 185 }, { 41, 227 }, { 42, 186 }, { 43, 228 }, { 45, 187 },
> + { 47, 188 }, { 48, 194 }, { 51, 195 }, { 52, 196 }, { 55, 197 },
> + { 56, 198 }, { 57, 236 }, { 58, 192 }, { 59, 193 }, { 72, 179 },
> + { 73, 180 }, { 74, 181 }, { 75, 202 }, { 76, 183 }, { 77, 189 },
> + { 78, 190 }, { 79, 191 }, { 80, 199 }, { 83, 204 }, { 84, 205 },
> + { 85, 229 }, { 86, 206 }, { 89, 207 }, { 91, 208 }, { 94, 214 },
> + { 95, 215 }, { 96, 237 }, { 97, 216 }, { 98, 238 }, { 99, 217 },
> + { 100, 239 }, { 105, 219 }, { 106, 210 }, { 107, 211 }, { 108, 222 },
> + { 109, 203 }, { 145, 225 }, { 146, 226 },
> +};
> +
> static const struct msm_pinctrl_soc_data sa8775p_pinctrl = {
> .pins = sa8775p_pins,
> .npins = ARRAY_SIZE(sa8775p_pins),
> @@ -1499,6 +1516,8 @@ static const struct msm_pinctrl_soc_data sa8775p_pinctrl = {
> .groups = sa8775p_groups,
> .ngroups = ARRAY_SIZE(sa8775p_groups),
> .ngpios = 150,
> + .wakeirq_map = sa8775p_pdc_map,
> + .nwakeirq_map = ARRAY_SIZE(sa8775p_pdc_map),
> };
>
> static int sa8775p_pinctrl_probe(struct platform_device *pdev)
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] pinctrl: qcom: sa8775p: add the wakeirq map
2023-05-13 9:26 ` Konrad Dybcio
@ 2023-05-15 8:01 ` Bartosz Golaszewski
0 siblings, 0 replies; 3+ messages in thread
From: Bartosz Golaszewski @ 2023-05-15 8:01 UTC (permalink / raw)
To: Konrad Dybcio
Cc: Bjorn Andersson, Andy Gross, Linus Walleij, linux-arm-msm,
linux-gpio, linux-kernel, Bartosz Golaszewski
On Sat, May 13, 2023 at 11:26 AM Konrad Dybcio <konrad.dybcio@linaro.org> wrote:
>
>
>
> On 12.05.2023 17:32, Bartosz Golaszewski wrote:
> > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> >
> > The SA8775P TLMM driver is missing the GPIO-to-wakeup-pin mapping. This
> > adds it.
> >
> > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> > ---
> This almost matches
>
> https://git.codelinaro.org/clo/la/kernel/msm-5.15/-/commit/d7af4a14603957d414e931b5f175f36f3537ae34
>
> minus one diff:
>
> < { 39, 200 },
> ---
> > { 30, 200 },
>
It's my typo, thanks for catching it.
Bartosz
> please consult which one is correct with qc folks
>
> Konrad
> > drivers/pinctrl/qcom/pinctrl-sa8775p.c | 19 +++++++++++++++++++
> > 1 file changed, 19 insertions(+)
> >
> > diff --git a/drivers/pinctrl/qcom/pinctrl-sa8775p.c b/drivers/pinctrl/qcom/pinctrl-sa8775p.c
> > index 2ae7cdca65d3..422d72ed1012 100644
> > --- a/drivers/pinctrl/qcom/pinctrl-sa8775p.c
> > +++ b/drivers/pinctrl/qcom/pinctrl-sa8775p.c
> > @@ -1491,6 +1491,23 @@ static const struct msm_pingroup sa8775p_groups[] = {
> > [153] = SDC_QDSD_PINGROUP(sdc1_data, 0x199000, 9, 0),
> > };
> >
> > +static const struct msm_gpio_wakeirq_map sa8775p_pdc_map[] = {
> > + { 0, 169 }, { 1, 174 }, { 2, 170 }, { 3, 175 }, { 4, 171 }, { 5, 173 },
> > + { 6, 172 }, { 7, 182 }, { 10, 220 }, { 11, 213 }, { 12, 221 },
> > + { 16, 230 }, { 19, 231 }, { 20, 232 }, { 23, 233 }, { 24, 234 },
> > + { 26, 223 }, { 27, 235 }, { 28, 209 }, { 29, 176 }, { 39, 200 },
> > + { 31, 201 }, { 32, 212 }, { 35, 177 }, { 36, 178 }, { 39, 184 },
> > + { 40, 185 }, { 41, 227 }, { 42, 186 }, { 43, 228 }, { 45, 187 },
> > + { 47, 188 }, { 48, 194 }, { 51, 195 }, { 52, 196 }, { 55, 197 },
> > + { 56, 198 }, { 57, 236 }, { 58, 192 }, { 59, 193 }, { 72, 179 },
> > + { 73, 180 }, { 74, 181 }, { 75, 202 }, { 76, 183 }, { 77, 189 },
> > + { 78, 190 }, { 79, 191 }, { 80, 199 }, { 83, 204 }, { 84, 205 },
> > + { 85, 229 }, { 86, 206 }, { 89, 207 }, { 91, 208 }, { 94, 214 },
> > + { 95, 215 }, { 96, 237 }, { 97, 216 }, { 98, 238 }, { 99, 217 },
> > + { 100, 239 }, { 105, 219 }, { 106, 210 }, { 107, 211 }, { 108, 222 },
> > + { 109, 203 }, { 145, 225 }, { 146, 226 },
> > +};
> > +
> > static const struct msm_pinctrl_soc_data sa8775p_pinctrl = {
> > .pins = sa8775p_pins,
> > .npins = ARRAY_SIZE(sa8775p_pins),
> > @@ -1499,6 +1516,8 @@ static const struct msm_pinctrl_soc_data sa8775p_pinctrl = {
> > .groups = sa8775p_groups,
> > .ngroups = ARRAY_SIZE(sa8775p_groups),
> > .ngpios = 150,
> > + .wakeirq_map = sa8775p_pdc_map,
> > + .nwakeirq_map = ARRAY_SIZE(sa8775p_pdc_map),
> > };
> >
> > static int sa8775p_pinctrl_probe(struct platform_device *pdev)
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-05-15 8:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-05-12 15:32 [PATCH] pinctrl: qcom: sa8775p: add the wakeirq map Bartosz Golaszewski
2023-05-13 9:26 ` Konrad Dybcio
2023-05-15 8:01 ` Bartosz Golaszewski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).