From: Ajay Kumar Nandam <ajay.nandam@oss.qualcomm.com>
To: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>,
Bjorn Andersson <andersson@kernel.org>,
Linus Walleij <linusw@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org,
srinivas.kandagatla@oss.qualcomm.com
Subject: Re: [PATCH v1 2/3] pinctrl: qcom: lpass-lpi: Fix GPIO register access helper return types
Date: Mon, 20 Apr 2026 14:12:05 +0530 [thread overview]
Message-ID: <7881bf0a-27f4-4a54-af14-9b2a5b7bb295@oss.qualcomm.com> (raw)
In-Reply-To: <c73eaf9d-2ee3-4d18-b1f3-061711948688@oss.qualcomm.com>
On 4/14/2026 2:09 PM, Konrad Dybcio wrote:
> On 4/13/26 2:22 PM, Ajay Kumar Nandam wrote:
>> The LPI GPIO register access helpers previously returned the value from
>> ioread32(), even though their return type was int. This mixes data
>> return with status and is inconsistent with common kernel helper
>> conventions.
>>
>> Rework lpi_gpio_read() and lpi_gpio_write() to return an int status and
>> use output parameters to pass register values. Update all callers to
>> match the new helper interface.
>
> lpi_gpio_read/write() can never fail, let's just make _read() return
> a u32 and _write() a void
ACK, I’ll post v2 with this adjustment.
>
> Konrad
next prev parent reply other threads:[~2026-04-20 8:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-13 12:22 [PATCH v1 0/3] pinctrl: qcom: lpass-lpi: PM clock framework cleanup and fixes Ajay Kumar Nandam
2026-04-13 12:22 ` [PATCH v1 1/3] pinctrl: qcom: lpass-lpi: Switch to PM clock framework for runtime PM Ajay Kumar Nandam
2026-04-14 8:33 ` Konrad Dybcio
2026-04-20 8:51 ` Ajay Kumar Nandam
2026-04-14 8:37 ` Konrad Dybcio
2026-04-16 12:32 ` Ajay Kumar Nandam
2026-04-13 12:22 ` [PATCH v1 2/3] pinctrl: qcom: lpass-lpi: Fix GPIO register access helper return types Ajay Kumar Nandam
2026-04-14 8:39 ` Konrad Dybcio
2026-04-20 8:42 ` Ajay Kumar Nandam [this message]
2026-04-13 12:22 ` [PATCH v1 3/3] pinctrl: qcom: lpass-lpi: Resume clocks for GPIO access Ajay Kumar Nandam
2026-04-14 8:44 ` Konrad Dybcio
2026-04-20 8:45 ` Ajay Kumar Nandam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7881bf0a-27f4-4a54-af14-9b2a5b7bb295@oss.qualcomm.com \
--to=ajay.nandam@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=linusw@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=srinivas.kandagatla@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox