linux-gpio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: "Barnabás Czémán" <barnabas.czeman@mainlining.org>,
	"Bjorn Andersson" <andersson@kernel.org>,
	"Linus Walleij" <linus.walleij@linaro.org>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Konrad Dybcio" <konradybcio@kernel.org>,
	"Lee Jones" <lee@kernel.org>, "Amit Kucheria" <amitk@kernel.org>,
	"Thara Gopinath" <thara.gopinath@gmail.com>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	"Daniel Lezcano" <daniel.lezcano@linaro.org>,
	"Zhang Rui" <rui.zhang@intel.com>,
	"Lukasz Luba" <lukasz.luba@arm.com>,
	"Joerg Roedel" <joro@8bytes.org>, "Will Deacon" <will@kernel.org>,
	"Robin Murphy" <robin.murphy@arm.com>,
	"Srinivas Kandagatla" <srinivas.kandagatla@linaro.org>
Cc: linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-pm@vger.kernel.org, iommu@lists.linux.dev
Subject: Re: [PATCH v2 15/15] arm64: dts: qcom: Add Xiaomi Redmi 5A
Date: Thu, 31 Oct 2024 21:25:58 +0100	[thread overview]
Message-ID: <796b470f-7646-41d8-817e-03d93a90a1fa@oss.qualcomm.com> (raw)
In-Reply-To: <20241031-msm8917-v2-15-8a075faa89b1@mainlining.org>

On 31.10.2024 2:19 AM, Barnabás Czémán wrote:
> Add initial support for Xiaomi Redmi 5A (riva).
> 
> Signed-off-by: Barnabás Czémán <barnabas.czeman@mainlining.org>
> ---

[...]

> +	reserved-memory {
> +		/delete-node/ reserved@85b00000;

Deleting nodes is preferred via a &label (like in sm8550-samsung-q5q.dts)

> +		qseecom_mem: reserved@84a00000 {
> +			reg = <0x0 0x84a00000 0x0 0x1900000>;
> +			no-map;
> +		};
> +
> +		framebuffer_mem: memory@90001000 {
> +			reg = <0x0 0x90001000 0x0 (720 * 1280 * 3)>;
> +			no-map;
> +		};
> +	};
> +};
> +
> +&blsp_i2c3 {
> +	status = "okay";
> +
> +	touchscreen@38 {
> +		compatible = "edt,edt-ft5306";
> +		reg = <0x38>;
> +		interrupt-parent = <&tlmm>;
> +		interrupts = <65 0x2008>;

interrupts-extended = <&tlmm 65 IRQ_TYPE_LEVEL_LOW>;

[...]

> +&sdhc_1 {
> +	vmmc-supply = <&pm8937_l8>;
> +	vqmmc-supply = <&pm8937_l5>;
> +	status = "okay";

A newline before 'status' would be welcome

Looks nice otherwise!

Konrad

      reply	other threads:[~2024-10-31 20:26 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-31  1:19 [PATCH v2 00/15] Add MSM8917/PM8937/Redmi 5A Barnabás Czémán
2024-10-31  1:19 ` [PATCH v2 01/15] dt-bindings: pinctrl: qcom,pmic-gpio: add PM8937 Barnabás Czémán
2024-10-31  8:20   ` Krzysztof Kozlowski
2024-11-08  8:06   ` Linus Walleij
2024-10-31  1:19 ` [PATCH v2 02/15] pinctrl: qcom-pmic-gpio: add support for PM8937 Barnabás Czémán
2024-10-31 17:46   ` Dmitry Baryshkov
2024-11-08  8:07   ` Linus Walleij
2024-10-31  1:19 ` [PATCH v2 03/15] dt-bindings: pinctrl: qcom,pmic-mpp: Document PM8937 compatible Barnabás Czémán
2024-10-31  8:26   ` Krzysztof Kozlowski
2024-11-08  8:08   ` Linus Walleij
2024-10-31  1:19 ` [PATCH v2 04/15] pinctrl: qcom: spmi-mpp: Add " Barnabás Czémán
2024-10-31 17:47   ` Dmitry Baryshkov
2024-11-08  8:08   ` Linus Walleij
2024-10-31  1:19 ` [PATCH v2 05/15] arm64: dts: qcom: Add PM8937 PMIC Barnabás Czémán
2024-10-31 17:51   ` Dmitry Baryshkov
2024-10-31  1:19 ` [PATCH v2 06/15] dt-bindings: pinctrl: qcom: Add MSM8917 pinctrl bindings Barnabás Czémán
2024-10-31  8:24   ` Krzysztof Kozlowski
2024-10-31  1:19 ` [PATCH v2 07/15] pinctrl: qcom: Add MSM8917 tlmm pinctrl driver Barnabás Czémán
2024-10-31  1:19 ` [PATCH v2 08/15] dt-bindings: mfd: qcom,tcsr: Add compatible for MSM8917 Barnabás Czémán
2024-10-31  8:21   ` Krzysztof Kozlowski
2024-11-06  8:17   ` (subset) " Lee Jones
2024-10-31  1:19 ` [PATCH v2 09/15] dt-bindings: thermal: tsens: Add MSM8937 compatible Barnabás Czémán
2024-10-31  8:22   ` Krzysztof Kozlowski
2024-10-31  1:19 ` [PATCH v2 10/15] thermal/drivers/qcom/tsens-v1: Add support for MSM8937 tsens Barnabás Czémán
2024-10-31 17:53   ` Dmitry Baryshkov
2024-10-31  1:19 ` [PATCH v2 11/15] dt-bindings: iommu: qcom,iommu: Add MSM8917 IOMMU to SMMUv1 compatibles Barnabás Czémán
2024-10-31  8:26   ` Krzysztof Kozlowski
2024-10-31  1:19 ` [PATCH v2 12/15] dt-bindings: nvmem: Add compatible for MS8917 Barnabás Czémán
2024-10-31  8:26   ` Krzysztof Kozlowski
2024-10-31  1:19 ` [PATCH v2 13/15] arm64: dts: qcom: Add initial support for MSM8917 Barnabás Czémán
2024-10-31  1:19 ` [PATCH v2 14/15] dt-bindings: arm: qcom: Add Xiaomi Redmi 5A Barnabás Czémán
2024-10-31  8:26   ` Krzysztof Kozlowski
2024-10-31  1:19 ` [PATCH v2 15/15] arm64: dts: " Barnabás Czémán
2024-10-31 20:25   ` Konrad Dybcio [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=796b470f-7646-41d8-817e-03d93a90a1fa@oss.qualcomm.com \
    --to=konrad.dybcio@oss.qualcomm.com \
    --cc=amitk@kernel.org \
    --cc=andersson@kernel.org \
    --cc=barnabas.czeman@mainlining.org \
    --cc=conor+dt@kernel.org \
    --cc=daniel.lezcano@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=iommu@lists.linux.dev \
    --cc=joro@8bytes.org \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=lee@kernel.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=lukasz.luba@arm.com \
    --cc=rafael@kernel.org \
    --cc=robh@kernel.org \
    --cc=robin.murphy@arm.com \
    --cc=rui.zhang@intel.com \
    --cc=srinivas.kandagatla@linaro.org \
    --cc=thara.gopinath@gmail.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).