From: kgunda@codeaurora.org
To: Vinod Koul <vkoul@kernel.org>
Cc: bjorn.andersson@linaro.org, Andy Gross <agross@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm-owner@vger.kernel.org
Subject: Re: [PATCH V1] dt-bindings: pinctrl: qcom-pmic-gpio: Add support for pm6150/pm6150l
Date: Wed, 16 Oct 2019 14:18:20 +0530 [thread overview]
Message-ID: <7b50263f2a1450ceab640d6f53b4f7f8@codeaurora.org> (raw)
In-Reply-To: <20191016081530.GJ2654@vkoul-mobl>
On 2019-10-16 13:45, Vinod Koul wrote:
> On 04-10-19, 16:50, Kiran Gunda wrote:
>> Add support for the PM6150 and PM6150L GPIO support to the
>> Qualcomm PMIC GPIO binding.
>>
>> Signed-off-by: Kiran Gunda <kgunda@codeaurora.org>
>> ---
>> Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt | 4 ++++
>> drivers/pinctrl/qcom/pinctrl-spmi-gpio.c | 2 ++
>> 2 files changed, 6 insertions(+)
>>
>> diff --git
>> a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt
>> b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt
>> index c32bf32..2f48cca 100644
>> --- a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt
>> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt
>> @@ -23,6 +23,8 @@ PMIC's from Qualcomm.
>> "qcom,pms405-gpio"
>> "qcom,pm8150-gpio"
>> "qcom,pm8150b-gpio"
>> + "qcom,pm6150-gpio"
>> + "qcom,pm6150l-gpio"
>>
>> And must contain either "qcom,spmi-gpio" or "qcom,ssbi-gpio"
>> if the device is on an spmi bus or an ssbi bus respectively
>> @@ -100,6 +102,8 @@ to specify in a pin configuration subnode:
>> and gpio8)
>> gpio1-gpio12 for pm8150b (holes on gpio3, gpio4, gpio7)
>> gpio1-gpio12 for pm8150l (hole on gpio7)
>> + gpio1-gpio10 for pm6150
>> + gpio1-gpio12 for pm6150l
>
> No holes on these?
>
Yes. No holes.
> Other than this:
>
> Reviewed-by: Vinod Koul <vkoul@kernel.org>
>
>>
>> - function:
>> Usage: required
>> diff --git a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
>> b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
>> index f1fece5..387917c 100644
>> --- a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
>> +++ b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
>> @@ -1121,6 +1121,8 @@ static int pmic_gpio_remove(struct
>> platform_device *pdev)
>> { .compatible = "qcom,pm8150b-gpio", .data = (void *) 12 },
>> /* pm8150l has 12 GPIOs with holes on 7 */
>> { .compatible = "qcom,pm8150l-gpio", .data = (void *) 12 },
>> + { .compatible = "qcom,pm6150-gpio", .data = (void *) 10 },
>> + { .compatible = "qcom,pm6150l-gpio", .data = (void *) 12 },
>> { },
>> };
>>
>> --
>> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora
>> Forum,
>> a Linux Foundation Collaborative Project
prev parent reply other threads:[~2019-10-16 8:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-04 11:20 [PATCH V1] dt-bindings: pinctrl: qcom-pmic-gpio: Add support for pm6150/pm6150l Kiran Gunda
2019-10-05 4:38 ` Bjorn Andersson
2019-10-09 9:19 ` Linus Walleij
2019-10-16 8:15 ` Vinod Koul
2019-10-16 8:48 ` kgunda [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7b50263f2a1450ceab640d6f53b4f7f8@codeaurora.org \
--to=kgunda@codeaurora.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-msm-owner@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).