From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx07-00178001.pphosted.com (mx07-00178001.pphosted.com [185.132.182.106]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D792C18DB10; Tue, 25 Feb 2025 17:07:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.132.182.106 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740503240; cv=none; b=B/JhNRAETFwUsraz2lQJ0VRSH4Orcs/8sVmD/qNYGRxa6BbEOHP1svMntcAePTRgWepi/ViItROJJs+gQZ/NXyEzwyv/UzefZ87JSw7OJwlrv+yY3DT1KMNmTh0rV0jBBk+MC5oGyr+X3GDAhar/KbJfLLkpvfAK/fttFRA1tho= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740503240; c=relaxed/simple; bh=Fo/kUnPVvwMN6d2mCTh4WVFN+z8TyGGlf8yYvgnANfA=; h=Message-ID:Date:MIME-Version:From:Subject:To:CC:References: In-Reply-To:Content-Type; b=gRa1AZwJfozvyqZAKaE0g8T2lRrl0r5LJpAb/zz7eGCk84QRUW8m5EmmPJ1xkve/avVXCoBM5fNEAFd6l2S72Hf7aJdmycPUQ2FXyZuolEBvGxJ00k4cOwES8TmQKfPDPbJHpNx5HcLtSRIi8aKPaD/cefjsPPxvG22RaONbVQQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=foss.st.com; spf=pass smtp.mailfrom=foss.st.com; dkim=pass (2048-bit key) header.d=foss.st.com header.i=@foss.st.com header.b=FcPQ9Jey; arc=none smtp.client-ip=185.132.182.106 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=foss.st.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=foss.st.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=foss.st.com header.i=@foss.st.com header.b="FcPQ9Jey" Received: from pps.filterd (m0288072.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 51PEv1Fd023213; Tue, 25 Feb 2025 18:07:04 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=selector1; bh= T/Jb54THTfDypOaw3j9QTlja8nsXEGzKOXd88jtbmz0=; b=FcPQ9JeyT9/q5+3h OsRL5WzXhKeLYyKAIBd/2RaNwppTEw4jT6g4cu9RW8r/S6xSfzlzVqMDH1FQD+qS J1Q+eaPbzyEHnEH3aqOMdTOZygNqXR2w1SVcEkkZRxSssvNzJbVX1BOe0jKyzUqC 6WOOBKh32TcuCXyJL6Siwpg08uBKinAOivi3qiocwu6pj1IJeJNSgrl5R5jyv2el FnQnT82E8iRK/B3VE3RTxyrEJI8510s0dRia93BYHFf3Bw64g0y6mYZlSgUYxtXe Jx+yWTYEQjtOcdJSRBg0wh4hdF+g0/NuVKNv6Pt+M61ZD4cXV0xQtJYIrIYeccmr BbACLw== Received: from beta.dmz-ap.st.com (beta.dmz-ap.st.com [138.198.100.35]) by mx07-00178001.pphosted.com (PPS) with ESMTPS id 4512sp4ua5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 25 Feb 2025 18:07:04 +0100 (CET) Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-ap.st.com (STMicroelectronics) with ESMTP id 9DA5D40065; Tue, 25 Feb 2025 18:05:59 +0100 (CET) Received: from Webmail-eu.st.com (shfdag1node2.st.com [10.75.129.70]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id 694ED4F37FF; Tue, 25 Feb 2025 16:46:19 +0100 (CET) Received: from [10.48.86.185] (10.48.86.185) by SHFDAG1NODE2.st.com (10.75.129.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Tue, 25 Feb 2025 16:46:18 +0100 Message-ID: <7bc5c425-1d6e-4e25-b913-287478d4149f@foss.st.com> Date: Tue, 25 Feb 2025 16:46:18 +0100 Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Clement LE GOFFIC Subject: Re: [PATCH 1/9] dt-bindings: pinctrl: stm32: Add HDP includes for stm32mp platforms To: Krzysztof Kozlowski , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Maxime Coquelin , Alexandre Torgue , Bartosz Golaszewski CC: , , , , References: <20250225-hdp-upstream-v1-0-9d049c65330a@foss.st.com> <20250225-hdp-upstream-v1-1-9d049c65330a@foss.st.com> Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: SHFCAS1NODE2.st.com (10.75.129.73) To SHFDAG1NODE2.st.com (10.75.129.70) X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1057,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-02-25_05,2025-02-25_03,2024-11-22_01 On 2/25/25 14:01, Krzysztof Kozlowski wrote: > On 25/02/2025 09:48, Clément Le Goffic wrote: >> Each file introduces helpers to choose the signal to monitor through the >> HDP pin. >> Signals are different for each platforms: stm32mp13, stm32mp15, stm32mp25. > > Headers are part of bindings commit, assuming this stays... Ok will squash with the next patch >> >> Signed-off-by: Clément Le Goffic >> --- >> include/dt-bindings/pinctrl/stm32mp13-hdp.h | 130 +++++++++++++++++++++++++ >> include/dt-bindings/pinctrl/stm32mp15-hdp.h | 116 ++++++++++++++++++++++ >> include/dt-bindings/pinctrl/stm32mp25-hdp.h | 144 ++++++++++++++++++++++++++++ >> 3 files changed, 390 insertions(+) >> >> diff --git a/include/dt-bindings/pinctrl/stm32mp13-hdp.h b/include/dt-bindings/pinctrl/stm32mp13-hdp.h >> new file mode 100644 >> index 000000000000..a3487e700143 >> --- /dev/null >> +++ b/include/dt-bindings/pinctrl/stm32mp13-hdp.h >> @@ -0,0 +1,130 @@ >> +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-3-Clause) */ >> +/* >> + * Copyright (C) STMicroelectronics 2025 - All Rights Reserved >> + * Author: Clément Le Goffic for STMicroelectronics. >> + */ >> + >> +#ifndef _DT_BINDINGS_STM32MP13_HDP_H >> +#define _DT_BINDINGS_STM32MP13_HDP_H >> + >> +/* define a macro for each function a HDP pin can transmit */ >> +#define HDP0_PWR_PWRWAKE_SYS "0" > > > Why this is a string not a number? > > Where is it used? I don't see usage in the driver, so this does not look > like binding (and DTS is not a driver). Those files are helpers for the devicetrees and may be included in stm32mp*-pinctrl.dtsi files. It is a string because it is an helper for the `function` property of `pinmux-node.yaml` which is a string. I understand that having a number as a string is not easily understandable. I'll consider it in a V2 by trying to use the `pinmux` property. > Best regards, > Krzysztof Best regards, Clément