Re: [PATCH v6 3/8] dt-bindings: leds: Binding for RTL8231 scan matrix

[Sander Vanheule <sander@svanheule.net>]

Hi Rob,

On Sun, 2025-10-26 at 16:59 -0500, Rob Herring wrote:
> On Tue, Oct 21, 2025 at 04:23:58PM +0200, Sander Vanheule wrote:
> > +  realtek,led-scan-mode:
> > +    $ref: /schemas/types.yaml#/definitions/string
> > +    description: |
> 
> You don't need '|' if there is no formatting to preserve.

Will drop it.

> > +      Specify the scanning mode the chip should run in. See general
> > description
> > +      for how the scanning matrices are wired up.
> > +    enum: [single-color, bi-color]
> 
> Wouldn't 'single' and 'bi' be sufficient?

I used these values to align with the datasheet:

   En_bicolor
   1'b0: Uses single-color LED when in Scan LED mode
   1'b1: Uses bi-color LED when in Scan LED mode

If you would like a single word, I would prefer [single, dual] and mention the
single-color/bi-color mapping in the description.

> 
> > +
> > +patternProperties:
> > +  "^led@":
> 
> You need to define the unit-address format:
> 
> "^led@([1-2]?[0-9]|3[0-1]),[0-2]$"

Hadn't considered that yet. I'll update this too.


Best,
Sander