From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: Dan Carpenter <dan.carpenter@linaro.org>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>,
Dmitry Baryshkov <dbaryshkov@gmail.com>,
linux-gpio@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
stable@vger.kernel.org
Subject: Re: [PATCH 1/2] gpio: amd8111: Convert PCIBIOS_* return codes to errnos
Date: Mon, 27 May 2024 17:11:32 +0300 (EEST) [thread overview]
Message-ID: <7d475c6c-8bbf-86f4-b2d8-8bc11cb9043e@linux.intel.com> (raw)
In-Reply-To: <09f2f3ac-94a7-43d3-8c43-0d264a1d9c65@moroto.mountain>
[-- Attachment #1: Type: text/plain, Size: 1012 bytes --]
On Mon, 27 May 2024, Dan Carpenter wrote:
> On Mon, May 27, 2024 at 04:23:44PM +0300, Ilpo Järvinen wrote:
> > diff --git a/drivers/gpio/gpio-amd8111.c b/drivers/gpio/gpio-amd8111.c
> > index 6f3ded619c8b..3377667a28de 100644
> > --- a/drivers/gpio/gpio-amd8111.c
> > +++ b/drivers/gpio/gpio-amd8111.c
> > @@ -195,8 +195,10 @@ static int __init amd_gpio_init(void)
> >
> > found:
> > err = pci_read_config_dword(pdev, 0x58, &gp.pmbase);
> > - if (err)
> > + if (err) {
> > + err = pcibios_err_to_errno(err);
>
> The patch is correct, but is the CC to stable necessary? Is this a real
> concern?
>
> Most callers don't check. Linus Torvalds, once said something to the
> effect that if your PCI bus starts failing, there isn't anything the
> operating system can do, so checking is pointless. The only fix is to
> buy new hardware. There was a hotpluggable PCI back in the day but I
> don't think it exists any more.
I don't mind if the CC stable isn't there.
--
i.
next prev parent reply other threads:[~2024-05-27 14:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-27 13:23 [PATCH 1/2] gpio: amd8111: Convert PCIBIOS_* return codes to errnos Ilpo Järvinen
2024-05-27 13:23 ` [PATCH 2/2] gpio: rdc321x: " Ilpo Järvinen
2024-05-27 14:02 ` [PATCH 1/2] gpio: amd8111: " Dan Carpenter
2024-05-27 14:11 ` Ilpo Järvinen [this message]
2024-05-27 14:26 ` Dan Carpenter
2024-05-27 14:57 ` Ilpo Järvinen
2024-05-30 9:30 ` Andy Shevchenko
2024-05-30 9:21 ` Bartosz Golaszewski
2024-05-30 9:22 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7d475c6c-8bbf-86f4-b2d8-8bc11cb9043e@linux.intel.com \
--to=ilpo.jarvinen@linux.intel.com \
--cc=brgl@bgdev.pl \
--cc=dan.carpenter@linaro.org \
--cc=dbaryshkov@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).