From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8027C7EE2D for ; Mon, 27 Feb 2023 09:32:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229886AbjB0JcY (ORCPT ); Mon, 27 Feb 2023 04:32:24 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44200 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229928AbjB0JcW (ORCPT ); Mon, 27 Feb 2023 04:32:22 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 152E8A24A for ; Mon, 27 Feb 2023 01:31:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1677490287; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RZ7tgd2yMldNRnjyOaSsgByklv9W+sBvCfRkPHDmb94=; b=gR45BAQoRRR7BQ4XcFbcUHwQ3FeiufoFMFx4RiGFo1SXaHCr3dj6a9Simf/n0Ms0zvOujC Ubw7JpRvbCCPJ4S1rQZg4ovL1ED1AQZwmKZ5flSWigKOX1yJmANZHHrwRxOSsD/sRUDnYV gl4YnA3YFImC5i35LzHZY8QMmS9gBHQ= Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-550-i5r2A7_rM_21HfQEgqcEFA-1; Mon, 27 Feb 2023 04:31:25 -0500 X-MC-Unique: i5r2A7_rM_21HfQEgqcEFA-1 Received: by mail-ed1-f70.google.com with SMTP id g33-20020a056402322100b004b0e54e03acso6953884eda.8 for ; Mon, 27 Feb 2023 01:31:25 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=RZ7tgd2yMldNRnjyOaSsgByklv9W+sBvCfRkPHDmb94=; b=4r/iQfQpCXD25VOpq1WVmdieDUNyd61DM3udbIVTQXJFGR4kv2TYMpeaPC4paHuLEo +ZZGIBzZlQsy7HnSTpOeupnXrCYrPW36WwjYGGbm4Zl6WZjHnny1UW4uTsg4N4n4waYt A9Kjbsw0cv39JavFN8OXibQ5y4SlorFgeLR8dS+t2H1AyKJ124UBB6JTfsQmeYrJNTX1 TqsigYyVO/xEqgMt7/++T+OvpRn+RsnZGvjSsYMcWY+inTPG0nkQSwzrom5TNSiHvhLz qTA2I01viq6SO+nU7ig/7/dxIeGHOkzpKUQ3Y5ZL0H0JdIUo4C/NGWSKul95XGBKiIYj 6wYg== X-Gm-Message-State: AO0yUKWungjDPfo6O27ecensSTN8K9gqcr0u2Mt9Y8SxtXaSe/64Snic amX3qT/Mc38sxwCAEVO++k0RQhnXmmDSap5QILAonwS3NSPzZyfZztq0+ePH3VzPsNQW6qdy+6o xyogYwg5z4FEPnA0oK+6jQg== X-Received: by 2002:a17:906:4d8c:b0:8ae:f73e:233f with SMTP id s12-20020a1709064d8c00b008aef73e233fmr36187968eju.32.1677490284511; Mon, 27 Feb 2023 01:31:24 -0800 (PST) X-Google-Smtp-Source: AK7set+NbVSpt4yOAnECcpAr2/cCoG6u5mlrIrkJajmml4ubXI2EjR7IrG3eLzjCQWCzYYep+F5FNw== X-Received: by 2002:a17:906:4d8c:b0:8ae:f73e:233f with SMTP id s12-20020a1709064d8c00b008aef73e233fmr36187918eju.32.1677490284210; Mon, 27 Feb 2023 01:31:24 -0800 (PST) Received: from [10.40.98.142] ([78.108.130.194]) by smtp.gmail.com with ESMTPSA id qq10-20020a17090720ca00b008e09deb6610sm2942505ejb.200.2023.02.27.01.31.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 27 Feb 2023 01:31:23 -0800 (PST) Message-ID: <7dd27ec5-0619-128d-8407-6711a05ef271@redhat.com> Date: Mon, 27 Feb 2023 10:31:22 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH 0/8] drivers: select REGMAP instead of depending on it Content-Language: en-US To: Randy Dunlap , linux-kernel@vger.kernel.org Cc: Andrew Jeffery , Corey Minyard , openipmi-developer@lists.sourceforge.net, Arnd Bergmann , Greg Kroah-Hartman , Riku Voipio , Stephen Boyd , Michael Turquette , linux-clk@vger.kernel.org, Michael Walle , Linus Walleij , Bartosz Golaszewski , linux-gpio@vger.kernel.org, Dan Murphy , Pavel Machek , Jacek Anaszewski , Lee Jones , linux-leds@vger.kernel.org, Darren Hart , Michael Shych , Mark Gross , Vadim Pasternak , platform-driver-x86@vger.kernel.org, Yegnesh S Iyer , Bin Gao , Zhang Rui , "Rafael J. Wysocki" , Daniel Lezcano , Amit Kucheria , linux-pm@vger.kernel.org, Oskar Senft , linux-serial@vger.kernel.org References: <20230226053953.4681-1-rdunlap@infradead.org> From: Hans de Goede In-Reply-To: <20230226053953.4681-1-rdunlap@infradead.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Hi Randy, On 2/26/23 06:39, Randy Dunlap wrote: > REGMAP is a hidden (not user visible) symbol. Users cannot set it > directly thru "make *config", so drivers should select it instead of > depending on it if they need it. > > Consistently using "select" or "depends on" can also help reduce > Kconfig circular dependency issues. > > REGMAP is selected 94 times and is depended on 11 times in > current linux-next. Eliminate the uses of "depends on" by > converting them to "select". Thank you for your work on this. Mixing of depends on vs select is a real problem with many Kconfig symbols. > [PATCH 1/8] ipmi: ASPEED_BT_IPMI_BMC: select REGMAP_MMIO instead of depending on it > [PATCH 2/8] clk: HI655X: select REGMAP instead of depending on it > [PATCH 3/8] gpio: GPIO_REGMAP: select REGMAP instead of depending on it > [PATCH 4/8] leds: TI_LMU_COMMON: select REGMAP instead of depending on it > [PATCH 5/8] platform: mellanox: select REGMAP instead of depending on it > [PATCH 6/8] platform: x86: MLX_PLATFORM: select REGMAP instead of depending on it > [PATCH 7/8] thermal: intel: BXT_PMIC: select REGMAP instead of depending on it > [PATCH 8/8] serial: 8250: ASPEED_VUART: select REGMAP instead of depending on it For patch 5/8 and 6/8, do you want me to merge them through the pdx86 (platform-drivers-x86) tree, or do you plan to merge this whole series in one go through some other tree? If you plan to merge the whole series through some other tree, here is my acked by for doing so for 5/8 and 6/8: Acked-by: Hans de Goede Regards, Hans > > diffstat: > drivers/char/ipmi/Kconfig | 3 ++- > drivers/clk/Kconfig | 2 +- > drivers/gpio/Kconfig | 2 +- > drivers/leds/Kconfig | 2 +- > drivers/platform/mellanox/Kconfig | 9 ++++----- > drivers/platform/x86/Kconfig | 3 ++- > drivers/thermal/intel/Kconfig | 3 ++- > drivers/tty/serial/8250/Kconfig | 3 ++- > 8 files changed, 15 insertions(+), 12 deletions(-) > > Cc: Andrew Jeffery > Cc: Corey Minyard > Cc: openipmi-developer@lists.sourceforge.net > Cc: Arnd Bergmann > Cc: Greg Kroah-Hartman > Cc: Riku Voipio > Cc: Stephen Boyd > Cc: Michael Turquette > Cc: linux-clk@vger.kernel.org > Cc: Michael Walle > Cc: Linus Walleij > Cc: Bartosz Golaszewski > Cc: linux-gpio@vger.kernel.org > Cc: Dan Murphy > Cc: Pavel Machek > Cc: Jacek Anaszewski > Cc: Lee Jones > Cc: linux-leds@vger.kernel.org > Cc: Darren Hart > Cc: Hans de Goede > Cc: Michael Shych > Cc: Mark Gross > Cc: Vadim Pasternak > Cc: platform-driver-x86@vger.kernel.org > Cc: Yegnesh S Iyer > Cc: Bin Gao > Cc: Zhang Rui > Cc: "Rafael J. Wysocki" > Cc: Daniel Lezcano > Cc: Amit Kucheria > Cc: linux-pm@vger.kernel.org > Cc: Oskar Senft > Cc: linux-serial@vger.kernel.org >