From: Markus Elfring <Markus.Elfring@web.de>
To: "Alvin Šipraga" <ALSI@bang-olufsen.dk>,
devicetree@vger.kernel.org, linux-sound@vger.kernel.org,
linux-i2c@vger.kernel.org, linux-gpio@vger.kernel.org,
linux-clk@vger.kernel.org, kernel-janitors@vger.kernel.org
Cc: LKML <linux-kernel@vger.kernel.org>,
"Alvin Šipraga" <alvin@pqrs.dk>,
"Emil Abildgaard Svendsen" <EMAS@bang-olufsen.dk>,
"Andi Shyti" <andi.shyti@kernel.org>,
"Bartosz Golaszewski" <brgl@bgdev.pl>,
"Conor Dooley" <conor+dt@kernel.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Jaroslav Kysela" <perex@perex.cz>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Mark Brown" <broonie@kernel.org>,
"Michael Turquette" <mturquette@baylibre.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Saravana Kannan" <saravanak@google.com>,
"Stephen Boyd" <sboyd@kernel.org>,
"Takashi Iwai" <tiwai@suse.com>
Subject: Re: [PATCH 01/13] a2b: add A2B driver core
Date: Tue, 21 May 2024 09:33:51 +0200 [thread overview]
Message-ID: <7ffeb91e-97b7-4f60-851e-120062b63c17@web.de> (raw)
In-Reply-To: <alv4rqrrnjqw3fb5vsw5r4f6lv7ymvuatcqovt7ddxi5ich5on@aan7wybzrzru>
>> …
>>> +++ b/drivers/a2b/a2b.c
>>> @@ -0,0 +1,1252 @@
>> …
>>> +static int a2b_bus_of_add_node(struct a2b_bus *bus, struct device_node *np,
>>> + unsigned int addr)
>>> +{
>> …
>>> + node = kzalloc(sizeof(*node), GFP_KERNEL);
>>> + if (IS_ERR(node))
>>> + return -ENOMEM;
>>
>> Please improve the distinction for checks according to the handling of error/null pointers.
>
> Right, I think it returns NULL on error.
Do you see possibilities to reduce “confusion” about the properties of such a programming interface
any further?
https://elixir.bootlin.com/linux/v6.9.1/A/ident/kzalloc
Regards,
Markus
next prev parent reply other threads:[~2024-05-21 7:34 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-17 12:57 [PATCH 00/13] Analog Devices Inc. Automotive Audio Bus (A2B) support Alvin Šipraga
2024-05-17 12:57 ` [PATCH 01/13] a2b: add A2B driver core Alvin Šipraga
2024-05-18 12:46 ` kernel test robot
2024-05-19 7:15 ` Markus Elfring
2024-05-19 7:33 ` Markus Elfring
2024-05-19 8:38 ` Markus Elfring
2024-05-21 7:11 ` Alvin Šipraga
2024-05-21 7:33 ` Markus Elfring [this message]
2024-05-21 7:37 ` Greg Kroah-Hartman
2024-05-19 11:18 ` Markus Elfring
2024-05-17 12:58 ` [PATCH 02/13] regmap: add A2B support Alvin Šipraga
2024-05-17 14:42 ` Mark Brown
2024-05-21 6:27 ` Alvin Šipraga
2024-05-21 10:43 ` Mark Brown
2024-05-17 12:58 ` [PATCH 03/13] dt-bindings: a2b: Analog Devices AD24xx devices Alvin Šipraga
2024-05-19 11:40 ` Krzysztof Kozlowski
2024-05-19 11:44 ` Krzysztof Kozlowski
2024-05-21 7:24 ` Alvin Šipraga
2024-05-21 7:47 ` Krzysztof Kozlowski
2024-05-17 12:58 ` [PATCH 04/13] a2b: add AD24xx I2C interface driver Alvin Šipraga
2024-05-17 14:49 ` Wolfram Sang
2024-05-21 8:31 ` Alvin Šipraga
2024-05-18 12:56 ` kernel test robot
2024-05-18 15:02 ` kernel test robot
2024-05-17 12:58 ` [PATCH 05/13] a2b: add AD24xx node driver Alvin Šipraga
2024-05-17 12:58 ` [PATCH 06/13] gpio: add AD24xx GPIO driver Alvin Šipraga
2024-05-22 15:31 ` Bartosz Golaszewski
2024-05-28 12:13 ` Linus Walleij
2024-05-28 20:02 ` Andy Shevchenko
2024-05-17 12:58 ` [PATCH 07/13] ASoC: codecs: add AD24xx codec driver Alvin Šipraga
2024-05-17 15:03 ` Mark Brown
2024-05-21 6:46 ` Alvin Šipraga
2024-05-21 7:08 ` Alvin Šipraga
2024-05-21 10:49 ` Mark Brown
2024-05-17 13:02 ` [PATCH 08/13] clk: add AD24xx clock driver Alvin Šipraga
2024-06-04 0:10 ` Stephen Boyd
2024-05-17 13:02 ` [PATCH 09/13] i2c: add AD24xx I2C controller driver Alvin Šipraga
2024-05-17 13:02 ` [PATCH 10/13] dt-bindings: vendor-prefixes: add Bang & Olufsen a/s Alvin Šipraga
2024-05-19 11:40 ` Krzysztof Kozlowski
2024-05-17 13:02 ` [PATCH 11/13] dt-bindings: a2b: add compatible string for Beosound Shape node Alvin Šipraga
2024-05-19 11:41 ` Krzysztof Kozlowski
2024-05-21 7:12 ` Alvin Šipraga
2024-05-21 7:32 ` Krzysztof Kozlowski
2024-05-17 13:02 ` [PATCH 12/13] a2b: add Beosound Shape node driver Alvin Šipraga
2024-05-17 13:02 ` [PATCH 13/13] MAINTAINERS: add maintainership for A2B drivers Alvin Šipraga
2024-05-17 14:57 ` [PATCH 00/13] Analog Devices Inc. Automotive Audio Bus (A2B) support Wolfram Sang
2024-05-21 7:08 ` Alvin Šipraga
2024-05-19 6:44 ` Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7ffeb91e-97b7-4f60-851e-120062b63c17@web.de \
--to=markus.elfring@web.de \
--cc=ALSI@bang-olufsen.dk \
--cc=EMAS@bang-olufsen.dk \
--cc=alvin@pqrs.dk \
--cc=andi.shyti@kernel.org \
--cc=brgl@bgdev.pl \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=perex@perex.cz \
--cc=rafael@kernel.org \
--cc=robh@kernel.org \
--cc=saravanak@google.com \
--cc=sboyd@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).