From: Kevin Hilman <khilman@baylibre.com>
To: "linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>
Cc: "A.s. Dong" <aisheng.dong@nxp.com>,
"dongas86@gmail.com" <dongas86@gmail.com>,
"martin@kaiser.cx" <martin@kaiser.cx>,
"linus.walleij@linaro.org" <linus.walleij@linaro.org>,
"stefan@agner.ch" <stefan@agner.ch>,
dl-linux-imx <linux-imx@nxp.com>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
Fabio Estevam <fabio.estevam@nxp.com>,
Leonard Crestez <leonard.crestez@nxp.com>,
"shawnguo@kernel.org" <shawnguo@kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 1/1] pinctrl: imx: fix NO_PAD_CTL setting for MMIO pads
Date: Wed, 14 Nov 2018 17:01:08 -0800 [thread overview]
Message-ID: <7hd0r7gnmz.fsf@eze.i-did-not-set--mail-host-address--so-tickle-me> (raw)
In-Reply-To: <1542036051-23840-1-git-send-email-aisheng.dong@nxp.com>
"A.s. Dong" <aisheng.dong@nxp.com> writes:
> After patch b96eea718bf6 ("pinctrl: fsl: add scu based pinctrl support"),
> NO_PAD_CTL pads map are not skipped anymore which results in
> a possible memory corruption. As we actually only need to create config
> maps for SCU pads and MMIO pads which are not using the default config
> (a.k.a IMX_NO_PAD_CTL), so let's add a proper check before creating
> the config maps. And during MMIO pads parsing, we also need update the
> list_p point as SCU case to ensure the pin data next parsed is correct.
>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Fixes: b96eea718bf6 ("pinctrl: fsl: add scu based pinctrl support")
> Reported-by: Martin Kaiser <martin@kaiser.cx>
> Suggested-by: Leonard Crestez <leonard.crestez@nxp.com>
> Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
After kernelCI found a similar failure, I verified that this patch gets
things booting again in today's linux-next.
Tested-by: Kevin Hilman <khilman@baylibre.com>
Kevin
next prev parent reply other threads:[~2018-11-15 1:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-12 15:25 [PATCH 1/1] pinctrl: imx: fix NO_PAD_CTL setting for MMIO pads A.s. Dong
2018-11-12 15:47 ` Martin Kaiser
2018-11-12 17:20 ` Leonard Crestez
2018-11-15 1:01 ` Kevin Hilman [this message]
2018-11-19 13:52 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7hd0r7gnmz.fsf@eze.i-did-not-set--mail-host-address--so-tickle-me \
--to=khilman@baylibre.com \
--cc=aisheng.dong@nxp.com \
--cc=dongas86@gmail.com \
--cc=fabio.estevam@nxp.com \
--cc=kernel@pengutronix.de \
--cc=leonard.crestez@nxp.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=martin@kaiser.cx \
--cc=shawnguo@kernel.org \
--cc=stefan@agner.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).