From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kevin Hilman Subject: Re: [PATCH v6 0/7] This is the 1st version of suspend for RK3288. Date: Wed, 29 Oct 2014 13:06:05 -0700 Message-ID: <7hppda7iaa.fsf@deeprootsystems.com> References: <1414583525-17395-1-git-send-email-zyw@rock-chips.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from mail-pa0-f44.google.com ([209.85.220.44]:44690 "EHLO mail-pa0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753043AbaJ2UGJ (ORCPT ); Wed, 29 Oct 2014 16:06:09 -0400 Received: by mail-pa0-f44.google.com with SMTP id bj1so3896520pad.3 for ; Wed, 29 Oct 2014 13:06:08 -0700 (PDT) In-Reply-To: <1414583525-17395-1-git-send-email-zyw@rock-chips.com> (Chris Zhong's message of "Wed, 29 Oct 2014 19:51:58 +0800") Sender: linux-gpio-owner@vger.kernel.org List-Id: linux-gpio@vger.kernel.org To: Chris Zhong Cc: heiko@sntech.de, dianders@chromium.org, mturquette@linaro.org, Ian Campbell , Russell King , Rob Herring , Pawel Moll , Mark Rutland , Linus Walleij , linux-rockchip@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Kumar Gala , devicetree@vger.kernel.org, Tony Xie , linux-arm-kernel@lists.infradead.org Hi Chris, Chris Zhong writes: > RK3288 can shut down the cpu, gpu and other device controllers in suspend, > and it will pull the GLOBAL_PWROFF pin to high in the final stage of the > process of suspend, pull the pin to low again when resume. I tried to test this on top of linux-next (next-20141029) and it doesn't wake up from serial port activity. Can you describe how to test this, as well as describe dependencies on other out-of-tree patches, including pointers to where they've been posted. Also, please describe how you tested this and on which hardware platforms. It's a big help to reviewers to know how it's been tested, and for anyone with similar hardware to know what else it's been tested on. Thanks, Kevin