From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="gwDj7eus" Received: from mail-ej1-x62b.google.com (mail-ej1-x62b.google.com [IPv6:2a00:1450:4864:20::62b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CE311D0 for ; Wed, 13 Dec 2023 11:19:13 -0800 (PST) Received: by mail-ej1-x62b.google.com with SMTP id a640c23a62f3a-a1f37fd4b53so903267566b.1 for ; Wed, 13 Dec 2023 11:19:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1702495152; x=1703099952; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=IyLZK0Q4UUy3edVFbbE5taYf3vBAb4m9JmdYBi1zuXg=; b=gwDj7eusDHBJPbfwk3JFlV8KgGUME4eAaY20GJuvK1aBurBEKc7nBbuSjoxxiNBViP 3IiVJZtnhktIJrgCExj26JiGBoD3bq63hZF9nvkmz7n9QeD1HI/01Jn5EZ70KAo3e+zU QV7XRGyZcMlJ3Ztmw9QJomrbeBBiQNu23a/C647Jj/NYL0w4oaY1i4G2/J5dPk66E6Mi idkCmr1Af+8zgMkwEpzqzedT4+r8UR4FtNg6CKUBtXbpo+XtN6jIBSFYPBCozOFFvp1M wrxatzZ7MklWAeH6D++Y4xVROl4aG0EntEZPTtOVnf3nFjPy1okUMN3pQkgm26Q1bOga OU1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702495152; x=1703099952; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=IyLZK0Q4UUy3edVFbbE5taYf3vBAb4m9JmdYBi1zuXg=; b=jADTGUaYzU96oWsCijHBZPP5cHNAsj/qNpDOP7UHXNqS/L9jTExFCPgwYIxl4dEp3S C98YfLb6t2hLz2JfxUvXUX7oMM6tyEl32HzX0KtuLwJcAfAlLlmywMf37eXnxhEy1ISD lg8Q7iYbJTqc9JYQueNNGieytXaaXCwwd7+GFd0cClmXdTw1iBZD+dYi7yT3u5q5kqRZ 2hd848E3KqnAYvvD0G548BG1w7anwyjRBqK243O+PGggbvbZdodc3slggFVxy80RNp5M 08VDCuWjytQ+Rd4m/ud6NkDOhe6BtWLRfuk8Rgm+K3gEw2TTWMEDN6awpy2nNwpC9Tox s3DA== X-Gm-Message-State: AOJu0YxTpb8zEEXJMJCmymxAAI/QPUPND+vvLKf3ZMBcv39mKW7sAXD3 etATAIND4T+TAsDXKX2zTkRFGg== X-Google-Smtp-Source: AGHT+IHe2oCpE5hoLsQtZOhOSa1CS6LxlkW89vAba1gSe/+elhIewojVPC1i7xpMFADBhxh+BtIu6w== X-Received: by 2002:a17:906:5346:b0:a02:a2cc:66b8 with SMTP id j6-20020a170906534600b00a02a2cc66b8mr4165386ejo.14.1702495152178; Wed, 13 Dec 2023 11:19:12 -0800 (PST) Received: from [192.168.1.20] ([178.197.218.27]) by smtp.gmail.com with ESMTPSA id vq6-20020a170907a4c600b00a19b7362dcfsm8330910ejc.139.2023.12.13.11.19.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 13 Dec 2023 11:19:11 -0800 (PST) Message-ID: <8099aabc-a98e-444b-862f-72845e03476d@linaro.org> Date: Wed, 13 Dec 2023 20:19:08 +0100 Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 11/16] watchdog: s3c2410_wdt: Update QUIRK macros to use BIT macro Content-Language: en-US To: Peter Griffin , Alim Akhtar Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, mturquette@baylibre.com, conor+dt@kernel.org, sboyd@kernel.org, tomasz.figa@gmail.com, s.nawrocki@samsung.com, linus.walleij@linaro.org, wim@linux-watchdog.org, linux@roeck-us.net, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, olof@lixom.net, gregkh@linuxfoundation.org, jirislaby@kernel.org, cw00.choi@samsung.com, tudor.ambarus@linaro.org, andre.draszik@linaro.org, semen.protsenko@linaro.org, saravanak@google.com, willmcvicker@google.com, soc@kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org, linux-watchdog@vger.kernel.org, kernel-team@android.com, linux-serial@vger.kernel.org References: <20231211162331.435900-1-peter.griffin@linaro.org> <20231211162331.435900-12-peter.griffin@linaro.org> <017401da2de2$400ec6e0$c02c54a0$@samsung.com> From: Krzysztof Kozlowski Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 13/12/2023 20:13, Peter Griffin wrote: > Hi Alim, > > Thanks for your reviews. > > On Wed, 13 Dec 2023 at 16:34, Alim Akhtar wrote: >> >> >> >>> -----Original Message----- >>> From: Peter Griffin >>> Sent: Monday, December 11, 2023 9:53 PM >>> To: robh+dt@kernel.org; krzysztof.kozlowski+dt@linaro.org; >>> mturquette@baylibre.com; conor+dt@kernel.org; sboyd@kernel.org; >>> tomasz.figa@gmail.com; s.nawrocki@samsung.com; linus.walleij@linaro.org; >>> wim@linux-watchdog.org; linux@roeck-us.net; catalin.marinas@arm.com; >>> will@kernel.org; arnd@arndb.de; olof@lixom.net; >>> gregkh@linuxfoundation.org; jirislaby@kernel.org; >>> cw00.choi@samsung.com; alim.akhtar@samsung.com >>> Cc: peter.griffin@linaro.org; tudor.ambarus@linaro.org; >>> andre.draszik@linaro.org; semen.protsenko@linaro.org; >>> saravanak@google.com; willmcvicker@google.com; soc@kernel.org; >>> devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux- >>> samsung-soc@vger.kernel.org; linux-clk@vger.kernel.org; linux- >>> gpio@vger.kernel.org; linux-watchdog@vger.kernel.org; kernel- >>> team@android.com; linux-serial@vger.kernel.org >>> Subject: [PATCH v7 11/16] watchdog: s3c2410_wdt: Update QUIRK macros to >>> use BIT macro >>> >>> Update the remaining QUIRK macros to use the BIT macro. >>> >> Ah! I see you have change use BIT here, so you can squash this patch to >> patch 10/16 or >> Move BIT change from patch 10/16 to this patch. Either way is fine. > > I actually kept them separate deliberately to avoid conflating adding > of the DBGACK quirk with cleanup of the driver to use BIT macro. > > As such one patch adds the QUIRK and only updates the macros that were > touched by that patch (to avoid the --strict warnings), and the second > patch cleans up the rest of the macros to use BIT macro for > consistency. Yeah, the defines are from existing code, so not really related to GS101 patch. Keeping it as separate cleanup is fine. Best regards, Krzysztof