From: Markus Elfring <Markus.Elfring@web.de>
To: Szuying Chen <Chloe_Chen@asmedia.com.tw>,
YD Tseng <Yd_Tseng@asmedia.com.tw>,
linux-gpio@vger.kernel.org, Bartosz Golaszewski <brgl@kernel.org>,
Linus Walleij <linusw@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Jesse Chang <Jesse1_Chang@asmedia.com.tw>,
Richard Hsu <Richard_Hsu@asmedia.com.tw>
Subject: Re: [PATCH v2] gpio: amdptpci: add support for AMD PT PCI controller
Date: Tue, 13 Oct 2026 10:48:44 +0200 [thread overview]
Message-ID: <80aea221-af95-4367-aa39-50845bf5abe0@web.de> (raw)
In-Reply-To: <20261013074327.4961-1-Chloe_Chen@asmedia.com.tw>
> This commit implements the new gpio-amdptpci driver to support the
…
See also:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v7.3-rc7#n94
> Signed-off-by: Szuying Chen <Chloe_Chen@asmedia.com.tw>
> Co-authored-by: YD Tseng <Yd_Tseng@asmedia.com.tw>
See also:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v7.3-rc7#n502
> v1->v2:
…
> ---
…
> drivers/gpio/gpio-amdptpci.c | 891 +++++++++++++++++++++++++++++++++++
Please move patch version descriptions behind the marker line.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v7.3-rc7#n793
…
> +++ b/drivers/gpio/gpio-amdptpci.c
> @@ -0,0 +1,891 @@
…
> +static int pt27_gpio_get_direction(struct gpio_chip *gc, unsigned int offset)
> +{
…
> + raw_spin_lock_irqsave(&chip->lock, flags);
> + val = pt27_rd32(chip, PT27_REG_DIR);
> + raw_spin_unlock_irqrestore(&chip->lock, flags);
…
Under which circumstances would you become interested to apply a statement
like “guard(raw_spinlock_irqsave)(&chip->lock);”?
https://elixir.bootlin.com/linux/v7.3-rc6/source/include/linux/spinlock.h#L594-L597
Regards,
Markus
next prev parent reply other threads:[~2026-10-13 8:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-13 7:43 [PATCH v2] gpio: amdptpci: add support for AMD PT PCI controller Szuying Chen
2026-10-13 7:56 ` sashiko-bot
2026-10-13 8:48 ` Markus Elfring [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-10-13 8:16 Szuying Chen
2026-10-13 8:30 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=80aea221-af95-4367-aa39-50845bf5abe0@web.de \
--to=markus.elfring@web.de \
--cc=Chloe_Chen@asmedia.com.tw \
--cc=Jesse1_Chang@asmedia.com.tw \
--cc=Richard_Hsu@asmedia.com.tw \
--cc=Yd_Tseng@asmedia.com.tw \
--cc=brgl@kernel.org \
--cc=linusw@kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox