linux-gpio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Heiko Stübner" <heiko@sntech.de>
To: linus.walleij@linaro.org, Jianqun Xu <jay.xu@rock-chips.com>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
	linux-gpio@vger.kernel.org, linux-rockchip@lists.infradead.org,
	Jianqun Xu <jay.xu@rock-chips.com>
Subject: Re: [PATCH 1/2] dt-bindings: gpio: rockchip: add clock-names
Date: Wed, 07 Sep 2022 16:32:49 +0200	[thread overview]
Message-ID: <8119974.jRhZ6ZUK3Y@diego> (raw)
In-Reply-To: <20220902060426.2980951-2-jay.xu@rock-chips.com>

Am Freitag, 2. September 2022, 08:04:25 CEST schrieb Jianqun Xu:
> Add 'clock-names' to the gpio dt node. so the driver could get clocks by
> a const char id, this patch names the clock-names as
>   - 'bus': the apb clock for cpu to access the gpio controller
>   - 'db': the debounce clock for cpu to set debounce clock rate
> 
> Since the old dt nodes may have no clock-names, this patch not make them
> as part of 'required properties'.
> 
> Signed-off-by: Jianqun Xu <jay.xu@rock-chips.com>

Acked-by: Heiko Stuebner <heiko@sntech.de>

> ---
>  .../devicetree/bindings/gpio/rockchip,gpio-bank.yaml        | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/gpio/rockchip,gpio-bank.yaml b/Documentation/devicetree/bindings/gpio/rockchip,gpio-bank.yaml
> index affd823c881d..d43d4c71bebf 100644
> --- a/Documentation/devicetree/bindings/gpio/rockchip,gpio-bank.yaml
> +++ b/Documentation/devicetree/bindings/gpio/rockchip,gpio-bank.yaml
> @@ -27,6 +27,12 @@ properties:
>        - description: APB interface clock source
>        - description: GPIO debounce reference clock source
>  
> +  clock-names:
> +    minItems: 1
> +    items:
> +      - const: bus
> +      - const: db
> +
>    gpio-ranges: true
>  
>    gpio-controller: true
> 





  parent reply	other threads:[~2022-09-07 14:34 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-02  6:04 [PATCH 0/2] gpio clock-names Jianqun Xu
2022-09-02  6:04 ` [PATCH 1/2] dt-bindings: gpio: rockchip: add clock-names Jianqun Xu
2022-09-02 21:05   ` Rob Herring
2022-09-07 12:24   ` Krzysztof Kozlowski
2022-09-07 14:32   ` Heiko Stübner [this message]
2022-09-02  6:04 ` [PATCH 2/2] arm64: dts: rockchip: rk356x add 'clock-names' for gpio nodes Jianqun Xu
  -- strict thread matches above, loose matches on Subject: below --
2022-09-01  1:30 [PATCH 0/2] gpio clock-names Jianqun Xu
2022-09-01  1:31 ` [PATCH 1/2] dt-bindings: gpio: rockchip: add clock-names Jianqun Xu
2022-09-08 10:58   ` Krzysztof Kozlowski
2022-09-01  1:29 [PATCH 0/2] gpio clock-names Jianqun Xu
2022-09-01  1:29 ` [PATCH 1/2] dt-bindings: gpio: rockchip: add clock-names Jianqun Xu
2022-09-01 11:48   ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8119974.jRhZ6ZUK3Y@diego \
    --to=heiko@sntech.de \
    --cc=devicetree@vger.kernel.org \
    --cc=jay.xu@rock-chips.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).