From: Heiner Kallweit <hkallweit1@gmail.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: "linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>
Subject: Regression caused by a603a2b8d86e "gpio: of: Add special quirk to parse regulator flags"
Date: Tue, 16 Jan 2018 21:49:17 +0100 [thread overview]
Message-ID: <814e4459-39ef-8397-709b-858bf5564212@gmail.com> (raw)
With the latest next kernel I get a NPE caused by mentioned commit.
The change doesn't consider that the flags parameter can be NULL,
e.g. of_get_named_gpio() sets it to NULL.
All that of_gpio_flags_quirks() does is adjusting the flags,
so the following simple change fixed the issue for me.
if (flags)
of_gpio_flags_quirks(np, flags);
next reply other threads:[~2018-01-16 20:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-16 20:49 Heiner Kallweit [this message]
2018-01-16 22:49 ` Regression caused by a603a2b8d86e "gpio: of: Add special quirk to parse regulator flags" Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=814e4459-39ef-8397-709b-858bf5564212@gmail.com \
--to=hkallweit1@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox