From: Nicolas Ferre <nicolas.ferre@microchip.com>
To: <Ryan.Wanner@microchip.com>, <robh+dt@kernel.org>,
<krzysztof.kozlowski+dt@linaro.org>, <conor+dt@kernel.org>,
<alexandre.belloni@bootlin.com>, <claudiu.beznea@microchip.com>,
<linus.walleij@linaro.org>, <ludovic.desroches@microchip.com>
Cc: <devicetree@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <linux-gpio@vger.kernel.org>
Subject: Re: [PATCH 3/3] ARM: dts: at91: Return to boolean properties
Date: Mon, 22 May 2023 11:22:02 +0200 [thread overview]
Message-ID: <8241a7ed-6c02-df96-fdcf-39339f50a6e0@microchip.com> (raw)
In-Reply-To: <6f06be9e393c02563bc877498c8af75daf3b47f8.1684313910.git.Ryan.Wanner@microchip.com>
On 17/05/2023 at 13:54, Ryan.Wanner@microchip.com wrote:
> From: Ryan Wanner <Ryan.Wanner@microchip.com>
>
> Returning back to commit 0dc23d1a8e17
> ("arm: dts: at91: Fix boolean properties with values") as pinctrl driver no
> longer expects an integer value and expects a simple boolean property.
>
> Signed-off-by: Ryan Wanner <Ryan.Wanner@microchip.com>
Okay:
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
Thanks for fixing this as well. Best regards,
Nicolas
> ---
> arch/arm/boot/dts/at91-kizbox3-hs.dts | 2 +-
> arch/arm/boot/dts/at91-kizbox3_common.dtsi | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/at91-kizbox3-hs.dts b/arch/arm/boot/dts/at91-kizbox3-hs.dts
> index 7075df6549e9..fec7269088d1 100644
> --- a/arch/arm/boot/dts/at91-kizbox3-hs.dts
> +++ b/arch/arm/boot/dts/at91-kizbox3-hs.dts
> @@ -225,7 +225,7 @@ pinctrl_pio_zbe_rst: gpio_zbe_rst {
> pinctrl_pio_io_reset: gpio_io_reset {
> pinmux = <PIN_PB30__GPIO>;
> bias-disable;
> - drive-open-drain = <1>;
> + drive-open-drain;
> output-low;
> };
> pinctrl_pio_input: gpio_input {
> diff --git a/arch/arm/boot/dts/at91-kizbox3_common.dtsi b/arch/arm/boot/dts/at91-kizbox3_common.dtsi
> index abe27adfa4d6..465664628419 100644
> --- a/arch/arm/boot/dts/at91-kizbox3_common.dtsi
> +++ b/arch/arm/boot/dts/at91-kizbox3_common.dtsi
> @@ -211,7 +211,7 @@ pinctrl_flx4_default: flx4_i2c6_default {
> pinmux = <PIN_PD12__FLEXCOM4_IO0>, //DATA
> <PIN_PD13__FLEXCOM4_IO1>; //CLK
> bias-disable;
> - drive-open-drain = <1>;
> + drive-open-drain;
> };
>
> pinctrl_pwm0 {
--
Nicolas Ferre
next prev parent reply other threads:[~2023-05-22 9:22 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-17 11:54 [PATCH 0/3] AT91 PIO4 push-pull enable Ryan.Wanner
2023-05-17 11:54 ` [PATCH 1/3] pinctrl: at91-pio4: Enable Push-Pull configuration Ryan.Wanner
2023-05-18 5:40 ` Claudiu.Beznea
2023-05-18 5:54 ` Claudiu.Beznea
2023-05-22 9:18 ` Nicolas Ferre
2023-05-23 16:27 ` andy.shevchenko
2023-05-24 8:50 ` Linus Walleij
2023-05-17 11:54 ` [PATCH 2/3] dt-bindings: pinctrl: at91-pio4: Add push-pull support Ryan.Wanner
2023-05-17 17:38 ` Conor Dooley
2023-05-17 17:50 ` Conor Dooley
2023-05-22 9:18 ` Nicolas Ferre
2023-05-24 8:50 ` Linus Walleij
2023-05-17 11:54 ` [PATCH 3/3] ARM: dts: at91: Return to boolean properties Ryan.Wanner
2023-05-22 9:22 ` Nicolas Ferre [this message]
2023-05-23 5:05 ` Claudiu.Beznea
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8241a7ed-6c02-df96-fdcf-39339f50a6e0@microchip.com \
--to=nicolas.ferre@microchip.com \
--cc=Ryan.Wanner@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=claudiu.beznea@microchip.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ludovic.desroches@microchip.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).