From: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com
Subject: Re: [PATCH] gpio: (gpio-pca953x) move header to linux/platform_data/
Date: Fri, 16 Aug 2013 11:02:20 -0400 (EDT) [thread overview]
Message-ID: <82440653.410050.1376665340121.JavaMail.root@mail> (raw)
In-Reply-To: <CACRpkdZdeVNtJSmc6Lr6j=oO9FLsAvjyrwhYS0j4OoAEhxCN9g@mail.gmail.com>
Hi Linus,
You wrote:
> But:
>
> > drivers/gpio/gpio-pca953x.c | 2 +-
> (...)
> > diff --git a/drivers/gpio/gpio-pca953x.c
> > b/drivers/gpio/gpio-pca953x.c
> > index 426c51d..8804aec 100644
> > --- a/drivers/gpio/gpio-pca953x.c
> > +++ b/drivers/gpio/gpio-pca953x.c
> > @@ -18,7 +18,7 @@
> > #include <linux/irq.h>
> > #include <linux/irqdomain.h>
> > #include <linux/i2c.h>
> > -#include <linux/i2c/pca953x.h>
> > +#include <linux/platform_data/pca953x.h>
>
> Why does the GPIO driver need platform data from the
> I2C driver???
>
> Can't this just be made to go away?
I didn't dig that much in the driver, but I cannot imagine
another way to pass, for instance, the setup callback.
What would be a good alternative for you?
Regards,
Vivien
next prev parent reply other threads:[~2013-08-16 15:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1375304231-27281-1-git-send-email-vivien.didelot@savoirfairelinux.com>
2013-08-16 13:34 ` [PATCH] gpio: (gpio-pca953x) move header to linux/platform_data/ Linus Walleij
2013-08-16 15:02 ` Vivien Didelot [this message]
2013-08-16 15:42 ` Linus Walleij
2013-08-16 19:06 ` H Hartley Sweeten
2013-08-29 17:52 ` Vivien Didelot
2013-08-29 18:00 ` Olof Johansson
2013-08-29 18:46 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=82440653.410050.1376665340121.JavaMail.root@mail \
--to=vivien.didelot@savoirfairelinux.com \
--cc=kernel@savoirfairelinux.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).