Re: [PATCH] gpio: (gpio-pca953x) move header to linux/platform_data/

Re: [PATCH] gpio: (gpio-pca953x) move header to linux/platform_data/

[Linus Walleij]

On Wed, Jul 31, 2013 at 10:57 PM, Vivien Didelot
<vivien.didelot@savoirfairelinux.com> wrote:

> This patch moves the pca953x.h header from include/linux/i2c to
> include/linux/platform_data and updates existing support accordingly.
>
> Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>

On the concept:
Acked-by: Linus Walleij <linus.walleij@linaro.org>

But:

>  drivers/gpio/gpio-pca953x.c                 |  2 +-
(...)
> diff --git a/drivers/gpio/gpio-pca953x.c b/drivers/gpio/gpio-pca953x.c
> index 426c51d..8804aec 100644
> --- a/drivers/gpio/gpio-pca953x.c
> +++ b/drivers/gpio/gpio-pca953x.c
> @@ -18,7 +18,7 @@
>  #include <linux/irq.h>
>  #include <linux/irqdomain.h>
>  #include <linux/i2c.h>
> -#include <linux/i2c/pca953x.h>
> +#include <linux/platform_data/pca953x.h>

Why does the GPIO driver need platform data from the
I2C driver???

Can't this just be made to go away?

Yours,
Linus Walleij

Re: [PATCH] gpio: (gpio-pca953x) move header to linux/platform_data/

[Vivien Didelot]

Hi Linus,

You wrote:
> But:
> 
> >  drivers/gpio/gpio-pca953x.c                 |  2 +-
> (...)
> > diff --git a/drivers/gpio/gpio-pca953x.c
> > b/drivers/gpio/gpio-pca953x.c
> > index 426c51d..8804aec 100644
> > --- a/drivers/gpio/gpio-pca953x.c
> > +++ b/drivers/gpio/gpio-pca953x.c
> > @@ -18,7 +18,7 @@
> >  #include <linux/irq.h>
> >  #include <linux/irqdomain.h>
> >  #include <linux/i2c.h>
> > -#include <linux/i2c/pca953x.h>
> > +#include <linux/platform_data/pca953x.h>
> 
> Why does the GPIO driver need platform data from the
> I2C driver???
> 
> Can't this just be made to go away?

I didn't dig that much in the driver, but I cannot imagine
another way to pass, for instance, the setup callback.

What would be a good alternative for you?

Regards,
Vivien

Re: [PATCH] gpio: (gpio-pca953x) move header to linux/platform_data/

[Linus Walleij]

On Fri, Aug 16, 2013 at 5:02 PM, Vivien Didelot
<vivien.didelot@savoirfairelinux.com> wrote:

>> Why does the GPIO driver need platform data from the
>> I2C driver???
>>
>> Can't this just be made to go away?
>
> I didn't dig that much in the driver, but I cannot imagine
> another way to pass, for instance, the setup callback.

Hm so this is some combined platform data for I2C *and* GPIO?

Hmm ugly, but OK then.
Acked-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij

RE: [PATCH] gpio: (gpio-pca953x) move header to linux/platform_data/

[H Hartley Sweeten]

On Friday, August 16, 2013 8:02 AM, Vivien Didelot wrote:
> Hi Linus,
>
> You wrote:
> > But:
>>
>>>  drivers/gpio/gpio-pca953x.c                 |  2 +-
>> (...)
>>> diff --git a/drivers/gpio/gpio-pca953x.c
>>> b/drivers/gpio/gpio-pca953x.c
>>> index 426c51d..8804aec 100644
>>> --- a/drivers/gpio/gpio-pca953x.c
>>> +++ b/drivers/gpio/gpio-pca953x.c
>>> @@ -18,7 +18,7 @@
>>>  #include <linux/irq.h>
>>>  #include <linux/irqdomain.h>
>>>  #include <linux/i2c.h>
>>> -#include <linux/i2c/pca953x.h>
>>> +#include <linux/platform_data/pca953x.h>
>> 
>> Why does the GPIO driver need platform data from the
>> I2C driver???
>> 
>> Can't this just be made to go away?
>
> I didn't dig that much in the driver, but I cannot imagine
> another way to pass, for instance, the setup callback.
>
> What would be a good alternative for you?

I think the confusion here is because the pca953x.h header was initially
placed in linux/i2c.

This device is an I2C connected GPIO expander. The pca953x.h header has
the information needed for the platform to hook up to the device. It doesn't
really expose the fact that it's an I2C driver.

Just by 2 cents...
Hartley

Re: [PATCH] gpio: (gpio-pca953x) move header to linux/platform_data/

[Vivien Didelot]

As this patch mainly touches arch/arm/*, Olof/Kevin, would you mind
applying it?

The first message in thread is here: https://lkml.org/lkml/2013/7/31/552
Here are the previous ACKs:

Acked-by: Linus Walleij <linus.walleij@linaro.org>
Acked-by: H Hartley Sweeten <hsweeten@visionengravers.com>

Regards,
Vivien

Re: [PATCH] gpio: (gpio-pca953x) move header to linux/platform_data/

[Olof Johansson]

On Thu, Aug 29, 2013 at 01:52:58PM -0400, Vivien Didelot wrote:
> As this patch mainly touches arch/arm/*, Olof/Kevin, would you mind
> applying it?
> 
> The first message in thread is here: https://lkml.org/lkml/2013/7/31/552
> Here are the previous ACKs:
> 
> Acked-by: Linus Walleij <linus.walleij@linaro.org>
> Acked-by: H Hartley Sweeten <hsweeten@visionengravers.com>

Looks like i2c or gpio maintainers should be taking it, but since Linus acked
it instead of applied it, I guess we can take it. :)

I'll apply it to next/cleanup for 3.12 if you resend me the patch with the
acks. Thanks!


-Olof

Re: [PATCH] gpio: (gpio-pca953x) move header to linux/platform_data/

[Linus Walleij]

On Thu, Aug 29, 2013 at 8:00 PM, Olof Johansson <olof@lixom.net> wrote:
> On Thu, Aug 29, 2013 at 01:52:58PM -0400, Vivien Didelot wrote:
>> As this patch mainly touches arch/arm/*, Olof/Kevin, would you mind
>> applying it?
>>
>> The first message in thread is here: https://lkml.org/lkml/2013/7/31/552
>> Here are the previous ACKs:
>>
>> Acked-by: Linus Walleij <linus.walleij@linaro.org>
>> Acked-by: H Hartley Sweeten <hsweeten@visionengravers.com>
>
> Looks like i2c or gpio maintainers should be taking it, but since Linus acked
> it instead of applied it, I guess we can take it. :)
>
> I'll apply it to next/cleanup for 3.12 if you resend me the patch with the
> acks. Thanks!

Thanks a lot Olof, I worried about all the hunks hitting the arch/arm/*
hierarchy, and not much is happening in drivers/gpio this cycle
so think it is better off in ARM SoC.

Yours,
Linus Walleij