* [PATCH v2] pinctrl/meson: fix typo in PDM's pin name
@ 2024-03-25 11:30 Jan Dakinevich
2024-03-25 13:59 ` Neil Armstrong
2024-03-28 9:43 ` Linus Walleij
0 siblings, 2 replies; 3+ messages in thread
From: Jan Dakinevich @ 2024-03-25 11:30 UTC (permalink / raw)
To: Jan Dakinevich, Linus Walleij, Neil Armstrong, Kevin Hilman,
Jerome Brunet, Martin Blumenstingl, linux-gpio, linux-arm-kernel,
linux-amlogic, linux-kernel
Other pins have _a or _x suffix, but this one doesn't have any. Most
likely this is a typo.
Fixes: dabad1ff8561 ("pinctrl: meson: add pinctrl driver support for Meson-A1 SoC")
Signed-off-by: Jan Dakinevich <jan.dakinevich@salutedevices.com>
---
Links:
[1] https://lore.kernel.org/lkml/20240314232201.2102178-1-jan.dakinevich@salutedevices.com/
Changes:
v1 -> v2: Detached from v1's series (patch 15)
drivers/pinctrl/meson/pinctrl-meson-a1.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/pinctrl/meson/pinctrl-meson-a1.c b/drivers/pinctrl/meson/pinctrl-meson-a1.c
index 79f5d753d7e1..50a87d9618a8 100644
--- a/drivers/pinctrl/meson/pinctrl-meson-a1.c
+++ b/drivers/pinctrl/meson/pinctrl-meson-a1.c
@@ -250,7 +250,7 @@ static const unsigned int pdm_dclk_x_pins[] = { GPIOX_10 };
static const unsigned int pdm_din2_a_pins[] = { GPIOA_6 };
static const unsigned int pdm_din1_a_pins[] = { GPIOA_7 };
static const unsigned int pdm_din0_a_pins[] = { GPIOA_8 };
-static const unsigned int pdm_dclk_pins[] = { GPIOA_9 };
+static const unsigned int pdm_dclk_a_pins[] = { GPIOA_9 };
/* gen_clk */
static const unsigned int gen_clk_x_pins[] = { GPIOX_7 };
@@ -591,7 +591,7 @@ static struct meson_pmx_group meson_a1_periphs_groups[] = {
GROUP(pdm_din2_a, 3),
GROUP(pdm_din1_a, 3),
GROUP(pdm_din0_a, 3),
- GROUP(pdm_dclk, 3),
+ GROUP(pdm_dclk_a, 3),
GROUP(pwm_c_a, 3),
GROUP(pwm_b_a, 3),
@@ -755,7 +755,7 @@ static const char * const spi_a_groups[] = {
static const char * const pdm_groups[] = {
"pdm_din0_x", "pdm_din1_x", "pdm_din2_x", "pdm_dclk_x", "pdm_din2_a",
- "pdm_din1_a", "pdm_din0_a", "pdm_dclk",
+ "pdm_din1_a", "pdm_din0_a", "pdm_dclk_a",
};
static const char * const gen_clk_groups[] = {
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] pinctrl/meson: fix typo in PDM's pin name
2024-03-25 11:30 [PATCH v2] pinctrl/meson: fix typo in PDM's pin name Jan Dakinevich
@ 2024-03-25 13:59 ` Neil Armstrong
2024-03-28 9:43 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Neil Armstrong @ 2024-03-25 13:59 UTC (permalink / raw)
To: Jan Dakinevich, Linus Walleij, Kevin Hilman, Jerome Brunet,
Martin Blumenstingl, linux-gpio, linux-arm-kernel, linux-amlogic,
linux-kernel
On 25/03/2024 12:30, Jan Dakinevich wrote:
> Other pins have _a or _x suffix, but this one doesn't have any. Most
> likely this is a typo.
>
> Fixes: dabad1ff8561 ("pinctrl: meson: add pinctrl driver support for Meson-A1 SoC")
> Signed-off-by: Jan Dakinevich <jan.dakinevich@salutedevices.com>
> ---
> Links:
>
> [1] https://lore.kernel.org/lkml/20240314232201.2102178-1-jan.dakinevich@salutedevices.com/
>
> Changes:
> v1 -> v2: Detached from v1's series (patch 15)
>
> drivers/pinctrl/meson/pinctrl-meson-a1.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/pinctrl/meson/pinctrl-meson-a1.c b/drivers/pinctrl/meson/pinctrl-meson-a1.c
> index 79f5d753d7e1..50a87d9618a8 100644
> --- a/drivers/pinctrl/meson/pinctrl-meson-a1.c
> +++ b/drivers/pinctrl/meson/pinctrl-meson-a1.c
> @@ -250,7 +250,7 @@ static const unsigned int pdm_dclk_x_pins[] = { GPIOX_10 };
> static const unsigned int pdm_din2_a_pins[] = { GPIOA_6 };
> static const unsigned int pdm_din1_a_pins[] = { GPIOA_7 };
> static const unsigned int pdm_din0_a_pins[] = { GPIOA_8 };
> -static const unsigned int pdm_dclk_pins[] = { GPIOA_9 };
> +static const unsigned int pdm_dclk_a_pins[] = { GPIOA_9 };
>
> /* gen_clk */
> static const unsigned int gen_clk_x_pins[] = { GPIOX_7 };
> @@ -591,7 +591,7 @@ static struct meson_pmx_group meson_a1_periphs_groups[] = {
> GROUP(pdm_din2_a, 3),
> GROUP(pdm_din1_a, 3),
> GROUP(pdm_din0_a, 3),
> - GROUP(pdm_dclk, 3),
> + GROUP(pdm_dclk_a, 3),
> GROUP(pwm_c_a, 3),
> GROUP(pwm_b_a, 3),
>
> @@ -755,7 +755,7 @@ static const char * const spi_a_groups[] = {
>
> static const char * const pdm_groups[] = {
> "pdm_din0_x", "pdm_din1_x", "pdm_din2_x", "pdm_dclk_x", "pdm_din2_a",
> - "pdm_din1_a", "pdm_din0_a", "pdm_dclk",
> + "pdm_din1_a", "pdm_din0_a", "pdm_dclk_a",
> };
>
> static const char * const gen_clk_groups[] = {
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] pinctrl/meson: fix typo in PDM's pin name
2024-03-25 11:30 [PATCH v2] pinctrl/meson: fix typo in PDM's pin name Jan Dakinevich
2024-03-25 13:59 ` Neil Armstrong
@ 2024-03-28 9:43 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2024-03-28 9:43 UTC (permalink / raw)
To: Jan Dakinevich
Cc: Neil Armstrong, Kevin Hilman, Jerome Brunet, Martin Blumenstingl,
linux-gpio, linux-arm-kernel, linux-amlogic, linux-kernel
On Mon, Mar 25, 2024 at 12:32 PM Jan Dakinevich
<jan.dakinevich@salutedevices.com> wrote:
> Other pins have _a or _x suffix, but this one doesn't have any. Most
> likely this is a typo.
>
> Fixes: dabad1ff8561 ("pinctrl: meson: add pinctrl driver support for Meson-A1 SoC")
> Signed-off-by: Jan Dakinevich <jan.dakinevich@salutedevices.com>
Patch applied for fixes!
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-03-28 9:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-03-25 11:30 [PATCH v2] pinctrl/meson: fix typo in PDM's pin name Jan Dakinevich
2024-03-25 13:59 ` Neil Armstrong
2024-03-28 9:43 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).