From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: "Lorenzo Bianconi" <lorenzo@kernel.org>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Sean Wang" <sean.wang@kernel.org>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"Lee Jones" <lee@kernel.org>,
"Uwe Kleine-König" <ukleinek@kernel.org>
Cc: linux-mediatek@lists.infradead.org, linux-gpio@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
upstream@airoha.com, benjamin.larsson@genexis.eu,
ansuelsmth@gmail.com, linux-pwm@vger.kernel.org
Subject: Re: [PATCH v7 3/6] dt-bindings: pwm: airoha: Add EN7581 pwm
Date: Wed, 16 Oct 2024 12:20:50 +0200 [thread overview]
Message-ID: <834bfc12-4ce7-4ce1-a0c7-5bc8be3587b7@collabora.com> (raw)
In-Reply-To: <20241016-en7581-pinctrl-v7-3-4ff611f263a7@kernel.org>
Il 16/10/24 12:07, Lorenzo Bianconi ha scritto:
> Introduce device-tree binding documentation for Airoha EN7581 pwm
> controller.
>
> Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
> Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
> ---
> .../devicetree/bindings/pwm/airoha,en7581-pwm.yaml | 34 ++++++++++++++++++++++
> 1 file changed, 34 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/pwm/airoha,en7581-pwm.yaml b/Documentation/devicetree/bindings/pwm/airoha,en7581-pwm.yaml
> new file mode 100644
> index 0000000000000000000000000000000000000000..f36387572a9781636aeacdbcc8947017c7ca75a0
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/pwm/airoha,en7581-pwm.yaml
> @@ -0,0 +1,34 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/pwm/airoha,en7581-pwm.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Airoha EN7581 PWM Controller
> +
> +maintainers:
> + - Lorenzo Bianconi <lorenzo@kernel.org>
> +
> +allOf:
> + - $ref: pwm.yaml#
> +
> +properties:
> + compatible:
> + const: airoha,en7581-pwm
> +
> + "#pwm-cells":
> + const: 3
> +
> +required:
> + - compatible
> + - "#pwm-cells"
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + pwm {
> + compatible = "airoha,en7581-pwm";
> +
> + #pwm-cells = <3>;
> + };
>
There are undocumented properties that the driver tries to parse. Please fix.
Regards,
Angelo
next prev parent reply other threads:[~2024-10-16 10:20 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-16 10:07 [PATCH v7 0/6] Add mfd, pinctrl and pwm support to EN7581 SoC Lorenzo Bianconi
2024-10-16 10:07 ` [PATCH v7 1/6] dt-bindings: arm: airoha: Add the chip-scu node for " Lorenzo Bianconi
2024-10-16 10:07 ` [PATCH v7 2/6] dt-bindings: pinctrl: airoha: Add EN7581 pinctrl Lorenzo Bianconi
2024-10-16 10:07 ` [PATCH v7 3/6] dt-bindings: pwm: airoha: Add EN7581 pwm Lorenzo Bianconi
2024-10-16 10:20 ` AngeloGioacchino Del Regno [this message]
2024-10-17 14:28 ` Lorenzo Bianconi
2024-10-16 10:07 ` [PATCH v7 4/6] dt-bindings: mfd: Add support for Airoha EN7581 GPIO System Controller Lorenzo Bianconi
2024-10-16 10:26 ` AngeloGioacchino Del Regno
2024-10-16 10:07 ` [PATCH v7 5/6] pinctrl: airoha: Add support for EN7581 SoC Lorenzo Bianconi
2024-10-16 10:27 ` AngeloGioacchino Del Regno
2024-10-16 10:07 ` [PATCH v7 6/6] pwm: " Lorenzo Bianconi
2024-10-16 10:25 ` AngeloGioacchino Del Regno
2024-10-16 15:28 ` Christian Marangi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=834bfc12-4ce7-4ce1-a0c7-5bc8be3587b7@collabora.com \
--to=angelogioacchino.delregno@collabora.com \
--cc=ansuelsmth@gmail.com \
--cc=benjamin.larsson@genexis.eu \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lee@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pwm@vger.kernel.org \
--cc=lorenzo@kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=robh@kernel.org \
--cc=sean.wang@kernel.org \
--cc=ukleinek@kernel.org \
--cc=upstream@airoha.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).