From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CCBC2549382 for ; Tue, 8 Sep 2026 13:02:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788872585; cv=none; b=PR2lXj8yNVkOxcIPEV8r6OFBRsiBtfZbpM1JPXkY/8lguWaYAfBSU38QxDxasKYnQ/NOWjRxu4eBLvoYqtxN3jXspiXJD/6tJhPMnRIzC7EbzzvJiZD2ormJE2iG9K2mm1uRaA2RAJXGQ/xv9MdqIvUtyu7zLIO6Ql33Oiyinbc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788872585; c=relaxed/simple; bh=XX2epvmlLQo0RJnDrbcx87SCzNk+zSmVWGjPaOcT1bg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=VnYAqB64hffqKCFU3XfTpIkK/tX6oprjawjkRLRzF5qG5qgEc++WVJPO8HAjSRFzUlZ7ZM0u5A8n4e6r8P9ZO7PreImfgdpmzfnKYzwbDB1KYg3qtwt/H4OENgLaoiKzHxyQ5y+g8e7sPXgAjf4lEePQXMXHF7Z16Kg0qLO9ayo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=R28QCqYH; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=XasFuaGj; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="R28QCqYH"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="XasFuaGj" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 688Ckskc3013138 for ; Tue, 8 Sep 2026 13:02:40 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= G9od1/mMLI/E6Yx/CZZ9c+b1q/L+qRxzvRW2AXWCxeQ=; b=R28QCqYHddbxB2eq gy9q2fsTl+7J8OqbPuykazYU9/7D9Oau5u+2kfU1rUJk1qHJO9z3R1jEuKrbCiJY eAt5ISKZcWOp7GvXRSBrAitpX98MtOHf+YlCsRJjhiX3hbPdoNTOemvUgfhnwlcx iCvBo2uHhlgmAgpKX1Rg9slCTmrbObYodstgoa7RA6P+iANLhQoA06F6GTQqgWo9 RHVEMGrywjj/D5hKtNQFwT0+/8sWnRslPEVWd4A0AwfWwtDDeLl5Pm5rn163/BrR mO5Vxis+2ji3uF9n4OjRzHQI9xbGfcKciJmT+A7GSNVOM4GGcC4lbN0xg9P/V9MF t3Si7g== Received: from mail-ot1-f71.google.com (mail-ot1-f71.google.com [209.85.210.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gj1rwkhc3-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 08 Sep 2026 13:02:39 +0000 (GMT) Received: by mail-ot1-f71.google.com with SMTP id 46e09a7af769-7e9e4a02796so362681a34.2 for ; Tue, 08 Sep 2026 06:02:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1788872559; x=1789477359; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=G9od1/mMLI/E6Yx/CZZ9c+b1q/L+qRxzvRW2AXWCxeQ=; b=XasFuaGjtHl/qVPBZrPdsvjtTA7RAaOPrmvyzLJXJQK9CFspnQvWHPhU5rVj6EjS8N tgopwejtNJ/KGTYbgfz7XxKcigiqzodBNb4RlPBV9OyE9wyLShWL0P9t1Kv8IAq4es0M cHDv8tdxt38sO4jB/QZ/CHi/BizzM7HQGciX+PxUk2JDG3iXoO2G9yb0P/TqZFrg5MnI 4Z2kflJd2SuwG42qL0dTSiCkWFFTYjZRCT+nq/E2CdR0KIypzqOUdRx8cvShAJJT4IQY FZ/10V9tM2ut4NyY6+fr3/N3m8gSXfdSZa6qDQDZSsOsL70ZfNr2ToYGmxMfPbiilLnv 0Efg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788872559; x=1789477359; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=G9od1/mMLI/E6Yx/CZZ9c+b1q/L+qRxzvRW2AXWCxeQ=; b=cDh6IWRlg1CWiKrwqU2s3wPFB+3ZfgWmrTZ+cJUvMnaU0QxBtOQsMPLSGs12Xpd7yK ZdwSDu8g6UltnVVcuj59/uquOzdq2LtSkeFWNusMvDyq1s2XyF6N7T8/2JMeHZ1MRBjQ FU1N1uzPS3xXPS7v5EMVmjTeT2Ui0QTtuXT9QgRVToTn6YyNaPC8XVVrgmt+YVO7/Ztk F6JYhwblVaoGUcJcitW80XdA4DPCozbe0tDyGgBY92LIa9rKkNthfdJwEGfUuabccvwc wvy+wohTHGS1HZPX72tBqExixFeM7xfXFYIaYuH8Fca2dqvjSwRC5+kOv9dx/zQ0VqbL 3pzw== X-Forwarded-Encrypted: i=1; AKwUvByNOPOULDuyd0Xc5iieZDvXEkWcODG/jsQEf/aFhRQQFDnuz+WH5jRzIcEg+L2xqratJYNWwZmHEySe@vger.kernel.org X-Gm-Message-State: AFuF++ltNkoCLdAykL37vK0nXpLbRvsueWe8mu8Uuz13Bgp9kf2d/XyK zJJmr45+W8rMZjrDb6vbYFMTKVCJVjHaHtkNA6hId3/WfUX4U5nmZy+6/EHmfCGomnuM2T6GIXK uGvGvmrwjARlJR5VTVlfnyQjCYuBt48KpeaS4CmX6A5kId+wCg0SAdVniGKpSwrJO X-Gm-Gg: AYBFou2cMjDLrDGwYwBib6twlmfZJtgXhe2Jdhgok1GZ+RsmeqfZr6QCyr/TJ3qIn/9 idthInAPWQmHuTFb6s20MhRTt110nGFxplrIGOFZhGXTBUpZ11jJ3zeDwiRTMLyqZCQ0G+z1X9w V3PHTl1lIfG5ncIpPEM5LJoiuvS4OCViM7yyYtfq97OjBorAYNaf9zkTKNxq7fn0udP9zmr2UwS lcSm0FYeXOakgcTAxBp6lqwhsDqtU0ViNe6lRluXNL42gIY8nfrjNEVK+aGgyAtNrRgJBlxsYAK 7ptYdzpukf1Rd7qLFeNa4z7Hua0mPY9DUS75IGWK0gmXPM9Bwg0HsdLFso5Tf755YMWDtNGtSXM 8/Qho1F3lMO8LmvkIJqC+bQ== X-Received: by 2002:a05:6830:3c8e:b0:7f4:37a9:6df9 with SMTP id 46e09a7af769-7fb77233fb0mr13137948a34.0.1788872559124; Tue, 08 Sep 2026 06:02:39 -0700 (PDT) X-Received: by 2002:a05:6830:3c8e:b0:7f4:37a9:6df9 with SMTP id 46e09a7af769-7fb77233fb0mr13137846a34.0.1788872558370; Tue, 08 Sep 2026 06:02:38 -0700 (PDT) Received: from [192.168.202.12] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6a88b7c04edsm726386a12.15.2026.09.08.06.02.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 08 Sep 2026 06:02:37 -0700 (PDT) Message-ID: <83509feb-8776-4f61-9bc8-aca27d7c234b@oss.qualcomm.com> Date: Tue, 8 Sep 2026 15:02:32 +0200 Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 2/2] pinctrl: qcom: Add qcs615 lpass lpi pinctrl driver To: Karthik S , Bartosz Golaszewski , Bjorn Andersson , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260908075854.3015560-1-karthik.s@oss.qualcomm.com> <20260908075854.3015560-3-karthik.s@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260908075854.3015560-3-karthik.s@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=Ga8nWwXL c=1 sm=1 tr=0 ts=6aa0076f cx=c_pps a=OI0sxtj7PyCX9F1bxD/puw==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=EUspDBNiAAAA:8 a=BlYFBzphh5xgekHqNzEA:9 a=QEXdDO2ut3YA:10 a=Z1Yy7GAxqfX1iEi80vsk:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTA4MDE0MCBTYWx0ZWRfXzJLhUZvSYu2f 8PUV2NbqebBV+PwSBCHVon06hrEUlevZ8mA9zRHjru4LmxOUSEpsOxPUkVJzSXJzWNaW/PRo6OW hfytqW20dci8r02ZrjhsNyLcSFHP23C7akLtQCiXlDa3WChcQVKBiSISCHWnoL+Ad7/Tuhuv/iB smF5XPMZNMT6xJ2z+kw5gUyPg7/90KVpNhGYeOIcEEPoSYgqdrgZ+sMsCLyktkGi5YkR37ePH0u cGOU9Z2TnHrTWSZ7wX4c5T26MzX8i1mndzN92nyqEFZ2HzFLcDEBB2UeVeuTsLhT4HA1Xsei6qO P5oQu17prWJ6/EPWU45l2wWnOu01a5YJQHhA7dqkU8YUzoWabN+xkvcDK+33N0zVOpqVRVfir7b ME1RNrmqLODEnos86IO4nOlxuMFToJLxVzdWbO1m98yEl73dMEwVsyb5h9+leOPKLaKt+RDAWXt XqpU3p992r+SiFWPevA== X-Proofpoint-ORIG-GUID: TVSIc3pJr6hNkYsN8s76jQHqhsQkCfBL X-Proofpoint-GUID: TVSIc3pJr6hNkYsN8s76jQHqhsQkCfBL X-Proofpoint-Spam-Info: AW1haW4tMjYwOTA4MDE0MCBTYWx0ZWRfX44Bqn9CjEEFB XDJyhu26+fwv1VS2NeejPBCvb6Prb4TWCqYl721vrxROt4lHMeo/vOia/x9EUuqa4fDsxOFu2D0 Lv5zW8CATOUb3XSti8L1wM2L8CaToDk= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-08_02,2026-09-08_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 phishscore=0 suspectscore=0 clxscore=1015 impostorscore=0 bulkscore=0 spamscore=0 lowpriorityscore=0 priorityscore=1501 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2609080140 On 9/8/26 9:58 AM, Karthik S wrote: > Add pinctrl driver to support pin configuration for LPASS > (Low Power Audio SubSystem) LPI (Low Power Island) pinctrl > on QCS615. > > This IP is an additional pin control block for Audio Pins on top the > existing SoC Top level pin-controller. > > This pin controller has some similarities compared to Top level > msm SoC Pin controller like 'each pin belongs to a single group' > and so on. However this one is intended to control only audio > pins in particular, which can not be configured/touched by the > Top level SoC pin controller except setting them as gpios. > > Signed-off-by: Karthik S > --- > arch/arm64/configs/defconfig | 1 + > drivers/pinctrl/qcom/Kconfig | 10 + > drivers/pinctrl/qcom/Makefile | 1 + > .../pinctrl/qcom/pinctrl-qcs615-lpass-lpi.c | 185 ++++++++++++++++++ This patch produces dozens of compile warnings and is not split properly per subsystem. Also, it looks like the data you provided here is a subset of pinctrl-sdm670-lpass-lpi.c - is there a chance that the block is directly copy-pasted between these SoCs? Are the extra functions present on 670 also present on QCS615? Konrad