From: "Nuno Sá" <noname.nuno@gmail.com>
To: "Uwe Kleine-König" <ukleinek@kernel.org>, nuno.sa@analog.com
Cc: linux-gpio@vger.kernel.org, linux-pwm@vger.kernel.org,
devicetree@vger.kernel.org, linux-input@vger.kernel.org,
Lee Jones <lee@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Liu Ying <victor.liu@nxp.com>
Subject: Re: [PATCH v6 16/20] Input: adp5585: Add Analog Devices ADP5585/89 support
Date: Tue, 01 Jul 2025 10:19:03 +0100 [thread overview]
Message-ID: <83685a983e2134fd644a8720383408d4b452996a.camel@gmail.com> (raw)
In-Reply-To: <txppsdw4w7ocnysvrm54ta4ulplwawd5pk2l5wt3bhrag6qbev@gr4ah7lgjigi>
On Tue, 2025-07-01 at 10:39 +0200, Uwe Kleine-König wrote:
> On Mon, Jun 30, 2025 at 12:53:07PM +0100, Nuno Sá via B4 Relay wrote:
> > From: Nuno Sá <nuno.sa@analog.com>
> >
> > The ADP5585 is a 10/11 input/output port expander with a built in keypad
> > matrix decoder, programmable logic, reset generator, and PWM generator.
> > This driver supports the keyboard function using the platform device
> > registered by the core MFD driver.
> >
> > The ADP5589 has 19 pins and also features an unlock function.
> >
> > Changes in v6:
> > - Improve kconfig text.
>
> Is it intended to have the changelog for the series in the commit log in
> the end?
>
This is like DRM style.
> > Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> > Signed-off-by: Nuno Sá <nuno.sa@analog.com>
> > ---
>
> I would expect that not, so it should go here.
>
I did asked Lee before sending v6 but He likely missed it. I would add it here
but it is painful to do it with b4 so I ended up adding the log directly in the
commit message. b4 was removing git notes and I also don't like git notes adding
that "Notes:" line in the beginning. Do you have any suggestion on how you
handle this with b4 other than b4 send -o $DIR && git-send-mail?
- Nuno Sá
next prev parent reply other threads:[~2025-07-01 9:18 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-30 11:52 [PATCH v6 00/20] mfd: adp5585: support keymap events and drop legacy Input driver Nuno Sá via B4 Relay
2025-06-30 11:52 ` [PATCH v6 01/20] dt-bindings: mfd: adp5585: ease on the required properties Nuno Sá via B4 Relay
2025-06-30 11:52 ` [PATCH v6 02/20] mfd: adp5585: Only add devices given in FW Nuno Sá via B4 Relay
2025-06-30 11:52 ` [PATCH v6 03/20] mfd: adp5585: Enable oscilator during probe Nuno Sá via B4 Relay
2025-07-01 8:37 ` Uwe Kleine-König
2025-06-30 11:52 ` [PATCH v6 04/20] mfd: adp5585: Make use of MFD_CELL_NAME() Nuno Sá via B4 Relay
2025-06-30 11:52 ` [PATCH v6 05/20] dt-bindings: mfd: adp5585: document adp5589 I/O expander Nuno Sá via B4 Relay
2025-06-30 11:52 ` [PATCH v6 06/20] mfd: adp5585: Refactor how regmap defaults are handled Nuno Sá via B4 Relay
2025-06-30 11:52 ` [PATCH v6 07/20] mfd: adp5585: Add support for adp5589 Nuno Sá via B4 Relay
2025-06-30 11:52 ` [PATCH v6 08/20] mfd: adp5585: Add a per chip reg struture Nuno Sá via B4 Relay
2025-06-30 11:53 ` [PATCH v6 09/20] gpio: adp5585: add support for the adp5589 expander Nuno Sá via B4 Relay
2025-06-30 11:53 ` [PATCH v6 10/20] pwm: adp5585: add support for adp5589 Nuno Sá via B4 Relay
2025-06-30 11:53 ` [PATCH v6 11/20] dt-bindings: mfd: adp5585: add properties for input events Nuno Sá via B4 Relay
2025-06-30 11:53 ` [PATCH v6 12/20] mfd: adp5585: Add support for event handling Nuno Sá via B4 Relay
2025-06-30 11:53 ` [PATCH v6 13/20] mfd: adp5585: Support reset and unlock events Nuno Sá via B4 Relay
2025-06-30 11:53 ` [PATCH v6 14/20] mfd: adp5585: Add support for input devices Nuno Sá via B4 Relay
2025-06-30 11:53 ` [PATCH v6 15/20] gpio: adp5585: support gpi events Nuno Sá via B4 Relay
2025-06-30 11:53 ` [PATCH v6 16/20] Input: adp5585: Add Analog Devices ADP5585/89 support Nuno Sá via B4 Relay
2025-07-01 8:39 ` Uwe Kleine-König
2025-07-01 9:19 ` Nuno Sá [this message]
2025-07-01 13:43 ` Uwe Kleine-König
2025-07-01 13:46 ` Nuno Sá
2025-06-30 11:53 ` [PATCH v6 17/20] Input: adp5589: remove the driver Nuno Sá via B4 Relay
2025-07-01 8:41 ` Uwe Kleine-König
2025-06-30 11:53 ` [PATCH v6 18/20] mfd: adp5585: Support getting vdd regulator Nuno Sá via B4 Relay
2025-06-30 11:53 ` [PATCH v6 19/20] dt-bindings: mfd: adp5585: document reset gpio Nuno Sá via B4 Relay
2025-06-30 11:53 ` [PATCH v6 20/20] mfd: adp5585: Add support for a reset pin Nuno Sá via B4 Relay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83685a983e2134fd644a8720383408d4b452996a.camel@gmail.com \
--to=noname.nuno@gmail.com \
--cc=brgl@bgdev.pl \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=lee@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=robh@kernel.org \
--cc=ukleinek@kernel.org \
--cc=victor.liu@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).