From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shuah Khan Subject: Re: [PATCH 8/8] selftests: x86: override clean in lib.mk to fix warnings Date: Mon, 24 Apr 2017 13:48:41 -0600 Message-ID: <83d77bfe-6219-950e-82e0-4601a8ed010c@kernel.org> References: <31b94c5cb9a8f71fd3888b648f32c0bd91e4a9bd.1492815938.git.shuahkh@osg.samsung.com> <87o9vpyp6h.fsf@concordia.ellerman.id.au> <063D6719AE5E284EB5DD2968C1650D6DCFFD9941@AcuExch.aculab.com> Reply-To: shuah@kernel.org Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <063D6719AE5E284EB5DD2968C1650D6DCFFD9941@AcuExch.aculab.com> Sender: linux-kernel-owner@vger.kernel.org To: David Laight , 'Michael Ellerman' , Shuah Khan , "bamvor.zhangjian@linaro.org" , "benh@kernel.crashing.org" , "paulus@samba.org" , "dvhart@infradead.org" Cc: "linux-kselftest@vger.kernel.org" , "rkrcmar@redhat.com" , "dsafonov@virtuozzo.com" , "dave.hansen@linux.intel.com" , "linux-kernel@vger.kernel.org" , "emilio.lopez@collabora.co.uk" , "linux-gpio@vger.kernel.org" , "viro@zeniv.linux.org.uk" , "luto@kernel.org" , "linuxppc-dev@lists.ozlabs.org" , "mingo@kernel.org" , Shuah Khan List-Id: linux-gpio@vger.kernel.org On 04/24/2017 09:57 AM, David Laight wrote: > From: Linuxppc-dev Michael Ellerman >> Shuah Khan writes: >> >>> Add override for lib.mk clean to fix the following warnings from clean >>> target run. >>> >>> Makefile:44: warning: overriding recipe for target 'clean' >>> ../lib.mk:55: warning: ignoring old recipe for target 'clean' >>> >>> Signed-off-by: Shuah Khan >>> --- >>> tools/testing/selftests/x86/Makefile | 3 ++- >>> 1 file changed, 2 insertions(+), 1 deletion(-) >>> >>> diff --git a/tools/testing/selftests/x86/Makefile b/tools/testing/selftests/x86/Makefile >>> index 38e0a9c..4d27550 100644 >>> --- a/tools/testing/selftests/x86/Makefile >>> +++ b/tools/testing/selftests/x86/Makefile >>> @@ -40,8 +40,9 @@ all_32: $(BINARIES_32) >>> >>> all_64: $(BINARIES_64) >>> >>> -clean: >>> +override define CLEAN >>> $(RM) $(BINARIES_32) $(BINARIES_64) >>> +endef >> >> Simpler as: >> >> EXTRA_CLEAN := $(BINARIES_32) $(BINARIES_64) > > Actually for builds that insist on crapping all over the source tree I've used: > > clean: > rm -rf `cat .cvsignore 2>/dev/null` > > David This will have to be done as a separate change. The warnings I am fixing are related to common clean target in lib.mk and the need to override. thanks, -- Shuah