From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Jim Liu <jim.t90615@gmail.com>,
JJLIU0@nuvoton.com, KWLIU@nuvoton.com, linus.walleij@linaro.org,
brgl@bgdev.pl, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org
Cc: linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, openbmc@lists.ozlabs.org
Subject: Re: [PATCH v5 1/3] gpio: nuvoton: Add Nuvoton NPCM sgpio driver
Date: Tue, 14 Mar 2023 19:48:41 +0100 [thread overview]
Message-ID: <83de8add-b15e-8578-7bf9-56c3f26df836@linaro.org> (raw)
In-Reply-To: <20230314092311.8924-2-jim.t90615@gmail.com>
On 14/03/2023 10:23, Jim Liu wrote:
> Add Nuvoton BMC NPCM7xx/NPCM8xx sgpio driver support.
>
> Signed-off-by: Jim Liu <jim.t90615@gmail.com>
(...)
> + gpio->nin_sgpio = nin_gpios;
> + gpio->nout_sgpio = nout_gpios;
> + if (gpio->nin_sgpio > MAX_NR_HW_SGPIO || gpio->nout_sgpio > MAX_NR_HW_SGPIO) {
> + dev_err(&pdev->dev, "Number of GPIOs exceeds the maximum of %d: input: %d output: %d\n",
> + MAX_NR_HW_SGPIO, nin_gpios, nout_gpios);
> + return -EINVAL;
> + }
> +
> + rc = device_property_read_u32(&pdev->dev, "bus-frequency", &sgpio_freq);
NAK. I don't understand that approach - you dropped it from the binding
so the binding will pass review?
> + if (rc < 0) {
> + dev_err(&pdev->dev, "Could not read bus-frequency property\n");
> + return -EINVAL;
> + }
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-03-14 18:49 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-14 9:23 [PATCH v5 0/3]Add Nuvoton NPCM SGPIO feature Jim Liu
2023-03-14 9:23 ` [PATCH v5 1/3] gpio: nuvoton: Add Nuvoton NPCM sgpio driver Jim Liu
2023-03-14 11:46 ` Paul Menzel
2023-07-24 3:04 ` Jim Liu
2023-07-24 14:44 ` Paul Menzel
2023-07-25 9:12 ` Jim Liu
2023-03-14 18:38 ` Linus Walleij
2023-03-14 18:48 ` Krzysztof Kozlowski [this message]
2023-03-14 9:23 ` [PATCH v5 2/3] arm: dts: nuvoton: npcm: Add sgpio feature Jim Liu
2023-03-14 18:47 ` Krzysztof Kozlowski
2023-03-14 18:49 ` Krzysztof Kozlowski
2023-03-14 9:23 ` [PATCH v5 3/3] dt-bindings: gpio: add NPCM sgpio driver bindings Jim Liu
2023-03-14 18:45 ` Krzysztof Kozlowski
2023-03-15 7:54 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83de8add-b15e-8578-7bf9-56c3f26df836@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=JJLIU0@nuvoton.com \
--cc=KWLIU@nuvoton.com \
--cc=brgl@bgdev.pl \
--cc=devicetree@vger.kernel.org \
--cc=jim.t90615@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=openbmc@lists.ozlabs.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).