Linux GPIO subsystem development
 help / color / mirror / Atom feed
From: "Yu-Chun Lin [林祐君]" <eleanor.lin@realtek.com>
To: "hpp.iscas" <hppiscas@163.com>,
	"James Tai [戴志峰]" <james.tai@realtek.com>
Cc: "Andreas Färber" <afaerber@suse.com>,
	"Linus Walleij" <linusw@kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"linux-realtek-soc@lists.infradead.org"
	<linux-realtek-soc@lists.infradead.org>,
	"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"TY_Chang[張子逸]" <tychang@realtek.com>
Subject: RE: [PATCH] pinctrl: realtek: rtd1619b: Publish the OF module alias
Date: Mon, 7 Sep 2026 06:13:41 +0000	[thread overview]
Message-ID: <84a7569139af472aaf704c6517b04f69@realtek.com> (raw)
In-Reply-To: <20260905134418.67619-1-hppiscas@163.com>

Hi,

> The RTD1619B pinctrl driver is a separate tristate object using
> 
> rtd1619b_pinctrl_of_match. The generic Realtek pinctrl support does not
> 
> publish an alias for this SoC module.
> 
> 
> 
> Export the existing OF table while retaining the initialization order.
> 
> 
> 
> Fixes: c7910f6aca56 ("pinctrl: realtek: Add pinctrl driver for RTD1619B")
> 
> Signed-off-by: hpp.iscas <hppiscas@163.com>
> 

Please use your real name.

> ---
> 
>  drivers/pinctrl/realtek/pinctrl-rtd1619b.c | 1 +
> 
>  1 file changed, 1 insertion(+)
> 
> 
> 
> diff --git a/drivers/pinctrl/realtek/pinctrl-rtd1619b.c
> b/drivers/pinctrl/realtek/pinctrl-rtd1619b.c
> 
> index b07e50d..e03e1fb 100644
> 
> --- a/drivers/pinctrl/realtek/pinctrl-rtd1619b.c
> 
> +++ b/drivers/pinctrl/realtek/pinctrl-rtd1619b.c
> 
> @@ -1575,6 +1575,7 @@ static const struct of_device_id
> rtd1619b_pinctrl_of_match[] = {
> 
>         { .compatible = "realtek,rtd1619b-pinctrl", },
> 
>         {},
> 
>  };
> 
> +MODULE_DEVICE_TABLE(of, rtd1619b_pinctrl_of_match);
> 
> 
> 
>  static struct platform_driver rtd1619b_pinctrl_driver = {
> 
>         .driver = {
> 

The code looks good to me, but 'git am' failed to apply the mbox. 
I noticed =0D in your patch, which might be the reason it failed.

Best Regards,
Yu-Chun

      reply	other threads:[~2026-09-07  6:14 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-05 13:44 [PATCH] pinctrl: realtek: rtd1619b: Publish the OF module alias hpp.iscas
2026-09-07  6:13 ` Yu-Chun Lin [林祐君] [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=84a7569139af472aaf704c6517b04f69@realtek.com \
    --to=eleanor.lin@realtek.com \
    --cc=afaerber@suse.com \
    --cc=hppiscas@163.com \
    --cc=james.tai@realtek.com \
    --cc=linusw@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-realtek-soc@lists.infradead.org \
    --cc=tychang@realtek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox