From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37D12C4332F for ; Fri, 21 Oct 2022 01:49:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229597AbiJUBtj (ORCPT ); Thu, 20 Oct 2022 21:49:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33746 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229494AbiJUBti (ORCPT ); Thu, 20 Oct 2022 21:49:38 -0400 Received: from mail-qt1-x832.google.com (mail-qt1-x832.google.com [IPv6:2607:f8b0:4864:20::832]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7884828732 for ; Thu, 20 Oct 2022 18:49:34 -0700 (PDT) Received: by mail-qt1-x832.google.com with SMTP id z8so822735qtv.5 for ; Thu, 20 Oct 2022 18:49:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=bhTPHw6m01ivIl5RP7SgmYgR4aeFNKpBx1oq6+x6jqI=; b=PH94WdZcySmAk0x5o+sfHL31KorX2Vj6nQa1iUqG29/oqIAPsPF5ozDI40W+ta1R7O iW4Cyrx3Sk04pTC13fql/o2ZFSBLuWhzyrHNtSeP01XRIQnp4mRHeuplNtJ/5LS1ShW/ LxA8obB+aGdM7niZe48QRKmAtqOrki24GmUessv9Cr+O3zXqfqBpnOgqthKHH4U18R+B HsoDqg20r5ooFHn/xsKF5IxngjuALUpsKKO9SmTwe3I97gsVLO7ROJP9SjhIC96yCTwX hKVf6hB8syJsM33hZ+HkS0dDOWE7OCxZMClPWdP9E9ogGG5k3wI9BES2R35Nt4walgG1 LH1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=bhTPHw6m01ivIl5RP7SgmYgR4aeFNKpBx1oq6+x6jqI=; b=4CX4tHmVOddsaOxwoVl8MpYD3oAKRDxh4vvhaXZ7HcfwsC5saqZ+GrYjLAv9rNZVR/ 1VocnA0owvSp98s3KSe6PEFgGha4DnpiO/vArw0HwF7UBxDsmfPYvRpb25GkSZkOxXxf KL0N+c2mtDwjco7yyngBFXXxXYTHDosTjmp5Mnrr7/b53gioVFSBHgoDf5iNx+QISJ9I rYffs7ecD6o/5kqh6DhPiNxCk3jqPs/Tgw0gs9ADSYRI9PEHjLCm3uBHfSSwGS6tRFtq PVZI6ew1CdTFtbsgogNGj4d2x+VPku8eTB+a0gRjgjJDYLrP7D430n7VQkvHh3sx/329 K5VQ== X-Gm-Message-State: ACrzQf2RgUd9PaHZMenM/YCDKLDeBJaV8jPzbe1Ais2sjOU9ewlJQktV Vvs38IK536GDqq+715NbuE+Mig== X-Google-Smtp-Source: AMsMyM6iSKSGcrQTOth/ykMt2G2vxCwAkUH2+KwmrRBiaoyOTlc7iMdLDEhnuBe6EdCCRW/Pxc0Gsw== X-Received: by 2002:a05:622a:11cc:b0:39c:d274:6a25 with SMTP id n12-20020a05622a11cc00b0039cd2746a25mr13775368qtk.686.1666316973580; Thu, 20 Oct 2022 18:49:33 -0700 (PDT) Received: from [192.168.10.124] (pool-72-83-177-149.washdc.east.verizon.net. [72.83.177.149]) by smtp.gmail.com with ESMTPSA id m15-20020a05620a13af00b006ee949b8051sm8450377qki.51.2022.10.20.18.49.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 20 Oct 2022 18:49:32 -0700 (PDT) Message-ID: <86b4da48-bc69-65cb-1e1d-4b9efaadf732@linaro.org> Date: Thu, 20 Oct 2022 21:49:31 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [PATCH v1 2/2] dt-bindings: pinctrl: add loongson2 pinctrl Content-Language: en-US To: Yinbo Zhu , Linus Walleij , Rob Herring , Krzysztof Kozlowski , linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, zhanghongchen References: <20221021012728.22373-1-zhuyinbo@loongson.cn> <20221021012728.22373-2-zhuyinbo@loongson.cn> From: Krzysztof Kozlowski In-Reply-To: <20221021012728.22373-2-zhuyinbo@loongson.cn> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On 20/10/2022 21:27, Yinbo Zhu wrote: > Add the loongson2 pinctrl binding with DT schema format using > json-schema. > > Signed-off-by: Yinbo Zhu > --- > .../pinctrl/loongson,ls2k-pinctrl.yaml | 118 ++++++++++++++++++ > MAINTAINERS | 1 + > 2 files changed, 119 insertions(+) > create mode 100644 Documentation/devicetree/bindings/pinctrl/loongson,ls2k-pinctrl.yaml > > diff --git a/Documentation/devicetree/bindings/pinctrl/loongson,ls2k-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/loongson,ls2k-pinctrl.yaml > new file mode 100644 > index 000000000000..038d38ad1785 > --- /dev/null > +++ b/Documentation/devicetree/bindings/pinctrl/loongson,ls2k-pinctrl.yaml > @@ -0,0 +1,118 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/pinctrl/loongson,ls2k-pinctrl.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Loongson2 SoC Pinctrl Controller > + > +maintainers: > + - zhanghongchen > + - Yinbo Zhu > + Missing $ref to pinctrl.yaml > +properties: > + compatible: > + const: loongson,ls2k-pinctrl > + > + reg: > + maxItems: 1 > + > +required: > + - compatible > + - reg Put required after patternProperties. > + > +patternProperties: > + '-pins$': > + type: object additionalProperties: false and blank line > + patternProperties: > + 'pinmux$': > + type: object > + description: node for pinctrl. > + $ref: pinmux-node.yaml# unevaluatedProperties: false But actually you have here totally broken indentation and this simply does not work. I doubt you really tested it. > + > + properties: > + groups: > + description: > + One or more groups of pins to mux to a certain function > + items: > + enum: [gpio, sdio, can1, can0, pwm3, pwm2, pwm1, pwm0, i2c1, i2c0, > + nand, sata_led, lio, i2s, hda, uart2, uart1, camera, dv01, > + dvo0] > + function: > + description: > + The function that a group of pins is muxed to > + items: > + enum: [gpio, sdio, can1, can0, pwm3, pwm2, pwm1, pwm0, i2c1, i2c0, > + nand, sata_led, lio, i2s, hda, uart2, uart1, camera, dv01, > + dvo0] > + > + dependencies: > + groups: [function] > + function: [groups] > + > +additionalProperties: false > + > +examples: > + - | > + pctrl: pinctrl@1fe00420 { > + compatible = "loongson,ls2k-pinctrl"; > + reg = <0x1fe00420 0x18>; Use 4 spaces for example indentation. > + sdio_pins_default: sdio-pins { > + sdio-pinmux { > + groups ="sdio"; > + function ="sdio"; > + }; > + > + sdio-det-pinmux { > + groups ="pwm2"; > + function ="gpio"; > + }; Best regards, Krzysztof