From: Thomas Gleixner <tglx@linutronix.de>
To: Charles Keepax <ckeepax@opensource.cirrus.com>,
Yan Zhen <yanzhen@vivo.com>
Cc: rf@opensource.cirrus.com, linus.walleij@linaro.org,
linux-sound@vger.kernel.org, patches@opensource.cirrus.com,
linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
opensource.kernel@vivo.com
Subject: Re: [PATCH v1] cirrus: Simplify with dev_err_probe()
Date: Wed, 28 Aug 2024 16:47:49 +0200 [thread overview]
Message-ID: <8734mod7qi.ffs@tglx> (raw)
In-Reply-To: <Zs8XlyXw421hHjM/@opensource.cirrus.com>
On Wed, Aug 28 2024 at 13:27, Charles Keepax wrote:
> On Wed, Aug 28, 2024 at 08:01:18PM +0800, Yan Zhen wrote:
>> @@ -1064,10 +1064,9 @@ static int madera_pin_probe(struct platform_device *pdev)
>> ret = pinctrl_register_mappings(pdata->gpio_configs,
>> pdata->n_gpio_configs);
>> if (ret) {
>> - dev_err(priv->dev,
>> - "Failed to register pdata mappings (%d)\n",
>> - ret);
>> - return ret;
>> + return dev_err_probe(priv->dev, ret,
>> + "Failed to register pdata mappings (%d)\n",
>> + ret);
>> }
>
> Since we are doing a respin anyway also the brackets on the if
> should be dropped on both of these as well.
No. https://www.kernel.org/doc/html/latest/process/maintainer-tip.html#bracket-rules
Thanks,
tglx
next prev parent reply other threads:[~2024-08-28 14:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-28 12:01 [PATCH v1] cirrus: Simplify with dev_err_probe() Yan Zhen
2024-08-28 12:08 ` Richard Fitzgerald
2024-08-28 12:27 ` Charles Keepax
2024-08-28 14:47 ` Thomas Gleixner [this message]
2024-08-28 14:59 ` Richard Fitzgerald
2024-08-28 16:11 ` Charles Keepax
2024-08-28 18:12 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8734mod7qi.ffs@tglx \
--to=tglx@linutronix.de \
--cc=ckeepax@opensource.cirrus.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=opensource.kernel@vivo.com \
--cc=patches@opensource.cirrus.com \
--cc=rf@opensource.cirrus.com \
--cc=yanzhen@vivo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).