* [PATCH] pinctrl: spacemit: destroy mutex at driver detach
@ 2025-03-05 10:27 Bartosz Golaszewski
2025-03-05 10:34 ` Yixun Lan
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Bartosz Golaszewski @ 2025-03-05 10:27 UTC (permalink / raw)
To: Linus Walleij, Yixun Lan
Cc: linux-gpio, linux-riscv, spacemit, linux-kernel,
Bartosz Golaszewski
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
The mutex initialized in probe() is never cleaned up. Use
devm_mutex_init() to destroy it automatically.
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
---
drivers/pinctrl/spacemit/pinctrl-k1.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/pinctrl/spacemit/pinctrl-k1.c b/drivers/pinctrl/spacemit/pinctrl-k1.c
index 59fd555ff38d..67e867b04a02 100644
--- a/drivers/pinctrl/spacemit/pinctrl-k1.c
+++ b/drivers/pinctrl/spacemit/pinctrl-k1.c
@@ -9,6 +9,7 @@
#include <linux/seq_file.h>
#include <linux/spinlock.h>
#include <linux/module.h>
+#include <linux/mutex.h>
#include <linux/pinctrl/pinconf-generic.h>
#include <linux/pinctrl/pinconf.h>
@@ -749,7 +750,10 @@ static int spacemit_pinctrl_probe(struct platform_device *pdev)
pctrl->data = pctrl_data;
pctrl->dev = dev;
raw_spin_lock_init(&pctrl->lock);
- mutex_init(&pctrl->mutex);
+
+ ret = devm_mutex_init(dev, &pctrl->mutex);
+ if (ret)
+ return ret;
platform_set_drvdata(pdev, pctrl);
--
2.45.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] pinctrl: spacemit: destroy mutex at driver detach
2025-03-05 10:27 [PATCH] pinctrl: spacemit: destroy mutex at driver detach Bartosz Golaszewski
@ 2025-03-05 10:34 ` Yixun Lan
2025-03-05 13:31 ` Javier Martinez Canillas
2025-03-14 10:02 ` Linus Walleij
2 siblings, 0 replies; 4+ messages in thread
From: Yixun Lan @ 2025-03-05 10:34 UTC (permalink / raw)
To: Bartosz Golaszewski
Cc: Linus Walleij, linux-gpio, linux-riscv, spacemit, linux-kernel,
Bartosz Golaszewski
On 11:27 Wed 05 Mar , Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>
> The mutex initialized in probe() is never cleaned up. Use
> devm_mutex_init() to destroy it automatically.
>
Reviewed-by: Yixun Lan <dlan@gentoo.org>
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> ---
> drivers/pinctrl/spacemit/pinctrl-k1.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/spacemit/pinctrl-k1.c b/drivers/pinctrl/spacemit/pinctrl-k1.c
> index 59fd555ff38d..67e867b04a02 100644
> --- a/drivers/pinctrl/spacemit/pinctrl-k1.c
> +++ b/drivers/pinctrl/spacemit/pinctrl-k1.c
> @@ -9,6 +9,7 @@
> #include <linux/seq_file.h>
> #include <linux/spinlock.h>
> #include <linux/module.h>
> +#include <linux/mutex.h>
>
> #include <linux/pinctrl/pinconf-generic.h>
> #include <linux/pinctrl/pinconf.h>
> @@ -749,7 +750,10 @@ static int spacemit_pinctrl_probe(struct platform_device *pdev)
> pctrl->data = pctrl_data;
> pctrl->dev = dev;
> raw_spin_lock_init(&pctrl->lock);
> - mutex_init(&pctrl->mutex);
> +
> + ret = devm_mutex_init(dev, &pctrl->mutex);
> + if (ret)
> + return ret;
>
> platform_set_drvdata(pdev, pctrl);
>
> --
> 2.45.2
>
--
Yixun Lan (dlan)
Gentoo Linux Developer
GPG Key ID AABEFD55
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] pinctrl: spacemit: destroy mutex at driver detach
2025-03-05 10:27 [PATCH] pinctrl: spacemit: destroy mutex at driver detach Bartosz Golaszewski
2025-03-05 10:34 ` Yixun Lan
@ 2025-03-05 13:31 ` Javier Martinez Canillas
2025-03-14 10:02 ` Linus Walleij
2 siblings, 0 replies; 4+ messages in thread
From: Javier Martinez Canillas @ 2025-03-05 13:31 UTC (permalink / raw)
To: Bartosz Golaszewski, Linus Walleij, Yixun Lan
Cc: linux-gpio, linux-riscv, spacemit, linux-kernel,
Bartosz Golaszewski
Bartosz Golaszewski <brgl@bgdev.pl> writes:
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>
> The mutex initialized in probe() is never cleaned up. Use
> devm_mutex_init() to destroy it automatically.
>
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> ---
Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] pinctrl: spacemit: destroy mutex at driver detach
2025-03-05 10:27 [PATCH] pinctrl: spacemit: destroy mutex at driver detach Bartosz Golaszewski
2025-03-05 10:34 ` Yixun Lan
2025-03-05 13:31 ` Javier Martinez Canillas
@ 2025-03-14 10:02 ` Linus Walleij
2 siblings, 0 replies; 4+ messages in thread
From: Linus Walleij @ 2025-03-14 10:02 UTC (permalink / raw)
To: Bartosz Golaszewski
Cc: Yixun Lan, linux-gpio, linux-riscv, spacemit, linux-kernel,
Bartosz Golaszewski
On Wed, Mar 5, 2025 at 11:27 AM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>
> The mutex initialized in probe() is never cleaned up. Use
> devm_mutex_init() to destroy it automatically.
>
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Patch applied!
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-03-14 10:02 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-03-05 10:27 [PATCH] pinctrl: spacemit: destroy mutex at driver detach Bartosz Golaszewski
2025-03-05 10:34 ` Yixun Lan
2025-03-05 13:31 ` Javier Martinez Canillas
2025-03-14 10:02 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).