From: Thomas Gleixner <tglx@linutronix.de>
To: David Wang <00107082@163.com>, linus.walleij@linaro.org, brgl@bgdev.pl
Cc: linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
geert@linux-m68k.org, David Wang <00107082@163.com>
Subject: Re: [PATCH] Fix a potential abuse of seq_printf() format string in drivers
Date: Fri, 22 Nov 2024 20:54:29 +0100 [thread overview]
Message-ID: <878qtbyrgq.ffs@tglx> (raw)
In-Reply-To: <20241120053055.225195-1-00107082@163.com>
On Wed, Nov 20 2024 at 13:30, David Wang wrote:
> Using device name as format string of seq_printf() is proned to
> "Format string attack", opens possibility for exploitation.
> Seq_puts() is safer and more efficient.
>
> Signed-off-by: David Wang <00107082@163.com>
> ---
> drivers/gpio/gpio-aspeed-sgpio.c | 2 +-
> drivers/gpio/gpio-aspeed.c | 2 +-
> drivers/gpio/gpio-ep93xx.c | 2 +-
> drivers/gpio/gpio-hlwd.c | 2 +-
> drivers/gpio/gpio-mlxbf2.c | 2 +-
> drivers/gpio/gpio-omap.c | 2 +-
> drivers/gpio/gpio-pca953x.c | 2 +-
> drivers/gpio/gpio-pl061.c | 2 +-
> drivers/gpio/gpio-tegra.c | 2 +-
> drivers/gpio/gpio-tegra186.c | 2 +-
> drivers/gpio/gpio-tqmx86.c | 2 +-
> drivers/gpio/gpio-visconti.c | 2 +-
> drivers/gpio/gpio-xgs-iproc.c | 2 +-
> drivers/irqchip/irq-gic.c | 2 +-
> drivers/irqchip/irq-mvebu-pic.c | 2 +-
> drivers/irqchip/irq-versatile-fpga.c | 2 +-
> drivers/pinctrl/bcm/pinctrl-iproc-gpio.c | 2 +-
> drivers/pinctrl/mvebu/pinctrl-armada-37xx.c | 2 +-
> drivers/pinctrl/pinctrl-mcp23s08.c | 2 +-
> drivers/pinctrl/pinctrl-stmfx.c | 2 +-
> drivers/pinctrl/pinctrl-sx150x.c | 2 +-
> drivers/pinctrl/renesas/pinctrl-rzg2l.c | 2 +-
Can you please split these patches per subsystem (gpio, irqchip,
pinctrl) so that the respective maintainers can pick them up
individually?
Thanks,
tglx
prev parent reply other threads:[~2024-11-22 19:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-20 5:30 [PATCH] Fix a potential abuse of seq_printf() format string in drivers David Wang
2024-11-20 7:35 ` Linus Walleij
2024-11-20 9:00 ` David Wang
2024-11-20 18:12 ` Kees Cook
2024-11-20 19:28 ` Greg Kroah-Hartman
2024-11-22 4:38 ` Kees Cook
2024-11-22 14:35 ` Greg Kroah-Hartman
2024-11-22 19:54 ` Thomas Gleixner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878qtbyrgq.ffs@tglx \
--to=tglx@linutronix.de \
--cc=00107082@163.com \
--cc=brgl@bgdev.pl \
--cc=geert@linux-m68k.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).